https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #0)

When 'OpacPublic' is set to NO, a successful login will load the main OPAC page (opac-main.pl), that's good, correct and expected

The bug is that with 'OpacPublic' set to OFF and 'GoogleOpenIDConnect' set ON - a successful login redirects the user to their account page (opac-user.pl) not the main OPAC page, that's unexpected and bad

oops, s/NO/OFF/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |10988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 [Bug 10988] Allow login via Google OAuth2 (OpenID Connect) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Depends on| |18144 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Google Open ID Connect authentication broke when bug 17486 was pushed. Need to fix it before testing this. See bug 18144. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 [Bug 18144] Removal of persona broke openidconnect -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 Bug 18118 depends on bug 18144, which changed state. Bug 18144 Summary: Removal of persona broke Google OAuth2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18144 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 Bug 18118 depends on bug 10988, which changed state. Bug 10988 Summary: Allow login via Google OAuth2 (OpenID Connect) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- The instructions are generally on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892#c3 The difficulty is Google keeps changing their API so it is a pain. Between steps 10 and 11: Once you've created the project, and you get the nice notification in the top right (bell should have a pretty red 1) click the notification and you will be taken to a massive information overload page where it makes no sense to a normal person with many boxes. In the top left, you will notice that the top left area will have a nice three line square beside "Google APIs" and then the project you just created in a drop down. Click the three line square. This will give you a drop down left pane that has "API & Services" at the top. Hover over it, and then you will get a submenu with 'Credentials' at the bottom. Step 11: Click credentials -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Okay... So currently: OpacPublic: Disabled, GoogleOpenIDConnect: No -> General search page OpacPublic: Enabled, GoogleOpenIDConnect: No -> User Page OpacPublic: Disabled, GoogleOpenIDConnect: Yes -> User Page OpacPublic: Enabled, GoogleOpenIDConnect: Yes -> User Page Hence the test plan where GoogleOpenIDConnect is Yes, and OpacPublic is Disabled.

1/ configure a working 'GoogleOpenIDConnect' account

See comment #5 which also links back to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892#c3

2/ set 'OpacPublic' (under OPAC) to 'Disabled' and 'GoogleOpenIDConnect' (under Administration) to 'Yes'.

3/ log in user successfully via google-auth, observe redirect to opac-user.pl (bad)

As noted above in my preliminary testing.

4/ apply patch

-- on kohadevbox remember to restart all! Plack is unforgiving. :)

5/ log in user successfully via google-auth, observe expected redirect to opac-main.pl (good)

-- which matches the behaviour regardless of GoogleOpenIDConnect, as it should. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60236|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 68237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68237&action=edit Bug 18118 - Unexpected behaviour with 'GoogleOpenIDConnect' and 'OpacPublic' syspref combination. TEST PLAN ---------- 1/ configure a working 'GoogleOpenIDConnect' account See comment #5 which also links back to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892#c3 2/ set 'OpacPublic' (under OPAC) to 'Disabled' and 'GoogleOpenIDConnect' (under Administration) to 'Yes'. 3/ log in user successfully via google-auth, observe redirect to opac-user.pl (bad) 4/ apply patch -- on kohadevbox remember to restart all! Plack is unforgiving. :) 5/ log in user successfully via google-auth, observe expected redirect to opac-main.pl (good) While I would normally suggest running koha qa test tools, because this file doesn't end in .pl, it doesn't get picked up by them. 6/ perlcritic -4 opac/svc/auth/googleopenidconnect -- notice this is a level better than required. :) This also eyeballs easily well. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.