[Bug 19029] New: Move the clone button and implement a security question on smart-rules.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Bug ID: 19029 Summary: Move the clone button and implement a security question on smart-rules.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: alexbuckley@catalyst.net.nz Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 19027 When users create a circulation rule which they want to be applied to multiple library branches they will click "Standard rules to all libraries" (from bug 19027) However they may accidentally hit the 'clone' button, to clone the rule to a specific library. When the rule is being applied to all libraries with the 'standard' option then the only use case for clicking the 'clone' button would be to then adapt the rule in that specific library. This is not a common use case and users may accidentally hit the 'clone' button without understanding it fully. Therefore this bug report suggests that a security question be displayed to be ask the user if they are sure about cloning the rule to a specific library. Additionally the clone button should be moved to a slightly different placement on the page. Can we please have some feedback on this idea Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19027 [Bug 19027] Circulation rules: Better wording for standard rules for all libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- +1 :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We usually have 'do you really want to...' questions for deleting data. As cloning overwrites the existing rules completely and currently without warning, I think the alert would fit in our patterns and be really helpful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 66519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66519&action=edit Bug 19029 - Added JavaScript security question for cloning circ rules This patch introduces a Javascript security question which is displayed to the user when they try to clone a circulation rule to a specific branch when the rule is a 'Standard rule for all libraries" The rationale for this patch is when the cloning takes place it overwrites the existing rules of the destination branch and there is no notification of this to the user. Therefore by implementing this patch the user is asked if they want to clone the rule (if the rule is standard accross all libraries) and are told that it will overwrite the rules in the destination branch. Test plan: 1. Create a circulation rule for all libraries 2. Make sure the 'select a library' option is set to 'Standard rules for all libraries" 3. Click the 'Clone' button and notice that the cloning takes place without any warning that it will overwrite the rules of the destination branch 4. Apply patch 5. Return to the circulation and fine rules page 6. Repeat step 2 7. Click the clone button and notice a alert box appears asking if you are sure you want to clone the standard rule to the destination branch. Note: The name of the destination branch is included in the alert. Also note that the user is informed of the consequences of performing the action, i.e. that it will overwrite the existing rules in the destination branch 8. Click 'Cancel' and notice that no cloning occurs 9. Click the clone button again and this time click 'OK' and notice that the cloning takes place 10. Return to the Circulation and fine rules page and set the 'Select a library' option to the name of an individual branch 11. Click the clone button and notice that the clone action takes place Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5592 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- In the patch I have attach I implemented a security question but have not moved the clone button, please let me know if you think I need to move the clone button as well, because I personally think the security question is a great improvement on the previous behaviour and the moving of the clone button is not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #6 from Marc Véron <veron@veron.ch> --- While testing I get: 'Cloning of circulation and fine rules failed!' Plack error log says: DBD::mysql::st execute failed: Duplicate entry '5' for key 'PRIMARY' [for Statement "INSERT INTO issuingrules SELECT * FROM tmpissuingrules WHERE branchcode=?" with ParamValues: 0="MPL"] at /home/marc/koha/admin/clone-rules.pl line 86. Seems to be a separate bug, but it makes impossible to test here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18231 --- Comment #7 from Marc Véron <veron@veron.ch> --- (In reply to Marc Véron from comment #6)
While testing I get: 'Cloning of circulation and fine rules failed!' Plack error log says: DBD::mysql::st execute failed: Duplicate entry '5' for key 'PRIMARY' [for Statement "INSERT INTO issuingrules SELECT * FROM tmpissuingrules WHERE branchcode=?" with ParamValues: 0="MPL"] at /home/marc/koha/admin/clone-rules.pl line 86.
Seems to be a separate bug, but it makes impossible to test here.
Could be related to Bug 18231 - Add the missing id-column to koha.issuingrules-table for DBIC fixtures -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66519|0 |1 is obsolete| | --- Comment #8 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 67323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67323&action=edit Bug 19029 - Added JavaScript security question for cloning circ rules This patch introduces a Javascript security question which is displayed to the user when they try to clone a circulation rule to a specific branch when the rule is a 'Standard rule for all libraries" The rationale for this patch is when the cloning takes place it overwrites the existing rules of the destination branch and there is no notification of this to the user. Therefore by implementing this patch the user is asked if they want to clone the rule (if the rule is standard accross all libraries) and are told that it will overwrite the rules in the destination branch. Test plan: 1. Create a circulation rule for all libraries 2. Make sure the 'select a library' option is set to 'Standard rules for all libraries" 3. Click the 'Clone' button and notice that the cloning takes place without any warning that it will overwrite the rules of the destination branch 4. Apply patch 5. Return to the circulation and fine rules page 6. Repeat step 2 7. Click the clone button and notice a alert box appears asking if you are sure you want to clone the standard rule to the destination branch. Note: The name of the destination branch is included in the alert. Also note that the user is informed of the consequences of performing the action, i.e. that it will overwrite the existing rules in the destination branch 8. Click 'Cancel' and notice that no cloning occurs 9. Click the clone button again and this time click 'OK' and notice that the cloning takes place 10. Return to the Circulation and fine rules page and set the 'Select a library' option to the name of an individual branch 11. Click the clone button and notice that the clone action takes place Sponsored-By: Catalyst IT Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com Status|Needs Signoff |Signed Off --- Comment #9 from David Bourgault <david.bourgault@inlibro.com> --- The patch works as planned - the security question only shows when cloning from standard rules. However I feel like it would be better to apply the security question to all cloning operations. Saving users the trouble of an accidental cloning is better than having 1 less click to do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Alex, you should use .format() to ease translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67529&action=edit Bug 19029 - Followup - Implemented .format() to ease translation Sponosred by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move the clone button and |Implement a security |implement a security |question for cloning |question on smart-rules.tt |circulation conditions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There seems to be no security question for cloning conditions from one library to another. I think it would be good to be consistent and always ask, as cloning accidentally can create quite a chaos. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67980&action=edit Bug 19029 - Followup: Make security question appear on clone operations from one library to another Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi all I have just attached a patch which implements the security question on clone operations from one library to another which Katrin suggested in comment 12. Could the 2 follow-up patches be tested please -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67980|0 |1 is obsolete| | --- Comment #15 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 67983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67983&action=edit Bug 19029 - Followup: Make security question appear on clone operations from one library to another Message pops up for all instances of cloning now. Works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67323|0 |1 is obsolete| | Attachment #67529|0 |1 is obsolete| | Attachment #67983|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68688&action=edit Bug 19029 - Added JavaScript security question for cloning circ rules This patch introduces a Javascript security question which is displayed to the user when they try to clone a circulation rule to a specific branch when the rule is a 'Standard rule for all libraries" The rationale for this patch is when the cloning takes place it overwrites the existing rules of the destination branch and there is no notification of this to the user. Therefore by implementing this patch the user is asked if they want to clone the rule (if the rule is standard accross all libraries) and are told that it will overwrite the rules in the destination branch. Test plan: 1. Create a circulation rule for all libraries 2. Make sure the 'select a library' option is set to 'Standard rules for all libraries" 3. Click the 'Clone' button and notice that the cloning takes place without any warning that it will overwrite the rules of the destination branch 4. Apply patch 5. Return to the circulation and fine rules page 6. Repeat step 2 7. Click the clone button and notice a alert box appears asking if you are sure you want to clone the standard rule to the destination branch. Note: The name of the destination branch is included in the alert. Also note that the user is informed of the consequences of performing the action, i.e. that it will overwrite the existing rules in the destination branch 8. Click 'Cancel' and notice that no cloning occurs 9. Click the clone button again and this time click 'OK' and notice that the cloning takes place 10. Return to the Circulation and fine rules page and set the 'Select a library' option to the name of an individual branch 11. Click the clone button and notice that the clone action takes place Sponsored-By: Catalyst IT Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68689&action=edit Bug 19029 - Followup - Implemented .format() to ease translation Sponosred by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68690&action=edit Bug 19029 - Followup: Make security question appear on clone operations from one library to another Message pops up for all instances of cloning now. Works as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org