[Bug 16062] New: Remove CSS and images related to old "approve" and "deny" button styles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 Bug ID: 16062 Summary: Remove CSS and images related to old "approve" and "deny" button styles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 16061 Bug 15785 - Use Font Awesome icons in confirmation dialogs - Has made some CSS and images obsolete: .dialog input.approve, td input.approve { background : #FFF url(../../img/approve.gif) no-repeat 4px center; padding : .4em .4em .4em 25px; } .dialog input.deny { background : #FFF url(../../img/deny.gif) no-repeat 4px center; padding : .4em .4em .4em 25px; } Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16061 [Bug 16061] Use Font Awesome icons in reports when filter returns no results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16064 [Bug 16064] Remove use of image to indicate approval in tags moderation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49098&action=edit Bug 16062 - Remove CSS and images related to old "approve" and "deny" button styles Now that confirmation dialogs have all been udpated to use Font Awesome icons, the old CSS for styling "approve" and "deny" buttons can be removed along with the associated images. To test, apply the patchs for Bugs 16061 and 16064 if necessary. - Search the templates for instances of the "approve" or "deny" class which don't have a Font Awesome icon associated with it. There should be none. - Confirm that there are no other references to the files "approve.gif" and "deny.gif" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49098|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 49128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49128&action=edit Bug 16062 - Remove CSS and images related to old "approve" and "deny" button styles Now that confirmation dialogs have all been udpated to use Font Awesome icons, the old CSS for styling "approve" and "deny" buttons can be removed along with the associated images. To test, apply the patchs for Bugs 16061 and 16064 if necessary. - Search the templates for instances of the "approve" or "deny" class which don't have a Font Awesome icon associated with it. There should be none. - Confirm that there are no other references to the files "approve.gif" and "deny.gif" Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about 1126 td input.approve { 1127 background-color : #FFC; 1128 } ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #3)
What about 1126 td input.approve { 1127 background-color : #FFC; 1128 } ?
I didn't notice that. That was made obsolete by the overhaul of the lists interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49128|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49251&action=edit Bug 16062 - Remove CSS and images related to old "approve" and "deny" button styles Now that confirmation dialogs have all been udpated to use Font Awesome icons, the old CSS for styling "approve" and "deny" buttons can be removed along with the associated images. To test, apply the patchs for Bugs 16061 and 16064 if necessary. - Search the templates for instances of the "approve" or "deny" class which don't have a Font Awesome icon associated with it. There should be none. - Confirm that there are no other references to the files "approve.gif" and "deny.gif" Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49252&action=edit Bug 16062 - (follow-up) Remove CSS and images related to old "approve" and "deny" button styles Remove another obsolete CSS rule for input.approve Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org