[Bug 16071] New: Use Font Awesome icons in authority record duplicate warning dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 Bug ID: 16071 Summary: Use Font Awesome icons in authority record duplicate warning dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/authorities.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org In the authority record editor, if a duplicate record is suspected a dialog is shown. This dialog should use Font Awesome icons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49133&action=edit Bug 16071 - Use Font Awesome icons in authority duplicate warning dialog In the authority editor, when a duplicate record is suspected a dialog is shown. This patch updates the template to show Font Awesome icons in this dialog. Also changed: Using <h3> instead of <h4> in dialog so that it is correctly styled. Adding "popup" class to duplicate record link to indicate that a new window will be opened. To test, apply the patch and go to Authorities -> New record. - Use Z39.50 to import a record which is already in your catalog. - Save the record. Confirm that the duplicate warning dialog is styled correctly. - Confirm that both the "Save as new" and "Edit existing" buttons work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 [Bug 16080] Remove unused images from the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49133|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 49230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49230&action=edit [SIGNED-OFF]Bug 16071: Use Font Awesome icons in authority duplicate warning dialog In the authority editor, when a duplicate record is suspected a dialog is shown. This patch updates the template to show Font Awesome icons in this dialog. Also changed: Using <h3> instead of <h4> in dialog so that it is correctly styled. Adding "popup" class to duplicate record link to indicate that a new window will be opened. To test, apply the patch and go to Authorities -> New record. - Use Z39.50 to import a record which is already in your catalog. - Save the record. Confirm that the duplicate warning dialog is styled correctly. - Confirm that both the "Save as new" and "Edit existing" buttons work correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49230|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49246&action=edit Bug 16071: Use Font Awesome icons in authority duplicate warning dialog In the authority editor, when a duplicate record is suspected a dialog is shown. This patch updates the template to show Font Awesome icons in this dialog. Also changed: Using <h3> instead of <h4> in dialog so that it is correctly styled. Adding "popup" class to duplicate record link to indicate that a new window will be opened. To test, apply the patch and go to Authorities -> New record. - Use Z39.50 to import a record which is already in your catalog. - Save the record. Confirm that the duplicate warning dialog is styled correctly. - Confirm that both the "Save as new" and "Edit existing" buttons work correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16071 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org