[Bug 28869] New: If authorized values for STACK (shelving control number) are > 127 things explode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Bug ID: 28869 Summary: If authorized values for STACK (shelving control number) are > 127 things explode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The A.V. category of STACK maps to items.stack. In the schema (for master) it claims items.stack but if I 'describe items' it tells me it is tinyint(1). Tinyint can be anything between -128 and 127. To recreate: -Add AV's for STACK that are greater than 127. -Edit an item and attempt to change the shelving control number to that value. -See an error -Add AV's less than 127 -Edit an item, things seem to work fine. Should items.stack be int? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- TYPO: In the schema (for master) it claims items.stack is the data type BIT but if I 'describe items' it tells me it is tinyint(1). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Lucas, I am not sure what the use case for this item field usually is. We can easily increase it, but what should we use instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass from comment #0)
The A.V. category of STACK maps to items.stack.
Somehow in our local production db I do have the AV STACK category (without any value under it) and no mappings to STACK in the frameworks! We do not use the field but it contains a small number of 127s. Should have hidden the field in the item editor ;)
Tinyint can be anything between -128 and 127.
MySQL defaults to signed. If we SHOULD alter it to UNSIGNED. We have 0 to 255. Which might be just a bit more useful in the library environment. See also below.
-Edit an item, things seem to work fine.
If you enter a value over 127, it is converted to 127. This is not really fine imo :) It is just silently adjusted/capped.
Should items.stack be int?
This actually is a harder question than it looks like. One aspect is that the item editor just silently ignores non-numeric input in this field. So a text field would be nice? But authorised_values.id is an INT. But "unfortunately", Koha does not save the id in the corresponding item field but the actual value which is varchar(80). (Using a TEXT variant here would have performance impacts.) In conclusion, for items.stack I would opt for varchar(80) too here. It does however trigger a few remarks having a wider scope (postponed to next comment). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The promised comment is still coming btw. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just some related questions here. Should we save authorised_values.id in connected fields? Perhaps theoretically, but it does not sound very practical at this point in our codebase. So NO. Should we adjust other item fields that are of integer type connected to AV where the same problem actually may occur? Move them all to varchar(80)? It feels a bit like overkill? These are: | stack | tinyint(1) | # on this report | notforloan | tinyint(1) | | damaged | tinyint(1) | | itemlost | tinyint(1) | | withdrawn | tinyint(1) | | restricted | tinyint(1) | IF doing so, we could look at default values. They are not completely consistent, since damaged and withdrawn default to 0. `restricted` tinyint(1) DEFAULT NULL COMMENT 'authorized value defining use restrictions for this item (MARC21 952$5)', `stack` tinyint(1) DEFAULT NULL, `ccode` varchar(80) DEFAULT NULL COMMENT 'authorized value for the collection code associated with this item (MARC21 952$8)', `location` varchar(80) DEFAULT NULL COMMENT 'authorized value for the shelving location for this item (MARC21 952$c)', I thought about warning for a wrong value in an item field of type integer/date BEFORE saving. Now we can just enter something in various fields, save, get no warning and come back later to discover that our data is lost. E.g. the example of 127 for a higher number. (Coming back as 127 with a warning in the editor.) Or just 0 for a string. But since this originates from AV. We should perhaps add a restriction THERE! Why not add an AV column that allows you to only enter tinyints instead of 80 char codes? If we solve it in AV, there will be no problem in items? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note that things only 'explode' in strict SQL mode probably. Otherwise they are just silently converted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #5)
Just some related questions here.
Should we save authorised_values.id in connected fields? Perhaps theoretically, but it does not sound very practical at this point in our codebase. So NO.
Agreed.
Should we adjust other item fields that are of integer type connected to AV where the same problem actually may occur? Move them all to varchar(80)? It feels a bit like overkill? These are: | stack | tinyint(1) | # on this report | notforloan | tinyint(1) | | damaged | tinyint(1) | | itemlost | tinyint(1) | | withdrawn | tinyint(1) | | restricted | tinyint(1) |
IF doing so, we could look at default values. They are not completely consistent, since damaged and withdrawn default to 0. `restricted` tinyint(1) DEFAULT NULL COMMENT 'authorized value defining use restrictions for this item (MARC21 952$5)', `stack` tinyint(1) DEFAULT NULL, `ccode` varchar(80) DEFAULT NULL COMMENT 'authorized value for the collection code associated with this item (MARC21 952$8)', `location` varchar(80) DEFAULT NULL COMMENT 'authorized value for the shelving location for this item (MARC21 952$c)',
Standardizing the default values would be nice, but I am very hesitant about changing the datatype on the listed fields to varchar. My doubts are about the handling in our code and in reports. I know that we make numerical comparisons on these fields, like notforloan negative and positive values are treated differently within the codebase. Restricted = 1 has a special meaning. I would leave the status as is and only change stack, as it doesn't seem to belong in the list (not a status).
I thought about warning for a wrong value in an item field of type integer/date BEFORE saving. Now we can just enter something in various fields, save, get no warning and come back later to discover that our data is lost. E.g. the example of 127 for a higher number. (Coming back as 127 with a warning in the editor.) Or just 0 for a string.
I have helped a lot of people "fix" this problem over time, so better handling in the GUI would be desirable. Maybe instead of fixing the item editor etc. we should fix the authorised values editor instead.
But since this originates from AV. We should perhaps add a restriction THERE! Why not add an AV column that allows you to only enter tinyints instead of 80 char codes? If we solve it in AV, there will be no problem in items?
Agreed :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959 [Bug 35959] Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35990 [Bug 35990] [OMNIBUS] Improvements for using tinyint authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|If authorized values for |Optionally restrict |STACK (shelving control |authorised values to |number) are > 127 things |tinyint |explode | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Renaming title from If authorized values for STACK (shelving control number) are > 127 things explode to Optionally restrict authorised values to tinyint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 161745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161745&action=edit Bug 28869: Database revision Test plan: Run updatedatabase.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 161746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161746&action=edit Bug 28869: DBIx schema changes for AuthorisedValueCategory Note: Also adds boolean flag in the custom part! Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 161747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161747&action=edit Bug 28869: Implement authorised_value_categories.is_integer_only Test plan: Add category with/without integer restriction. Test adding/editing values. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 161748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161748&action=edit Bug 28869: (follow-up) Add html restriction for tinyint Several item fields are signed tinyints, connected to authorised value categories like NOT_LOAN etc. They only accept -128 up to 127. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 161749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161749&action=edit Bug 28869: Unit tests Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- === Note for QA WARN Koha/Schema/Result/AuthorisedValueCategory.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 16, now: 18) => PLEASE IGNORE (from automated build) FAIL Koha/AuthorisedValue.pm FAIL valid Constant subroutine Koha::AuthorisedValue::NUM_PATTERN redefined Constant subroutine Koha::AuthorisedValue::NUM_PATTERN_JS redefined => PLEASE IGNORE (false failures for constants, related to module dependencies outside report scope). Note too that qa tools should say WARN here and not FAIL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- For suggesting further improvements and extending this development, please go to the omnibus on bug 35990. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161745|0 |1 is obsolete| | --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162412&action=edit Bug 28869: Database revision Test plan: Run updatedatabase.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161746|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162413&action=edit Bug 28869: DBIx schema changes for AuthorisedValueCategory Note: Also adds boolean flag in the custom part! Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161747|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162414&action=edit Bug 28869: Implement authorised_value_categories.is_integer_only Test plan: Add category with/without integer restriction. Test adding/editing values. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161748|0 |1 is obsolete| | --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162415&action=edit Bug 28869: (follow-up) Add html restriction for tinyint Several item fields are signed tinyints, connected to authorised value categories like NOT_LOAN etc. They only accept -128 up to 127. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161749|0 |1 is obsolete| | --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162416&action=edit Bug 28869: Unit tests Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Bug 28869 depends on bug 35959, which changed state. Bug 35959 Summary: Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959 What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35959 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959 [Bug 35959] Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162412|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 163996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163996&action=edit Bug 28869: Database revision Test plan: Run updatedatabase.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162413|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 163997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163997&action=edit Bug 28869: DBIx schema changes for AuthorisedValueCategory Note: Also adds boolean flag in the custom part! Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162414|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 163998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163998&action=edit Bug 28869: Implement authorised_value_categories.is_integer_only Test plan: Add category with/without integer restriction. Test adding/editing values. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162415|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 163999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163999&action=edit Bug 28869: (follow-up) Add html restriction for tinyint Several item fields are signed tinyints, connected to authorised value categories like NOT_LOAN etc. They only accept -128 up to 127. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162416|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 164000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164000&action=edit Bug 28869: Unit tests Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 164001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164001&action=edit Bug 28869: (follow-up) Switch to cud-edit_category for CSRF No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased and added CSRF follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163996|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166697&action=edit Bug 28869: Database revision Test plan: Run updatedatabase.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163997|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166698&action=edit Bug 28869: DBIx schema changes for AuthorisedValueCategory Note: Also adds boolean flag in the custom part! Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163998|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166699&action=edit Bug 28869: Implement authorised_value_categories.is_integer_only Test plan: Add category with/without integer restriction. Test adding/editing values. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163999|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166700&action=edit Bug 28869: (follow-up) Add html restriction for tinyint Several item fields are signed tinyints, connected to authorised value categories like NOT_LOAN etc. They only accept -128 up to 127. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164000|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166701&action=edit Bug 28869: Unit tests Test plan: Run t/db_dependent/AuthorisedValues.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164001|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166702&action=edit Bug 28869: (follow-up) Switch to cud-edit_category for CSRF No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can someone quickly check on these QA script failures for me please? FAIL Koha/AuthorisedValue.pm FAIL valid Constant subroutine Koha::AuthorisedValue::NUM_PATTERN redefined Constant subroutine Koha::AuthorisedValue::NUM_PATTERN_JS redefined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #35)
Can someone quickly check on these QA script failures for me please?
FAIL Koha/AuthorisedValue.pm FAIL valid Constant subroutine Koha::AuthorisedValue::NUM_PATTERN redefined Constant subroutine Koha::AuthorisedValue::NUM_PATTERN_JS redefined
Comment14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some notes: * Would it not have been enough to name it: is_integer? :) * The database update is missing the AFTER/BEFORE. I've added it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #37)
* Would it not have been enough to name it: is_integer? :) Good question. No strong opinion. Since we normally allow string values, the only comes from that perspective.
* The database update is missing the AFTER/BEFORE. I've added it. Thanks.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Something appears missing here, tests are exploding. Can you please double check my pushed DBIC change and anything missing for REST API maybe?
Error: Properties not allowed: is_integer_only.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166906&action=edit Bug 28869: (RM follow-up) Add missing field in api definition We missed adding the new field to the api definition for authorised_value_category. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #42)
Follow-up pushed.
Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- A "datatype" column would have been more flexible here IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #45 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |david@davidnind.com Resolution|--- |FIXED --- Comment #46 from David Nind <david@davidnind.com> --- Database change - no update required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/973 CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org