[Bug 35149] New: Add "do nothing" option to CircAutoPrintQuickSlip syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Bug ID: 35149 Summary: Add "do nothing" option to CircAutoPrintQuickSlip syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Unfortunately I have forgotten the details, but previously there was a way, perhaps by leaving CircAutoPrintQuickSlip empty, not to trigger an action when the checkouts form for a patron (at circ/circulation.pl?borrowernumber=xxxx) was submitting. Some recent change changed this behavior so that an action is always performed. This add a "do nothing" option to opt out of any action being taken. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- *submitted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 --- Comment #2 from David Gustafsson <glasklas@gmail.com> --- Created attachment 157800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157800&action=edit Bug 35149: Add Option to ignore submit of checkout field when empty 1) Apply patch 2) Set CircAutoPrintQuickSlip to "do nothing" 3) Go to the checkouts form for a specific patron 4) Submit the form with empty value 5) Verify that no action is taken and you stay on the current page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Good idea. The CircAutoPrintQuickSlip sys pref is a 'choice' so I think we need a DB update and change to sysprefs.sql to reflect each choice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 --- Comment #4 from David Gustafsson <glasklas@gmail.com> --- Created attachment 162323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162323&action=edit Bug 35149: Change CircAutoPrintQuickSlip syspref explanation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from David Gustafsson <glasklas@gmail.com> --- Thanks for the feedback, this should now be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157800|0 |1 is obsolete| | --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163639&action=edit Bug 35149: Add Option to ignore submit of checkout field when empty 1) Apply patch 2) Set CircAutoPrintQuickSlip to "do nothing" 3) Go to the checkouts form for a specific patron 4) Submit the form with empty value 5) Verify that no action is taken and you stay on the current page Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162323|0 |1 is obsolete| | --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163640&action=edit Bug 35149: Change CircAutoPrintQuickSlip syspref explanation Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163639|0 |1 is obsolete| | Attachment #163640|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166582&action=edit Bug 35149: Change CircAutoPrintQuickSlip syspref explanation Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Summary|Add "do nothing" option to |Add "do nothing" option to |CircAutoPrintQuickSlip |CircAutoPrintQuickSlip |syspref |system preference --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I remember this option as well, also: didn't we have "close patron account" as an option as well? (or do I just remember that from testing something else?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #9)
I remember this option as well, also: didn't we have "close patron account" as an option as well? (or do I just remember that from testing something else?)
Is that different than "Clear the screen"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kyle M Hall from comment #10)
(In reply to Katrin Fischer from comment #9)
I remember this option as well, also: didn't we have "close patron account" as an option as well? (or do I just remember that from testing something else?)
Is that different than "Clear the screen"?
No, you are correct. that makes sense! I was mostly justifying switching this to be a bug fix :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163639|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Isn't installer/data/mysql/mandatory/sysprefs.sql missing choices of syspref CircAutoPrintQuickSlip ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #14)
Isn't installer/data/mysql/mandatory/sysprefs.sql missing choices of syspref CircAutoPrintQuickSlip ?
I stumbled on this before, but it's been missing them before. Since we switched to YAML they are not actually used... so I didn't force the fix here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah OK so legacy crap, no problem ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- This seems like an enhancement and I won't backport it for 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35149 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/971 Resolution|--- |FIXED Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org