[Bug 18928] New: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Bug ID: 18928 Summary: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Depends on: 18925 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18925 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18925 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18930 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 [Bug 18930] Move lost item refund rules to circulation_rules table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65241&action=edit Bug 18928 - Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65242&action=edit Bug 18928 - Remove schema files for deleted tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65241|0 |1 is obsolete| | --- Comment #3 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71005&action=edit Bug 18928 - Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65242|0 |1 is obsolete| | --- Comment #4 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71006&action=edit Bug 18928 - Remove schema files for deleted tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71005|0 |1 is obsolete| | Attachment #71006|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81096&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81097&action=edit Bug 18928: Add DB structure changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81098&action=edit Bug 18928: Update schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81099&action=edit Bug 18928: Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81096|0 |1 is obsolete| | Attachment #81097|0 |1 is obsolete| | Attachment #81098|0 |1 is obsolete| | Attachment #81099|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82933&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82934&action=edit Bug 18928: Add DB structure changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82935&action=edit Bug 18928: Update schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 82936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82936&action=edit Bug 18928: Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82933|0 |1 is obsolete| | Attachment #82934|0 |1 is obsolete| | Attachment #82935|0 |1 is obsolete| | Attachment #82936|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85487&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85488&action=edit Bug 18928: Add DB structure changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85489&action=edit Bug 18928: Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85490&action=edit Bug 18928: Update schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85491&action=edit Bug 18928: Update new occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85490|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85491|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85487|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86134&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86135&action=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86136&action=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86137&action=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86138&action=edit [DO NOT PUSH] Bug 18928: DBIC schema update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86139&action=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've: - Tried setting global and branch-specific rules - Upgrade migrated the rules correctly - Tests pass - QA scripts happy Good job! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Bug 18928 depends on bug 18925, which changed state. Bug 18925 Summary: Move maxissueqty and maxonsiteissueqty to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 86134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86134 Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Review of attachment 86134: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18928&attachment=86134) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +1706,5 @@
+ + # Search for rules! + foreach my $rule_name (qw( holdallowed hold_fulfillment_policy returnbranch )) { + foreach my $params (@params) { + my $rule = Koha::CirculationRules->search(
Why do you use ->search instead of get_effective_rule? ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ +720,4 @@
<th>Return policy</th> <th> </th> </tr> + [% FOREACH i IN itemtypeloop %]
There is something strange in displaying hold policy for itemtypes. When I have set values in Default checkout, hold and return policy section, i see all item types listed with the same value as set in Default section, even if i set some itemtypes differently... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #26 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 88659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88659&action=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default checkout, hold and return policy section on circulation rules admin page, try for all libraries and for one specific library. Save. 2) Click on unset and confitm --> without patch, the Maximum total holds allowed value remains --> with patch the unset removex Maximum holds value too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86134|0 |1 is obsolete| | Attachment #86135|0 |1 is obsolete| | Attachment #86136|0 |1 is obsolete| | Attachment #86137|0 |1 is obsolete| | Attachment #86138|0 |1 is obsolete| | Attachment #86139|0 |1 is obsolete| | Attachment #88659|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89017&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89018&action=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89019&action=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89020&action=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89021&action=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89022&action=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default checkout, hold and return policy section on circulation rules admin page, try for all libraries and for one specific library. Save. 2) Click on unset and confitm --> without patch, the Maximum total holds allowed value remains --> with patch the unset removex Maximum holds value too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89023&action=edit [DO NOT PUSH] Bug 18928: DBIC schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89024&action=edit Bug 18928: Use get_effective_rule in GetBranchItemRule -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #25)
Comment on attachment 86134 [details] [review] Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules
Review of attachment 86134 [details] [review]: -----------------------------------------------------------------
::: C4/Circulation.pm @@ +1706,5 @@
+ + # Search for rules! + foreach my $rule_name (qw( holdallowed hold_fulfillment_policy returnbranch )) { + foreach my $params (@params) { + my $rule = Koha::CirculationRules->search(
Why do you use ->search instead of get_effective_rule?
Yes you are are right, it seems to make sense to use get_effective_rule. Done in a follow-up.
::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ +720,4 @@
<th>Return policy</th> <th> </th> </tr> + [% FOREACH i IN itemtypeloop %]
There is something strange in displaying hold policy for itemtypes. When I have set values in Default checkout, hold and return policy section, i see all item types listed with the same value as set in Default section, even if i set some itemtypes differently...
I cannot recreate that, can you share screenshots? I have attached a rebased version of these patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Needs Signoff |Failed QA --- Comment #36 from Liz Rea <wizzyrea@gmail.com> --- Hi, There is something odd here - the Defaults row seems to always say (not set) even if the rules are propagated? Deleting the All-All rule from the main table seems to clear the default checkout, hold, and return policy values? Is that expected? You can re-set the checkout hold and return policy rules without having an All-All rule, but deleting it seems to delete both? Probably not going to go on testing the actual function until I get an answer on these things, sorry. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89333&action=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We actually want to remove maxissueqty and maxonsiteissueqty (for now) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22679 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Liz Rea from comment #36)
Hi,
Hi Liz, thanks a lot for testing!
There is something odd here - the Defaults row seems to always say (not set) even if the rules are propagated?
That's definitely wrong, and is happening before this patch. I am going to investigate and open a new bug report.
Deleting the All-All rule from the main table seems to clear the default checkout, hold, and return policy values? Is that expected? You can re-set the checkout hold and return policy rules without having an All-All rule, but deleting it seems to delete both?
Good catch, caused by bug 22679, following up here as it should not have side-effects in master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89333|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89334&action=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We actually want to remove maxissueqty, maxonsiteissueqty and max_holds (for now) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #38)
(In reply to Liz Rea from comment #36)
There is something odd here - the Defaults row seems to always say (not set) even if the rules are propagated?
That's definitely wrong, and is happening before this patch. I am going to investigate and open a new bug report.
See bug 22847. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89336&action=edit Bug 18928: (bug 22847 follow-up) Display correctly the values (not the propagated ones) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- And I think we are good now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #43 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89338&action=edit Bug 18928: Add Branches.HasCirculationRules and set branchcode in CirculationRules.Search This patch tackles two issues: 1) Defaults row always says (not set) because "default_rules" param was deleted from smart-rules.pl. 2) When setting standard hold rules for all libraries, hold policy, pickup and return always says 'Not Set' even if you defined values. This is because "current_branch" variable was used in CirculationRules.Search, and current_branch value for default is "*". Solutions: 1) Add Koha::Template::Plugin::Branches->HasCirculationRules method that returns 1 if defined branch has circulation rules. 2) Switch "current_branch" for "branchcode" whose value is undef for default rules. To test: 1) Apply previous patches 2) set default values for all libraries CHECK => hold policy, pickup and return remains in 'Not set' 3) select a library 4) set values for that library CHECK => first column always says "Defaults (not set)" 5) Apply this patch SUCCESS => Hold, pickup and return default values for all libraries are now shown => First column of default rules, and of the library selected in step 3 only says "Defaults" 6) Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89024|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89338|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89018|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89019|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89020|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89022|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89023|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #44 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89339&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #45 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89340&action=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #46 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89341&action=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #47 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89342&action=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #48 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89343&action=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #49 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89344&action=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default checkout, hold and return policy section on circulation rules admin page, try for all libraries and for one specific library. Save. 2) Click on unset and confitm --> without patch, the Maximum total holds allowed value remains --> with patch the unset removex Maximum holds value too Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #50 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89345&action=edit Bug 18928: DBIC schema update Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #51 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89346&action=edit Bug 18928: Use get_effective_rule in GetBranchItemRule Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #52 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89347&action=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We actually want to remove maxissueqty, maxonsiteissueqty and max_holds (for now) Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #53 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89348&action=edit Bug 18928: (bug 22847 follow-up) Display correctly the values (not the propagated ones) Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #54 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89349&action=edit Bug 18928: Add Branches.HasCirculationRules and set branchcode in CirculationRules.Search This patch tackles two issues: 1) Defaults row always says (not set) because "default_rules" param was deleted from smart-rules.pl. 2) When setting standard hold rules for all libraries, hold policy, pickup and return always says 'Not Set' even if you defined values. This is because "current_branch" variable was used in CirculationRules.Search, and current_branch value for default is "*". Solutions: 1) Add Koha::Template::Plugin::Branches->HasCirculationRules method that returns 1 if defined branch has circulation rules. 2) Switch "current_branch" for "branchcode" whose value is undef for default rules. To test: 1) Apply previous patches 2) set default values for all libraries CHECK => hold policy, pickup and return remains in 'Not set' 3) select a library 4) set values for that library CHECK => first column always says "Defaults (not set)" 5) Apply this patch SUCCESS => Hold, pickup and return default values for all libraries are now shown => First column of default rules, and of the library selected in step 3 only says "Defaults" 6) Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Agustín Moyano from comment #54)
Created attachment 89349 [details] [review]
Hola Agustín, are you sure this patch is still needed after the 2 follow-ups I attached yesterday? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #56 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #55)
(In reply to Agustín Moyano from comment #54)
Created attachment 89349 [details] [review] [review]
Hola Agustín, are you sure this patch is still needed after the 2 follow-ups I attached yesterday?
Hello Jonathan, yesterday night I tested it with the parches, and found those tiny errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #57 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Agustín Moyano from comment #56)
(In reply to Jonathan Druart from comment #55)
(In reply to Agustín Moyano from comment #54)
Created attachment 89349 [details] [review] [review] [review]
Hola Agustín, are you sure this patch is still needed after the 2 follow-ups I attached yesterday?
Hello Jonathan, yesterday night I tested it with the parches, and found those tiny errors.
s/parches/patches/g Sorry.. my mobile spanish corrector :p -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Agustin, ok I think I am lost then :) I opened bug 22847 to deal with this behavior, and I thought it was a bug. I am not sure what we expect actually. I am going to mark this one as blocked by 22847 and see how thing goes. About your patch: * HasCirculationRules - I would have set the flag from the .pl, not the TT plugin. * current_branch vs branchcode - my patch was supposed to deal with that. We will be back to this one later :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #58)
I opened bug 22847 to deal with this behavior, and I thought it was a bug. I am not sure what we expect actually. I am going to mark this one as blocked by 22847 and see how thing goes.
And I have tested on 17.11.x: nothing is displayed if the rule is not defined at library level, so I think bug 22847 is valid and must be fixed asap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So, if we agree that bug 22847 is valid, last patch must be obsoleted. However the "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89349|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89377&action=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #62 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #61)
Created attachment 89377 [details] [review] Bug 18928: Remove '(not set)'
The "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem.
Now that bug 22847 is a dependency of this bug, should't attachment 89348 be obsoleted? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89377|0 |1 is obsolete| | --- Comment #63 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 89402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89402&action=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89339|0 |1 is obsolete| | Attachment #89340|0 |1 is obsolete| | Attachment #89341|0 |1 is obsolete| | Attachment #89342|0 |1 is obsolete| | Attachment #89343|0 |1 is obsolete| | Attachment #89344|0 |1 is obsolete| | Attachment #89345|0 |1 is obsolete| | Attachment #89346|0 |1 is obsolete| | Attachment #89347|0 |1 is obsolete| | Attachment #89348|0 |1 is obsolete| | Attachment #89402|0 |1 is obsolete| | --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89427&action=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89427|0 |1 is obsolete| | --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89428&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #66 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89429&action=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89430&action=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #68 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89431&action=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89432&action=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #70 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89433&action=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default checkout, hold and return policy section on circulation rules admin page, try for all libraries and for one specific library. Save. 2) Click on unset and confitm --> without patch, the Maximum total holds allowed value remains --> with patch the unset removex Maximum holds value too Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89434&action=edit Bug 18928: DBIC schema update Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89435&action=edit Bug 18928: Use get_effective_rule in GetBranchItemRule Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89436&action=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We actually want to remove maxissueqty, maxonsiteissueqty and max_holds (for now) Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89437&action=edit Bug 18928: (bug 22847 follow-up) Display correctly the values (not the propagated ones) Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 89438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89438&action=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89428|0 |1 is obsolete| | Attachment #89429|0 |1 is obsolete| | Attachment #89430|0 |1 is obsolete| | Attachment #89431|0 |1 is obsolete| | Attachment #89432|0 |1 is obsolete| | Attachment #89433|0 |1 is obsolete| | Attachment #89434|0 |1 is obsolete| | Attachment #89435|0 |1 is obsolete| | Attachment #89436|0 |1 is obsolete| | Attachment #89437|0 |1 is obsolete| | Attachment #89438|0 |1 is obsolete| | --- Comment #76 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89440&action=edit Bug 22847: Correctly displayed circ rule values for max_holds and maxissue* There are several things going wrong on the circulation rules screen. The global rule is displayed for specific libraries (even if the rule does not exist for the library), and max_holds is always blank. I have trouble finding the root of the issue, but I will propose a patch to fix both problem. Certainly a mismatch between bug 18887 and bug 18925. Test plan: 0. Do not apply the patch 1. Notice the issue on the circulation rules screen 2. Apply the patch 3. Confirm that the value you set are correctly displayed (and not the propagated ones!) Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89440|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #77 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89441&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #78 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89442&action=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #79 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89443&action=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #80 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89444&action=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #81 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89445&action=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #82 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89446&action=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default checkout, hold and return policy section on circulation rules admin page, try for all libraries and for one specific library. Save. 2) Click on unset and confitm --> without patch, the Maximum total holds allowed value remains --> with patch the unset removex Maximum holds value too Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #83 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89447&action=edit Bug 18928: DBIC schema update Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #84 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89448&action=edit Bug 18928: Use get_effective_rule in GetBranchItemRule Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #85 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89449&action=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We actually want to remove maxissueqty, maxonsiteissueqty and max_holds (for now) Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #86 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89450&action=edit Bug 18928: (bug 22847 follow-up) Display correctly the values (not the propagated ones) Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #87 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 89451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89451&action=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #88 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I a big patch set I am not very brave - can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89441|0 |1 is obsolete| | Attachment #89442|0 |1 is obsolete| | Attachment #89443|0 |1 is obsolete| | Attachment #89444|0 |1 is obsolete| | Attachment #89445|0 |1 is obsolete| | Attachment #89446|0 |1 is obsolete| | Attachment #89447|0 |1 is obsolete| | Attachment #89448|0 |1 is obsolete| | Attachment #89449|0 |1 is obsolete| | Attachment #89450|0 |1 is obsolete| | Attachment #89451|0 |1 is obsolete| | --- Comment #89 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89628&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #90 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89629&action=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #91 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89630&action=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #92 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89631&action=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #93 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89632&action=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #94 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89633&action=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default checkout, hold and return policy section on circulation rules admin page, try for all libraries and for one specific library. Save. 2) Click on unset and confitm --> without patch, the Maximum total holds allowed value remains --> with patch the unset removex Maximum holds value too Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #95 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89634&action=edit Bug 18928: DBIC schema update Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #96 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89635&action=edit Bug 18928: Use get_effective_rule in GetBranchItemRule Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #97 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89636&action=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We actually want to remove maxissueqty, maxonsiteissueqty and max_holds (for now) Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #98 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89637&action=edit Bug 18928: (bug 22847 follow-up) Display correctly the values (not the propagated ones) Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #99 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 89638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89638&action=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #100 from Nick Clemens <nick@bywatersolutions.com> --- Some feedback: t/db_dependent/TestBuilder.t - occurrence of default_circ_rules Set rule: All-libraries Default holds policy by item type Computer files -> From home library -> Item's home libary -> Item floats Go to a specific branch 'Fairview' - the above rule shows Setting a branch specific does override and then show correctly Set rule: Checkout, hold policy by patron category for Fairview Teacher -> blank -> blank -> 0 rule does not show as set, check the DB, it is set correctly It does prevent teacher from placing holds set to: Teacher -> blank -> blank -> 1 It shows and is set correctly Otherwise testing worked, code functions as I believe it is supposed to, overriding and choosing correct rule. We should move this one early this cycle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #101 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #100)
Some feedback: t/db_dependent/TestBuilder.t - occurrence of default_circ_rules
Sure? I do not have it :)
Set rule: All-libraries Default holds policy by item type Computer files -> From home library -> Item's home libary -> Item floats
Go to a specific branch 'Fairview' - the above rule shows Setting a branch specific does override and then show correctly
Yes, that's the error we have since the beginning, patch's coming. Thanks!
Set rule: Checkout, hold policy by patron category for Fairview Teacher -> blank -> blank -> 0 rule does not show as set, check the DB, it is set correctly It does prevent teacher from placing holds set to: Teacher -> blank -> blank -> 1 It shows and is set correctly
Otherwise testing worked, code functions as I believe it is supposed to, overriding and choosing correct rule. We should move this one early this cycle
I'd say it's a master bug, I am investigating it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #102 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90501&action=edit Bug 18928: (bug 22847 follow-up 2) Display correctly the values (not the propagated ones) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23095 --- Comment #103 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #101)
Set rule: Checkout, hold policy by patron category for Fairview Teacher -> blank -> blank -> 0 rule does not show as set, check the DB, it is set correctly It does prevent teacher from placing holds set to: Teacher -> blank -> blank -> 1 It shows and is set correctly
Otherwise testing worked, code functions as I believe it is supposed to, overriding and choosing correct rule. We should move this one early this cycle
I'd say it's a master bug, I am investigating it.
See bug 23095. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Bug 18928 depends on bug 18925, which changed state. Bug 18925 Summary: Move maxissueqty and maxonsiteissueqty to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Bug 18928 depends on bug 18925, which changed state. Bug 18925 Summary: Move maxissueqty and maxonsiteissueqty to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89628|0 |1 is obsolete| | --- Comment #104 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91082&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89629|0 |1 is obsolete| | --- Comment #105 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91083&action=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89630|0 |1 is obsolete| | --- Comment #106 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91084&action=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89631|0 |1 is obsolete| | --- Comment #107 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91085&action=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89632|0 |1 is obsolete| | --- Comment #108 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91086&action=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89633|0 |1 is obsolete| | --- Comment #109 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91087&action=edit Bug 18928: (follow-up) Unset max_holds rule if needed Test plan: 1) Set all values in Default checkout, hold and return policy section on circulation rules admin page, try for all libraries and for one specific library. Save. 2) Click on unset and confitm --> without patch, the Maximum total holds allowed value remains --> with patch the unset removex Maximum holds value too Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89634|0 |1 is obsolete| | --- Comment #110 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91088&action=edit Bug 18928: DBIC schema update Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89635|0 |1 is obsolete| | --- Comment #111 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91089&action=edit Bug 18928: Use get_effective_rule in GetBranchItemRule Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89636|0 |1 is obsolete| | --- Comment #112 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91090&action=edit Bug 18928: (bug 22679 follow-up) Do not remove all rules along with the issuing rule We actually want to remove maxissueqty, maxonsiteissueqty and max_holds (for now) Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89637|0 |1 is obsolete| | --- Comment #113 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91091&action=edit Bug 18928: (bug 22847 follow-up) Display correctly the values (not the propagated ones) Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89638|0 |1 is obsolete| | --- Comment #114 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91092&action=edit Bug 18928: Remove '(not set)' The "(not set)" part must be removed IMO, I am not sure I understand its goal. Now that we have 1 entry per rule (and not 1 DB row for the whole "Default checkout, hold and return policy for Centerville" table), it will be harder to handle it correctly. Not impossible, but if not really needed I would prefer to just remove it. If a rule is not set, the cell is empty or the dropdown list displays the option "Not set", which seems to correct the problem. Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90501|0 |1 is obsolete| | --- Comment #115 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91093&action=edit Bug 18928: (bug 22847 follow-up 2) Display correctly the values (not the propagated ones) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #116 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91094&action=edit Bug 18928: (QA follow-up) Remove DBIC files and reference to DefaultCircRule Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #118 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Text to go in the| |Reports Note: This changes release notes| |the database schema, | |reports referencing the | |`holdallowed`, | |`hold_fulfillment_policy` | |or `returnbranch` fields | |from the `` table will need | |to be updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Reports Note: This changes |Reports Note: This changes release notes|the database schema, |the database schema, |reports referencing the |reports referencing the |`holdallowed`, |`default_branch_circ_rules` |`hold_fulfillment_policy` |, `hold_fulfillment_policy` |or `returnbranch` fields |or `returnbranch` tables |from the `` table will need |will need to be updated |to be updated | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Reports Note: This changes |Reports Note: This changes release notes|the database schema, |the database schema, |reports referencing the |reports referencing the |`default_branch_circ_rules` |`default_branch_circ_rules` |, `hold_fulfillment_policy` |, `default_circ_rules` or |or `returnbranch` tables |`` tables will need to be |will need to be updated |updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Reports Note: This changes |Reports Note: This changes release notes|the database schema, |the database schema, |reports referencing the |reports referencing the |`default_branch_circ_rules` |`default_branch_circ_rules` |, `default_circ_rules` or |, `default_circ_rules`, |`` tables will need to be |`default_branch_item_rules` |updated |or `branch_item_rules` | |tables will need to be | |updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move holdallowed, |Move `holdallowed`, |hold_fulfillment_policy, |`hold_fulfillment_policy` |returnbranch to |and `returnbranch` into |circulation_rules |`circulation_rules` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move `holdallowed`, |Move `holdallowed`, |`hold_fulfillment_policy` |`hold_fulfillment_policy` |and `returnbranch` into |and `returnbranch` into the |`circulation_rules` |`circulation_rules` table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Reports Note: This changes |**Reports Note**: This release notes|the database schema, |changes the database |reports referencing the |schema, reports referencing |`default_branch_circ_rules` |the |, `default_circ_rules`, |`default_branch_circ_rules` |`default_branch_item_rules` |, `default_circ_rules`, |or `branch_item_rules` |`default_branch_item_rules` |tables will need to be |or `branch_item_rules` |updated |tables will need to be | |updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Reports Note**: This |**Reports note**: This release notes|changes the database |changes the database |schema, reports referencing |schema, reports referencing |the |the |`default_branch_circ_rules` |`default_branch_circ_rules` |, `default_circ_rules`, |, `default_circ_rules`, |`default_branch_item_rules` |`default_branch_item_rules` |or `branch_item_rules` |or `branch_item_rules` |tables will need to be |tables will need to be |updated |updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25601 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25601 [Bug 25601] Error when unsetting default checkout, hold and return policy for a specific library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851 [Bug 25851] 19.11 upgrade creates holdallowed rule with empty value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8369 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18925 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org