[Bug 18887] New: Introduce new table 'circulation_rules', use for ' max_holds' rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Bug ID: 18887 Summary: Introduce new table 'circulation_rules', use for 'max_holds' rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Blocks: 18886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886 [Bug 18886] Restructure storage of circulation rules to reduce complexity and enable increased flexiblity -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 [Bug 15524] Set limit on maximum possible holds per patron by category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18925 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65233&action=edit Bug 18887 - Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65234&action=edit Bug 18887 - Add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65235&action=edit Bug 18887 - Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65236&action=edit Bug 18887 - Add Koha::CirculationRule(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65237&action=edit Bug 18887 - Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #6 from Jesse Weaver <pianohacker@gmail.com> --- Comment on attachment 65233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65233 Bug 18887 - Update database Review of attachment 65233: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18887&attachment=65233) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_18887.perl @@ +24,5 @@
+ }); + + $dbh->do(q{ + INSERT INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) + SELECT NULL, categorycode, NULL, 'max_holds', max_holds FROM branch_borrower_circ_rules
Shouldn't this SELECT be pulling from `default_borrower_circ_rules`? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <pianohacker@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pianohacker@gmail.com --- Comment #7 from Jesse Weaver <pianohacker@gmail.com> --- Comment on attachment 65236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65236 Bug 18887 - Add Koha::CirculationRule(s) I'm a bit confused as to the intended API; the new code in Reserves.pm uses CirculationRules->find, the template plugin uses CirculationRules->search, and there's an unused(?) method called get_effective_rule that seems like it implements the inheritance logic correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec@gmail.com --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- FAIL Koha/CirculationRules.pm FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 139) FAIL pod coverage POD is missing for 'object_class' Setting the max_holds rule for some library is ok and getting used when placing hold. But when I try to set default rule for all libraries, the rule is saved to the database (with branchcode = NULL), but is not shown on the circulation rules page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #9 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 67620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67620&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alexbuckley@catalyst.net.nz --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Kyle Can you please rebase against master because when trying to apply the patches up to and including the 'port max_holds_rules to new CirculationRules systems' (after applying the dependency: patch 15524) I got the below merge error. The issue is in Koha/Schema/Result/Branch.pm file. Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 18887 - Update database Applying: Bug 18887 - Add new schema file Applying: Bug 18887 - Update existing schema files Using index info to reconstruct a base tree... M Koha/Schema/Result/Branch.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Branch.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm Failed to merge in the changes. Patch failed at 0001 Bug 18887 - Update existing schema files The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18887---Update-existing-schema-files-74PCpN.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65233|0 |1 is obsolete| | --- Comment #11 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 70986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70986&action=edit Bug 18887 - Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65234|0 |1 is obsolete| | --- Comment #12 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 70987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70987&action=edit Bug 18887 - Add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65235|0 |1 is obsolete| | --- Comment #13 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 70988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70988&action=edit Bug 18887 - Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65236|0 |1 is obsolete| | --- Comment #14 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 70989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70989&action=edit Bug 18887 - Add Koha::CirculationRule(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65237|0 |1 is obsolete| | --- Comment #15 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 70990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70990&action=edit Bug 18887 - Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67620|0 |1 is obsolete| | --- Comment #16 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 70991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70991&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <pianohacker@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #17 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71031&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71031|0 |1 is obsolete| | --- Comment #18 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 71042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71042&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70986|0 |1 is obsolete| | --- Comment #19 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72218&action=edit Bug 18887 - Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70987|0 |1 is obsolete| | --- Comment #20 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72219&action=edit Bug 18887 - Add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70988|0 |1 is obsolete| | --- Comment #21 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72220&action=edit Bug 18887 - Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70989|0 |1 is obsolete| | --- Comment #22 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72221&action=edit Bug 18887 - Add Koha::CirculationRule(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70990|0 |1 is obsolete| | --- Comment #23 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72222&action=edit Bug 18887 - Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70991|0 |1 is obsolete| | --- Comment #24 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72223&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71042|0 |1 is obsolete| | --- Comment #25 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 72224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72224&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lucie Gay <lucie.gay@ens-paris-saclay.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucie.gay@ens-paris-saclay. | |fr --- Comment #26 from Lucie Gay <lucie.gay@ens-paris-saclay.fr> --- DBD::mysql::db do failed: Unknown column 'max_holds' in 'field list' [for Statement " INSERT INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) SELECT branchcode, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' ) FROM branch_borrower_circ_rules "] at (eval 1179) line 21. DBD::mysql::db do failed: Unknown column 'max_holds' in 'field list' [for Statement " INSERT INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) SELECT NULL, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' ) FROM default_borrower_circ_rules "] at (eval 1179) line 26. DBD::mysql::db do failed: Can't DROP 'max_holds'; check that column/key exists [for Statement " ALTER TABLE branch_borrower_circ_rules DROP COLUMN max_holds "] at (eval 1179) line 31. Upgrade to XXX done (Bug 18887 - Introduce new table 'circulation_rules', use for 'max_holds' rules) DBD::mysql::db do failed: Can't DROP 'max_holds'; check that column/key exists [for Statement " ALTER TABLE default_borrower_circ_rules DROP COLUMN max_holds "] at (eval 1179) line 35. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lucie Gay <lucie.gay@ens-paris-saclay.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Lucie Gay <lucie.gay@ens-paris-saclay.fr> --- Tested on Unimarc sandbox. Patch applied but there are error messages : ----- The sandbox you've requested is now ready. The patches attached to bugzilla 18887 have been applied, and the result is: Updatedatabase: Upgrade to 17.12.00.000 done (Tē tōia, tē haumatia) Upgrade to 17.12.00.001 done (Bug 19724 - Add [deleted]biblio_metadata.timestamp) Upgrade to 17.12.00.002 done (Bug 19096 - Make Default authoritative for Koha to MARC mappings) Upgrade to 17.12.00.003 done (Bug 10021 - Drop notifys-related table and columns) Upgrade to 17.12.00.004 done (Bug 19278 - Add a configurable default page size for REST endpoints) Upgrade to 17.12.00.005 done (Bug 18915 - Correct CHECKOUT_NOTE notice template) Upgrade to 17.12.00.006 done (Bug 17682 - Update URL for Google Scholar in OPACSearchForTitleIn) Upgrade to 17.12.00.007 done (Bug 15707 - Add new table library_groups) Upgrade to 17.12.00.008 done (Bug 16735 - Migrate library search groups into the new hierarchical groups) Upgrade to 17.12.00.009 done (Bug 18403 - Add the view_borrower_infos_from_any_libraries permission ) Upgrade to 17.12.00.010 done (Bug 20133 - Add library_groups.ft_hide_patron_info) Upgrade to 17.12.00.011 done (Bug 20157 - Use group 'features' to decide which groups to use for group searching functionality) Upgrade to 17.12.00.012 done (Bug 15752 - Add system preference AutoSwitchPatron) Upgrade to 17.12.00.013 done (Bug 20175 - Set DEFAULT NULL value for club_enrollments.date_created) Upgrade to 17.12.00.014 done (Bug 19790 - Remove additionalauthors.author from installer files) Upgrade to 17.12.00.015 done (Bug 20144 - Adapt DB structure to work with new SQL modes) Upgrade to 17.12.00.016 done (Bug 18336 - Convert DB tables to utf8mb4 ��) Upgrade to 17.12.00.017 done (Bug 17672 - Add damaged_on to items and deleteditems tables) Upgrade to 17.12.00.018 done (Bug 19290 - Add system preference BrowseResultSelection) Upgrade to 17.12.00.019 done (Bug 20074 - Auth_subfield_structure changes hidden attribute) Upgrade to 17.12.00.020 done (Bug 20082 - Update descriptions of Vietnamese language) Upgrade to 17.12.00.021 done (Bug 13287 - Add system preference PurgeSuggestionsOlderThan) DEV atomic update: bug_18887.perl DBD::mysql::db do failed: Unknown column 'max_holds' in 'field list' [for Statement " INSERT INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) SELECT branchcode, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' ) FROM branch_borrower_circ_rules "] at (eval 1179) line 21. DBD::mysql::db do failed: Unknown column 'max_holds' in 'field list' [for Statement " INSERT INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value ) SELECT NULL, categorycode, NULL, 'max_holds', COALESCE( max_holds, '' ) FROM default_borrower_circ_rules "] at (eval 1179) line 26. DBD::mysql::db do failed: Can't DROP 'max_holds'; check that column/key exists [for Statement " ALTER TABLE branch_borrower_circ_rules DROP COLUMN max_holds "] at (eval 1179) line 31. DBD::mysql::db do failed: Can't DROP 'max_holds'; check that column/key exists [for Statement " ALTER TABLE default_borrower_circ_rules DROP COLUMN max_holds "] at (eval 1179) line 35. Upgrade to XXX done (Bug 18887 - Introduce new table 'circulation_rules', use for 'max_holds' rules) ------ Staff interface works, but when I go in admin > Circulation and fines rules (cgi-bin/koha/admin/smart-rules.pl), there are error messages : Global symbol "$max_holds" requires explicit package name (did you forget to declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 283. Global symbol "$max_holds" requires explicit package name (did you forget to declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 284. Global symbol "$max_holds" requires explicit package name (did you forget to declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 284. Global symbol "$max_holds" requires explicit package name (did you forget to declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 315. Global symbol "$max_holds" requires explicit package name (did you forget to declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 347. Global symbol "$max_holds" requires explicit package name (did you forget to declare "my $max_holds"?) at /home/koha/src/admin/smart-rules.pl line 405. Execution of /home/koha/src/admin/smart-rules.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72218|0 |1 is obsolete| | Attachment #72219|0 |1 is obsolete| | Attachment #72220|0 |1 is obsolete| | Attachment #72221|0 |1 is obsolete| | Attachment #72222|0 |1 is obsolete| | Attachment #72223|0 |1 is obsolete| | Attachment #72224|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77080&action=edit Bug 18887 - Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77081&action=edit Bug 18887 - Add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77082&action=edit Bug 18887 - Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77083&action=edit Bug 18887 - Add Koha::CirculationRule(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77084&action=edit Bug 18887 - Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77085&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77086&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 77087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77087&action=edit Bug 18887: Fix issues caused by rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note for QA (does not block signoff): * update DB entry is not idempotent * Last of tests and POD for the new module * merge markers in first patch * This change is odd and need more attention - $max_holds = undef if $max_holds !~ /^\d+/; + $max_holds = '' if $max_holds !~ /^\d+/; Especially because it is different than others. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also * The table circulation_rules does not have the current charset collate (see bug 18336) * Copyright lines come from Koha/IssuingRules.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77080|0 |1 is obsolete| | Attachment #77081|0 |1 is obsolete| | Attachment #77082|0 |1 is obsolete| | Attachment #77083|0 |1 is obsolete| | Attachment #77084|0 |1 is obsolete| | Attachment #77085|0 |1 is obsolete| | Attachment #77086|0 |1 is obsolete| | Attachment #77087|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77207&action=edit Bug 18887: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77208&action=edit Bug 18887: Add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77209&action=edit Bug 18887: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77210&action=edit Bug 18887: Add Koha::CirculationRule(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77211&action=edit Bug 18887: Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77212&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77213&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77214&action=edit Bug 18887: Fix issues caused by rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77215&action=edit Bug 18887: Fix DB structure issues - Make atomic update idempotent - Correct COLLAT (atomic update) - Add index on rule_name (kohastructure.sql) - Add rule_name to the unique constraint (kohastructure.sql) - Remove max_holds columns (kohastructure.sql) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77218&action=edit Bug 18887: Insert undef instead of '*' Koha::CirculationRules->get_effective_rule will become the method to call to retrieve a specific rule, we should start using it when possible. Moreover undef could replace '*' to mean 'any', that way we will be able to add FK on circulation_rules TODO: Add more tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #47)
Created attachment 77218 [details] [review] Bug 18887: Insert undef instead of '*'
Koha::CirculationRules->get_effective_rule will become the method to call to retrieve a specific rule, we should start using it when possible.
Moreover undef could replace '*' to mean 'any', that way we will be able to add FK on circulation_rules
TODO: Add more tests
Kyle, does this last patch make sense to you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77238&action=edit Bug 18887: Use get_effective_rule instead of search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77207|0 |1 is obsolete| | Attachment #77208|0 |1 is obsolete| | Attachment #77209|0 |1 is obsolete| | Attachment #77210|0 |1 is obsolete| | Attachment #77211|0 |1 is obsolete| | Attachment #77212|0 |1 is obsolete| | Attachment #77213|0 |1 is obsolete| | Attachment #77214|0 |1 is obsolete| | Attachment #77215|0 |1 is obsolete| | Attachment #77218|0 |1 is obsolete| | Attachment #77238|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77649&action=edit Bug 18887: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77650&action=edit Bug 18887: Add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77651&action=edit Bug 18887: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #53 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77652&action=edit Bug 18887: Add Koha::CirculationRule(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77653&action=edit Bug 18887: Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77654&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77655&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77656&action=edit Bug 18887: Fix issues caused by rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77657&action=edit Bug 18887: Fix DB structure issues - Make atomic update idempotent - Correct COLLAT (atomic update) - Add index on rule_name (kohastructure.sql) - Add rule_name to the unique constraint (kohastructure.sql) - Remove max_holds columns (kohastructure.sql) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #59 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77658&action=edit Bug 18887: Insert undef instead of '*' Koha::CirculationRules->get_effective_rule will become the method to call to retrieve a specific rule, we should start using it when possible. Moreover undef could replace '*' to mean 'any', that way we will be able to add FK on circulation_rules TODO: Add more tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77659&action=edit Bug 18887: Use get_effective_rule instead of search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #61 from Cab Vinton <bibliwho@gmail.com> --- Patch did not apply to PTFS Sandbox 0. The sandbox you've requested is not ready. Some problems occurred applying patches from bug 18887: <h1>Something went wrong !</h1>Applying: Bug 18887: Update database Applying: Bug 18887: Add new schema file Applying: Bug 18887: Update existing schema files Applying: Bug 18887: Add Koha::CirculationRule(s) Applying: Bug 18887: Port max_holds rules to new CirculationRules system error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt). Patch failed at 0001 Bug 18887: Port max_holds rules to new CirculationRules system The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. error: could not build fake ancestor Bug 18887 - Introduce new table 'circulation_rules', use for 'max_holds' rules 77649 - Bug 18887: Update database 77650 - Bug 18887: Add new schema file 77651 - Bug 18887: Update existing schema files 77652 - Bug 18887: Add Koha::CirculationRule(s) 77653 - Bug 18887: Port max_holds rules to new CirculationRules system 77654 - Bug 18887: (follow-up) Fix behavior for default branch/category 77655 - Bug 18887: (follow-up) Fix null/empty behavior 77656 - Bug 18887: Fix issues caused by rebase 77657 - Bug 18887: Fix DB structure issues 77658 - Bug 18887: Insert undef instead of '*' 77659 - Bug 18887: Use get_effective_rule instead of search Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-18887-Port-maxholds-rules-to-new-CirculationRu-_cXRQk.patch . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77649|0 |1 is obsolete| | Attachment #77650|0 |1 is obsolete| | Attachment #77651|0 |1 is obsolete| | Attachment #77652|0 |1 is obsolete| | Attachment #77653|0 |1 is obsolete| | Attachment #77654|0 |1 is obsolete| | Attachment #77655|0 |1 is obsolete| | Attachment #77656|0 |1 is obsolete| | Attachment #77657|0 |1 is obsolete| | Attachment #77658|0 |1 is obsolete| | Attachment #77659|0 |1 is obsolete| | --- Comment #62 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78346&action=edit Bug 18887: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #63 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78347&action=edit Bug 18887: Add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #64 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78348&action=edit Bug 18887: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78349&action=edit Bug 18887: Add Koha::CirculationRule(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #66 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78350&action=edit Bug 18887: Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78351&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #68 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78352&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78353&action=edit Bug 18887: Fix issues caused by rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #70 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78354&action=edit Bug 18887: Fix DB structure issues - Make atomic update idempotent - Correct COLLAT (atomic update) - Add index on rule_name (kohastructure.sql) - Add rule_name to the unique constraint (kohastructure.sql) - Remove max_holds columns (kohastructure.sql) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78355&action=edit Bug 18887: Insert undef instead of '*' Koha::CirculationRules->get_effective_rule will become the method to call to retrieve a specific rule, we should start using it when possible. Moreover undef could replace '*' to mean 'any', that way we will be able to add FK on circulation_rules TODO: Add more tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #72 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78356&action=edit Bug 18887: Use get_effective_rule instead of search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #73 from Cab Vinton <bibliwho@gmail.com> --- Software error on PTFS sandbox 0: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha.circulation_rules' doesn't exist at /home/koha/src/Koha/Objects.pm line 191 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #74 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Cab Vinton from comment #73)
Software error on PTFS sandbox 0:
Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha.circulation_rules' doesn't exist at /home/koha/src/Koha/Objects.pm line 191
On which page do you get this error? The circulation_rules should have been created during the upgrade process, do you see any errors displayed in the news section on the Koha home page? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #75 from Cab Vinton <bibliwho@gmail.com> --- (In reply to Jonathan Druart from comment #74)
(In reply to Cab Vinton from comment #73)
Software error on PTFS sandbox 0:
Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha.circulation_rules' doesn't exist at /home/koha/src/Koha/Objects.pm line 191
On which page do you get this error? The circulation_rules should have been created during the upgrade process, do you see any errors displayed in the news section on the Koha home page?
Bugger. Can't recreate the error, but I believe the error came when I tried to place a hold on an item. (One or more settings isn't allowing me to place a hold, but haven't been able to isolate which.) Fwiw, I get a similar error when simply trying to check out an item (both with and without the patch applied): Undefined subroutine &C4::Circulation::getnextacctno called at /home/koha/src/C4/Circulation.pm line 3194. Have tried a number of the Biblibre sandboxes as well, but several of those also have issues w/ checking out & placing holds, even w/ master :-( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Bug 18887 depends on bug 15524, which changed state. Bug 15524 Summary: Set limit on maximum possible holds per patron by category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr Status|Needs Signoff |Failed QA --- Comment #76 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- CONFLICT (content): Merge conflict in t/db_dependent/Holds.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #77 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- CONFLICT (content): Merge conflict in t/db_dependent/Holds.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78346|0 |1 is obsolete| | Attachment #78347|0 |1 is obsolete| | Attachment #78348|0 |1 is obsolete| | Attachment #78349|0 |1 is obsolete| | Attachment #78350|0 |1 is obsolete| | Attachment #78351|0 |1 is obsolete| | Attachment #78352|0 |1 is obsolete| | Attachment #78353|0 |1 is obsolete| | Attachment #78354|0 |1 is obsolete| | Attachment #78355|0 |1 is obsolete| | Attachment #78356|0 |1 is obsolete| | --- Comment #78 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78674&action=edit Bug 18887: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78675&action=edit Bug 18887: Add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #80 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78676&action=edit Bug 18887: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #81 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78677&action=edit Bug 18887: Add Koha::CirculationRule(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #82 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78678&action=edit Bug 18887: Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #83 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78679&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #84 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78680&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #85 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78681&action=edit Bug 18887: Fix issues caused by rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #86 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78682&action=edit Bug 18887: Fix DB structure issues - Make atomic update idempotent - Correct COLLAT (atomic update) - Add index on rule_name (kohastructure.sql) - Add rule_name to the unique constraint (kohastructure.sql) - Remove max_holds columns (kohastructure.sql) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #87 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78683&action=edit Bug 18887: Insert undef instead of '*' Koha::CirculationRules->get_effective_rule will become the method to call to retrieve a specific rule, we should start using it when possible. Moreover undef could replace '*' to mean 'any', that way we will be able to add FK on circulation_rules TODO: Add more tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #88 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78684&action=edit Bug 18887: Use get_effective_rule instead of search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lisetteslatah@gmail.com --- Comment #89 from Lisette Scheer <lisetteslatah@gmail.com> --- Patch applied but exploded with the following error when I tried to go to the circulation rules page. Template process failed: undef error - DBIx::Class::Schema::source(): Can't find source for CirculationRule at /home/vagrant/kohaclone/Koha/Objects.pm line 341 at /home/vagrant/kohaclone/C4/Templates.pm line 122 Lisette -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78674|0 |1 is obsolete| | --- Comment #90 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78743&action=edit Bug 18887: Update database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78675|0 |1 is obsolete| | --- Comment #91 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78744&action=edit Bug 18887: Add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78676|0 |1 is obsolete| | --- Comment #92 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78745&action=edit Bug 18887: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78677|0 |1 is obsolete| | --- Comment #93 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78746&action=edit Bug 18887: Add Koha::CirculationRule(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78678|0 |1 is obsolete| | --- Comment #94 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78747&action=edit Bug 18887: Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78679|0 |1 is obsolete| | --- Comment #95 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78748&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78680|0 |1 is obsolete| | --- Comment #96 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78749&action=edit Bug 18887: (follow-up) Fix null/empty behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78681|0 |1 is obsolete| | --- Comment #97 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78750&action=edit Bug 18887: Fix issues caused by rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78682|0 |1 is obsolete| | --- Comment #98 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78751&action=edit Bug 18887: Fix DB structure issues - Make atomic update idempotent - Correct COLLAT (atomic update) - Add index on rule_name (kohastructure.sql) - Add rule_name to the unique constraint (kohastructure.sql) - Remove max_holds columns (kohastructure.sql) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78683|0 |1 is obsolete| | --- Comment #99 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78752&action=edit Bug 18887: Insert undef instead of '*' Koha::CirculationRules->get_effective_rule will become the method to call to retrieve a specific rule, we should start using it when possible. Moreover undef could replace '*' to mean 'any', that way we will be able to add FK on circulation_rules TODO: Add more tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78684|0 |1 is obsolete| | --- Comment #100 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 78753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78753&action=edit Bug 18887: Use get_effective_rule instead of search Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #101 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78879&action=edit Bug 18887: Add 2 missing html filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78743|0 |1 is obsolete| | --- Comment #102 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 79119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79119&action=edit Looks good. Test are all successful. -Jesse Bug 18887: Update database Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #103 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 78744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78744 Bug 18887: Add new schema file Review of attachment 78744: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18887&attachment=78744) ----------------------------------------------------------------- I started reading the code and found few issues: In the schema files I can see the foreign keys for branchcode, categorycode and itemtype, but they aren't defined in db update nor kohastructure.sql. But I think we want them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #104 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 78746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78746 Bug 18887: Add Koha::CirculationRule(s) Review of attachment 78746: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18887&attachment=78746) ----------------------------------------------------------------- ::: Koha/CirculationRule.pm @@ +26,5 @@
+use Koha::ItemTypes; + +=head1 NAME + +Koha::Hold - Koha Hold object class
C & P mistake ::: Koha/CirculationRules.pm @@ +27,5 @@
+use base qw(Koha::Objects); + +=head1 NAME + +Koha::IssuingRules - Koha IssuingRule Object set class
C & P mistake @@ +47,5 @@
+ my $categorycode = $params->{categorycode}; + my $itemtype = $params->{itemtype}; + my $branchcode = $params->{branchcode}; + + croak q{No rule name passed in!} unless $rule_name;
Please use Exception instead of croak @@ +85,5 @@
+ unless exists $params->{itemtype}; + croak q{set_rule requires the parameter 'rule_name'!} + unless exists $params->{rule_name}; + croak q{set_rule requires the parameter 'rule_value'!} + unless exists $params->{rule_value};
Please use Exception instead of croak -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78744|0 |1 is obsolete| | Attachment #78745|0 |1 is obsolete| | Attachment #78746|0 |1 is obsolete| | Attachment #78747|0 |1 is obsolete| | Attachment #78748|0 |1 is obsolete| | Attachment #78749|0 |1 is obsolete| | Attachment #78750|0 |1 is obsolete| | Attachment #78751|0 |1 is obsolete| | Attachment #78752|0 |1 is obsolete| | Attachment #78753|0 |1 is obsolete| | Attachment #78879|0 |1 is obsolete| | Attachment #79119|0 |1 is obsolete| | --- Comment #105 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79626&action=edit Bug 18887: Update database Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #106 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79627&action=edit Bug 18887: Add Koha::CirculationRule(s) Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #107 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79628&action=edit Bug 18887: Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #108 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79629&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #109 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79630&action=edit Bug 18887: (follow-up) Fix null/empty behavior Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #110 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79631&action=edit Bug 18887: Fix issues caused by rebase Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #111 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79632&action=edit Bug 18887: Fix DB structure issues - Make atomic update idempotent - Correct COLLAT (atomic update) - Add index on rule_name (kohastructure.sql) - Add rule_name to the unique constraint (kohastructure.sql) - Remove max_holds columns (kohastructure.sql) Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #112 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79633&action=edit Bug 18887: Insert undef instead of '*' Koha::CirculationRules->get_effective_rule will become the method to call to retrieve a specific rule, we should start using it when possible. Moreover undef could replace '*' to mean 'any', that way we will be able to add FK on circulation_rules TODO: Add more tests Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #113 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79634&action=edit Bug 18887: Use get_effective_rule instead of search Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #114 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79635&action=edit Bug 18887: Add 2 missing html filters Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #115 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79636&action=edit Bug 18887: Add foreign keys -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #116 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79637&action=edit Bug 18887: Add new schema file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #117 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79638&action=edit Bug 18887: Update existing schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #118 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79639&action=edit Bug 18887: Fix POD c/p issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #119 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79640&action=edit Bug 18887: Replace croak with exceptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #120 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79641&action=edit Bug 18887: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #121 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Several things here: 1. I have reattached the patch in the correct order and add the signed-off-by lines for Lisette and Jesse (only last patch was signed off) 2. (In reply to Josef Moravec from comment #103)
Comment on attachment 78744 [details] [review] In the schema files I can see the foreign keys for branchcode, categorycode and itemtype, but they aren't defined in db update nor kohastructure.sql. But I think we want them.
I have reworked the schema files (md5sum was wrong which caused the script to fail). Foreign keys have been added to both kohastructure.sql and atomic update file. 3. (In reply to Josef Moravec from comment #104)
Comment on attachment 78746 [details] [review]
+Koha::Hold - Koha Hold object class
C & P mistake
Fixed (x2) 4.
@@ +47,5 @@
+ my $categorycode = $params->{categorycode}; + my $itemtype = $params->{itemtype}; + my $branchcode = $params->{branchcode}; + + croak q{No rule name passed in!} unless $rule_name;
Please use Exception instead of croak
Removed and exceptions are now thrown 5. Tests have been provided, finally! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79626|0 |1 is obsolete| | Attachment #79627|0 |1 is obsolete| | Attachment #79628|0 |1 is obsolete| | Attachment #79629|0 |1 is obsolete| | Attachment #79630|0 |1 is obsolete| | Attachment #79631|0 |1 is obsolete| | Attachment #79632|0 |1 is obsolete| | Attachment #79633|0 |1 is obsolete| | Attachment #79634|0 |1 is obsolete| | Attachment #79635|0 |1 is obsolete| | Attachment #79636|0 |1 is obsolete| | Attachment #79637|0 |1 is obsolete| | Attachment #79638|0 |1 is obsolete| | Attachment #79639|0 |1 is obsolete| | Attachment #79640|0 |1 is obsolete| | Attachment #79641|0 |1 is obsolete| | --- Comment #122 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79761&action=edit Bug 18887: Update database Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #123 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79762&action=edit Bug 18887: Add Koha::CirculationRule(s) Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #124 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79763&action=edit Bug 18887: Port max_holds rules to new CirculationRules system This is the first step in the circulation rules revamp as detailed in the RFF https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend... This patch moves the recent max_holds rule to the new circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #125 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79764&action=edit Bug 18887: (follow-up) Fix behavior for default branch/category Also, fix a couple small QA issues. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #126 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79765&action=edit Bug 18887: (follow-up) Fix null/empty behavior Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #127 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79766&action=edit Bug 18887: Fix issues caused by rebase Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #128 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79767&action=edit Bug 18887: Fix DB structure issues - Make atomic update idempotent - Correct COLLAT (atomic update) - Add index on rule_name (kohastructure.sql) - Add rule_name to the unique constraint (kohastructure.sql) - Remove max_holds columns (kohastructure.sql) Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #129 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79768&action=edit Bug 18887: Insert undef instead of '*' Koha::CirculationRules->get_effective_rule will become the method to call to retrieve a specific rule, we should start using it when possible. Moreover undef could replace '*' to mean 'any', that way we will be able to add FK on circulation_rules TODO: Add more tests Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #130 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79769&action=edit Bug 18887: Use get_effective_rule instead of search Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #131 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79770&action=edit Bug 18887: Add 2 missing html filters Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Jesse Maseto <jesse@bywatersolution.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #132 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79771&action=edit Bug 18887: Add foreign keys Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #133 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79772&action=edit Bug 18887: Add new schema file Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #134 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79773&action=edit Bug 18887: Update existing schema files Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #135 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79774&action=edit Bug 18887: Fix POD c/p issues Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #136 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79775&action=edit Bug 18887: Replace croak with exceptions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #137 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79776&action=edit Bug 18887: Add tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #138 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79778&action=edit Bug 18887: (QA follow-up) Remove last occurences of old max_holds Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #139 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #121)
Several things here:
1. I have reattached the patch in the correct order and add the signed-off-by lines for Lisette and Jesse (only last patch was signed off)
2. (In reply to Josef Moravec from comment #103)
Comment on attachment 78744 [details] [review] [review] In the schema files I can see the foreign keys for branchcode, categorycode and itemtype, but they aren't defined in db update nor kohastructure.sql. But I think we want them.
I have reworked the schema files (md5sum was wrong which caused the script to fail). Foreign keys have been added to both kohastructure.sql and atomic update file.
3. (In reply to Josef Moravec from comment #104)
Comment on attachment 78746 [details] [review] [review]
+Koha::Hold - Koha Hold object class
C & P mistake
Fixed (x2)
4.
@@ +47,5 @@
+ my $categorycode = $params->{categorycode}; + my $itemtype = $params->{itemtype}; + my $branchcode = $params->{branchcode}; + + croak q{No rule name passed in!} unless $rule_name;
Please use Exception instead of croak
Removed and exceptions are now thrown
5. Tests have been provided, finally!
Great job Jonathan, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #140 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79891&action=edit Bug 18887: Make DB update idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #141 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #142 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #143 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have found a bug in the structure of the table. circulation_rules: PRIMARY KEY (`id`), UNIQUE KEY `branchcode` (`branchcode`,`categorycode`,`itemtype`,`rule_name`), issuingrules: PRIMARY KEY (`branchcode`,`categorycode`,`itemtype`), The difference between UNIQUE and PRIMARY keys is that UNIQUE accept duplicated NULL values. So the DBMS will not raised an error if we try to insert several times the same rule. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #144 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Are you working on a fix for this Jonathan.. or have you opened a followup bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #145 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #144)
Are you working on a fix for this Jonathan.. or have you opened a followup bug?
I do not know what would be the best way to fix it, any ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 --- Comment #146 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ack, of course.. this is where NULL being meaningful is bad :(. Hmm, in a few other projects I enforced via relations and made sure I had a 'hidden' default to replace anywhere I'd want a NULL.. but I think that would be a pretty drastic change.. I'll ponder for a while. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22526 [Bug 22526] The circulation rules table does not exist -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22847 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org