[Bug 38148] New: Unable to place OPAC holds and holds to pull list is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Bug ID: 38148 Summary: Unable to place OPAC holds and holds to pull list is empty Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This is due to Bug 29087, see comment 39 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 172680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172680&action=edit Bug 38148: Check value of holdallowed circ rule properly To test: 1. Search for a record on the OPAC. Notice there is no link to place a hold. 2. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and notice it is empty 3. Apply patch and restart services 4. Search for a record on the OPAC. Confirm you can see a link to place a hold. 5. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and confirm your hold shows in the list. Sponsored-by: Whanganui District Council -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29087 Summary|Unable to place OPAC holds |Check value of holdallowed |and holds to pull list is |circ rule properly (Bug |empty |29087 follow-up) Severity|blocker |major --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- So Bug 29087 was the cause of being unable to place OPAC holds and the holds to pull list being empty for this library, and the fix does solve it for them... but I'm not totally sure what combination of their catalogue and circ rules caused it to happen to them. In short, I don't know how to write a test plan for this. I've updated the bug report accordingly and will attach a new test plan. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 [Bug 29087] Holds to pull list can crash with a SQL::Abstract puke -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172680|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 172681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172681&action=edit Bug 38148: Check value of holdallowed circ rule properly It was noted on Bug 29087 that the value of circulation rules needs to be checked differently, so this follow-up addresses that. To test: 1. Apply patch and restart services 2. Search for a record on the OPAC. Confirm you can see a link to place a hold. 3. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and confirm your hold shows in the list. 4. Confirm tests still pass t/db_dependent/Koha/Holds.t Sponsored-by: Whanganui District Council -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172681|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 172929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172929&action=edit Bug 38148: Check value of holdallowed circ rule properly It was noted on Bug 29087 that the value of circulation rules needs to be checked differently, so this follow-up addresses that. To test: 1. Apply patch and restart services 2. Search for a record on the OPAC. Confirm you can see a link to place a hold. 3. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and confirm your hold shows in the list. 4. Confirm tests still pass t/db_dependent/Koha/Holds.t Sponsored-by: Whanganui District Council Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |pedro.amorim@ptfs-europe.co | |m, r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |andreas.jonsson@kreablo.se, | |jonathan.druart@gmail.com, | |m.de.rooy@rijksmuseum.nl, | |matt.blenkinsop@ptfs-europe | |.com --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi guys, thanks for helping here, we're now also experiencing this regression in 23.11.09. At first glance this patch looks good, but it's causing the following to FAIL: prove t/db_dependent/Koha/Items.t I'm adding others involved in bug 29087 to pitch in if they have the chance / are available to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Aleisha Amohia from comment #2)
In short, I don't know how to write a test plan for this. I've updated the bug report accordingly and will attach a new test plan.
On fresh k-t-d: 1) Search for 'music' on OPAC 2) Notice records have the 'place hold' link 3) Visit circulation rules on Staff: <staff_url>/cgi-bin/koha/admin/smart-rules.pl 4) On 'Default checkout, hold and return policy' , under 'Hold policy' pick 'From any library'. Hit 'Save'. 5) Repeat 1). Notice the 'place hold' link is gone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173125&action=edit Bug 38148: Revert back to get_effective_rule And update the first conditional logic. This patch aims to maintain the logic behind the first patch, but restore get_effective_rule. get_effective_rule_value is using cache and I believe that is the reason why Items.t fail when using that. Test plan: 1) Search for 'music' on OPAC 2) Notice records have the 'place hold' link 3) Visit circulation rules on Staff: <staff_url>/cgi-bin/koha/admin/smart-rules.pl 4) On 'Default checkout, hold and return policy' , under 'Hold policy' pick 'From any library'. Hit 'Save'. 5) Repeat 1). Notice the 'place hold' link is gone. 6) Apply patch. restart plack. Repeat 1). Notice the 'place hold' is shown again Run: $ prove t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi all, asking for someone to take a look here when possible as this bug is causing issues for a lot of our user base. I've submitted a follow-up with an updated test plan which aims to keep the fix introduced by the original patch but updated to not break tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172929|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 173141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173141&action=edit Bug 38148: Check value of holdallowed circ rule properly It was noted on Bug 29087 that the value of circulation rules needs to be checked differently, so this follow-up addresses that. To test: 1. Apply patch and restart services 2. Search for a record on the OPAC. Confirm you can see a link to place a hold. 3. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and confirm your hold shows in the list. 4. Confirm tests still pass t/db_dependent/Koha/Holds.t Sponsored-by: Whanganui District Council Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173125|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 173142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173142&action=edit Bug 38148: Revert back to get_effective_rule And update the first conditional logic. This patch aims to maintain the logic behind the first patch, but restore get_effective_rule. get_effective_rule_value is using cache and I believe that is the reason why Items.t fail when using that. Test plan: 1) Search for 'music' on OPAC 2) Notice records have the 'place hold' link 3) Visit circulation rules on Staff: <staff_url>/cgi-bin/koha/admin/smart-rules.pl 4) On 'Default checkout, hold and return policy' , under 'Hold policy' pick 'From any library'. Hit 'Save'. 5) Repeat 1). Notice the 'place hold' link is gone. 6) Apply patch. restart plack. Repeat 1). Notice the 'place hold' is shown again Run: $ prove t/db_dependent/Koha/Items.t Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173141|0 |1 is obsolete| | --- Comment #11 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 173143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173143&action=edit Bug 38148: Check value of holdallowed circ rule properly It was noted on Bug 29087 that the value of circulation rules needs to be checked differently, so this follow-up addresses that. To test: 1. Apply patch and restart services 2. Search for a record on the OPAC. Confirm you can see a link to place a hold. 3. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and confirm your hold shows in the list. 4. Confirm tests still pass t/db_dependent/Koha/Holds.t Sponsored-by: Whanganui District Council Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173142|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 173144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173144&action=edit Bug 38148: Revert back to get_effective_rule And update the first conditional logic. This patch aims to maintain the logic behind the first patch, but restore get_effective_rule. get_effective_rule_value is using cache and I believe that is the reason why Items.t fail when using that. Test plan: 1) Search for 'music' on OPAC 2) Notice records have the 'place hold' link 3) Visit circulation rules on Staff: <staff_url>/cgi-bin/koha/admin/smart-rules.pl 4) On 'Default checkout, hold and return policy' , under 'Hold policy' pick 'From any library'. Hit 'Save'. 5) Repeat 1). Notice the 'place hold' link is gone. 6) Apply patch. restart plack. Repeat 1). Notice the 'place hold' is shown again Run: $ prove t/db_dependent/Koha/Items.t Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #13 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Great job all! Test plan worked like a breeze. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #14 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Tested in both a sandbox and a ktd. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173143|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173169&action=edit Bug 38148: Check value of holdallowed circ rule properly It was noted on Bug 29087 that the value of circulation rules needs to be checked differently, so this follow-up addresses that. To test: 1. Apply patch and restart services 2. Search for a record on the OPAC. Confirm you can see a link to place a hold. 3. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and confirm your hold shows in the list. 4. Confirm tests still pass t/db_dependent/Koha/Holds.t Sponsored-by: Whanganui District Council Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173144|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 173170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173170&action=edit Bug 38148: Revert back to get_effective_rule And update the first conditional logic. This patch aims to maintain the logic behind the first patch, but restore get_effective_rule. get_effective_rule_value is using cache and I believe that is the reason why Items.t fail when using that. Test plan: 1) Search for 'music' on OPAC 2) Notice records have the 'place hold' link 3) Visit circulation rules on Staff: <staff_url>/cgi-bin/koha/admin/smart-rules.pl 4) On 'Default checkout, hold and return policy' , under 'Hold policy' pick 'From any library'. Hit 'Save'. 5) Repeat 1). Notice the 'place hold' link is gone. 6) Apply patch. restart plack. Repeat 1). Notice the 'place hold' is shown again Run: $ prove t/db_dependent/Koha/Items.t Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173169|0 |1 is obsolete| | Attachment #173170|0 |1 is obsolete| | --- Comment #17 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173183&action=edit Bug 38148: Unit tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #18 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173184&action=edit Bug 38148: Check value of holdallowed circ rule properly It was noted on Bug 29087 that the value of circulation rules needs to be checked differently, so this follow-up addresses that. To test: 1. Apply patch and restart services 2. Search for a record on the OPAC. Confirm you can see a link to place a hold. 3. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and confirm your hold shows in the list. 4. Confirm tests still pass t/db_dependent/Koha/Holds.t Sponsored-by: Whanganui District Council Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Bug 38148: Revert back to get_effective_rule And update the first conditional logic. This patch aims to maintain the logic behind the first patch, but restore get_effective_rule. get_effective_rule_value is using cache and I believe that is the reason why Items.t fail when using that. Test plan: 1) Search for 'music' on OPAC 2) Notice records have the 'place hold' link 3) Visit circulation rules on Staff: <staff_url>/cgi-bin/koha/admin/smart-rules.pl 4) On 'Default checkout, hold and return policy' , under 'Hold policy' pick 'From any library'. Hit 'Save'. 5) Repeat 1). Notice the 'place hold' link is gone. 6) Apply patch. restart plack. Repeat 1). Notice the 'place hold' is shown again Run: $ prove t/db_dependent/Koha/Items.t Squashed during QA - wnc Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #19 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173185&action=edit Bug 38148: (QA follow-up) Code comments Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Severity|major |critical --- Comment #20 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I squashed the two existing patches - I added test to confirm that an all allowed rule doesn't break, they fail before and pass after these. I added an optional patch with comments if RM finds them useful -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173170|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173169|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173169|0 |1 is obsolete| | Attachment #173170|0 |1 is obsolete| | Attachment #173183|0 |1 is obsolete| | Attachment #173185|0 |1 is obsolete| | --- Comment #21 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173205&action=edit Bug 38148: Unit tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #22 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173206&action=edit Bug 38148: Check value of holdallowed circ rule properly It was noted on Bug 29087 that the value of circulation rules needs to be checked differently, so this follow-up addresses that. To test: 1. Apply patch and restart services 2. Search for a record on the OPAC. Confirm you can see a link to place a hold. 3. Search for this record on the staff interface and place a hold. Go to Circulation -> Holds to pull and confirm your hold shows in the list. 4. Confirm tests still pass t/db_dependent/Koha/Holds.t Sponsored-by: Whanganui District Council Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #23 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173207&action=edit Bug 38148: Revert back to get_effective_rule And update the first conditional logic. This patch aims to maintain the logic behind the first patch, but restore get_effective_rule. get_effective_rule_value is using cache and I believe that is the reason why Items.t fail when using that. Test plan: 1) Search for 'music' on OPAC 2) Notice records have the 'place hold' link 3) Visit circulation rules on Staff: <staff_url>/cgi-bin/koha/admin/smart-rules.pl 4) On 'Default checkout, hold and return policy' , under 'Hold policy' pick 'From any library'. Hit 'Save'. 5) Repeat 1). Notice the 'place hold' link is gone. 6) Apply patch. restart plack. Repeat 1). Notice the 'place hold' is shown again Run: $ prove t/db_dependent/Koha/Items.t Signed-off-by: andrewa <andrew.auld@ptfs-europe.com> Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #24 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 173208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173208&action=edit Bug 38148: (QA follow-up) Code comments Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for the quick work here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Sandbox | QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #27 from Christopher Brannon <cbrannon@cdalibrary.org> --- Backport to 24.05???? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate --- Comment #28 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Christopher Brannon from comment #27)
Backport to 24.05????
Yes please, and 23.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.05 released in| | --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.05 |24.11.00,24.05.05,23.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #30 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #31 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #32 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Wainui Witika-Park from comment #31)
Not backporting to 23.05.x unless requested
Should not be needed. I believe this was caused by bug 29087 (not in 23.05.x). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 --- Comment #33 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- *** Bug 38134 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148 Bug 38148 depends on bug 29087, which changed state. Bug 29087 Summary: Holds to pull list can crash with a SQL::Abstract puke https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org