[Bug 37351] New: Using checkboxes on circ/aitingreserves.pl does not add them to cancellation list after changing to Page 2 or more of DataTable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Bug ID: 37351 Summary: Using checkboxes on circ/aitingreserves.pl does not add them to cancellation list after changing to Page 2 or more of DataTable Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cj.lynce@westlakelibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Steps to reproduce *Note for these steps to work, you must have enough holds waiting to necessitate a 2nd page of holds in circ/waitingreserves.pl 1. Log in to staff client 2. Place items on items for borrowers 2-1 Place enough holds as noted above 2-2 Trap holds for borrowers 3. Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 4. Click a checkbox for one or mroe holds Note->The 'Cancel selected (0)' button changes to 'Cancel selected (1)', etc. 5. Cancel selected Holds using the (Cancel selected (#) button) 6. Confirm Cancellation 7. Wait for background processes to complete, then verify holds are cancelled. 8. Return to Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 9. Ensure button shows "Cancel selected (0)" 10. Click "Next >" to navigate to page 2 of holds 11. Click a checkbox for one or more holds Note->The 'Cancel selected (0)' button DOES NOT increase as boxes are selected. 12. Cancel selected Holds using the (Cancel selected (#) button) 13. Confirm Cancellation 14. Wait for background processes to complete, then verify holds are cancelled. Note-> Holds were not cancelled The same behavior is reflected in the Holds waiting past their expiration date (Holds with cancellation requests not tested) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 CJ L. <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using checkboxes on |Using checkboxes on |circ/aitingreserves.pl does |circ/waitingreserves.pl |not add them to |does not add them to |cancellation list after |cancellation list after |changing to Page 2 or more |changing to Page 2 or more |of DataTable |of DataTable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 CJ L. <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 holly@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- confirmed in main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 169523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169523&action=edit Bug 37351: Rework checkbox JS to work with paginating dataTable To Test: 1. Log in to staff client 2. Place items on items for borrowers 2-1 Place enough holds as noted above 2-2 Trap holds for borrowers 3. Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 4. Click a checkbox for one or mroe holds Note->The 'Cancel selected (0)' button changes to 'Cancel selected (1)', etc. 5. Cancel selected Holds using the (Cancel selected (#) button) 6. Confirm Cancellation 7. Wait for background processes to complete, then verify holds are cancelled. 8. Return to Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 9. Ensure button shows "Cancel selected (0)" 10. Click "Next >" to navigate to page 2 of holds 11. Click a checkbox for one or more holds Note->The 'Cancel selected (0)' button DOES NOT increase as boxes are selected. 12. Cancel selected Holds using the (Cancel selected (#) button) 13. Confirm Cancellation 14. Wait for background processes to complete, then verify holds are cancelled. Note-> Holds were not cancelled 15. APPLY PATCH 16. Try step 9-14 again. This time the 'Cancel selected (0)' button should update even when you paginate. 17. Make sure you try all the tables, Holds waiting, Holds waiting over X, Holds with cancellation requests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169523|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 169524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169524&action=edit Bug 37351: Rework checkbox JS to work with paginating dataTable To Test: 1. Log in to staff client 2. Place items on items for borrowers 2-1 Place enough holds as noted above 2-2 Trap holds for borrowers 3. Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 4. Click a checkbox for one or mroe holds Note->The 'Cancel selected (0)' button changes to 'Cancel selected (1)', etc. 5. Cancel selected Holds using the (Cancel selected (#) button) 6. Confirm Cancellation 7. Wait for background processes to complete, then verify holds are cancelled. 8. Return to Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 9. Ensure button shows "Cancel selected (0)" 10. Click "Next >" to navigate to page 2 of holds 11. Click a checkbox for one or more holds Note->The 'Cancel selected (0)' button DOES NOT increase as boxes are selected. 12. Cancel selected Holds using the (Cancel selected (#) button) 13. Confirm Cancellation 14. Wait for background processes to complete, then verify holds are cancelled. Note-> Holds were not cancelled 15. APPLY PATCH 16. Try step 9-14 again. This time the 'Cancel selected (0)' button should update even when you paginate. 17. Make sure you try all the tables, Holds waiting, Holds waiting over X, Holds with cancellation requests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169524|0 |1 is obsolete| | --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169597&action=edit Bug 37351: Rework checkbox JS to work with paginating dataTable To Test: 1. Log in to staff client 2. Place items on items for borrowers 2-1 Place enough holds as noted above 2-2 Trap holds for borrowers 3. Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 4. Click a checkbox for one or mroe holds Note->The 'Cancel selected (0)' button changes to 'Cancel selected (1)', etc. 5. Cancel selected Holds using the (Cancel selected (#) button) 6. Confirm Cancellation 7. Wait for background processes to complete, then verify holds are cancelled. 8. Return to Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 9. Ensure button shows "Cancel selected (0)" 10. Click "Next >" to navigate to page 2 of holds 11. Click a checkbox for one or more holds Note->The 'Cancel selected (0)' button DOES NOT increase as boxes are selected. 12. Cancel selected Holds using the (Cancel selected (#) button) 13. Confirm Cancellation 14. Wait for background processes to complete, then verify holds are cancelled. Note-> Holds were not cancelled 15. APPLY PATCH 16. Try step 9-14 again. This time the 'Cancel selected (0)' button should update even when you paginate. 17. Make sure you try all the tables, Holds waiting, Holds waiting over X, Holds with cancellation requests. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 --- Comment #5 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 169613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169613&action=edit Bug 36936: (QA follow-up) Make the test work on MySQL 8.x Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169613|0 |1 is obsolete| | --- Comment #6 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 169614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169614&action=edit Bug 36936: (QA follow-up) Make the test work on MySQL 8.x Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169614|0 |1 is obsolete| | --- Comment #7 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Comment on attachment 169614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169614 Bug 36936: (QA follow-up) Make the test work on MySQL 8.x Removing mistake attachment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169597|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169715&action=edit Bug 37351: Rework checkbox JS to work with paginating dataTable To Test: 1. Log in to staff client 2. Place items on items for borrowers 2-1 Place enough holds as noted above 2-2 Trap holds for borrowers 3. Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 4. Click a checkbox for one or mroe holds Note->The 'Cancel selected (0)' button changes to 'Cancel selected (1)', etc. 5. Cancel selected Holds using the (Cancel selected (#) button) 6. Confirm Cancellation 7. Wait for background processes to complete, then verify holds are cancelled. 8. Return to Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl) 9. Ensure button shows "Cancel selected (0)" 10. Click "Next >" to navigate to page 2 of holds 11. Click a checkbox for one or more holds Note->The 'Cancel selected (0)' button DOES NOT increase as boxes are selected. 12. Cancel selected Holds using the (Cancel selected (#) button) 13. Confirm Cancellation 14. Wait for background processes to complete, then verify holds are cancelled. Note-> Holds were not cancelled 15. APPLY PATCH 16. Try step 9-14 again. This time the 'Cancel selected (0)' button should update even when you paginate. 17. Make sure you try all the tables, Holds waiting, Holds waiting over X, Holds with cancellation requests. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Using checkboxes on |Checkboxes on waiting holds |circ/waitingreserves.pl |report are not kept when |does not add them to |switching to another page |cancellation list after | |changing to Page 2 or more | |of DataTable | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.04 released in| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00,24.05.04 |24.11.00,24.05.04,23.11.09 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37351 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org