http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12458 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 29096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29096&action=edit Bug 12458 - Holidays calendar has wrong colors for weekly and yearly repeatable In Tools / Calendar, the colors in the calendar for weekly and yearly repeatable are different from the color of the "Key" legend. This patch sets the colors used in the "Key" legend to the cells if calendar. Test plan : - Go to Tools/Calendar - Add a weekly repeatable holiday - Check its color in calendar is the same as the text "Holiday repeating weekly" => Without this patch, it's green instead of yellow - Add a yearly repeatable holiday - Check its color in calendar is the same as the text "Holiday repeating yearly" => Without this patch, it's yellow instead of orange - Check the color of others holydays types are OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12458 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12458 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12458 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29122|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29130&action=edit [PASSED QA] Bug 12458 - Holidays calendar has wrong colors for weekly and yearly repeatable In Tools / Calendar, the colors in the calendar for weekly and yearly repeatable are different from the color of the "Key" legend. This patch sets the colors used in the "Key" legend to the cells if calendar. Test plan : - Go to Tools/Calendar - Add a weekly repeatable holiday - Check its color in calendar is the same as the text "Holiday repeating weekly" => Without this patch, it's green instead of yellow - Add a yearly repeatable holiday - Check its color in calendar is the same as the text "Holiday repeating yearly" => Without this patch, it's yellow instead of orange - Check the color of others holydays types are OK Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> I'd like to see today's date a clearly different color from the weekly repeated holiday, because now they're close in color. But this patch does exactly what it says and should so I'm signing off. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Legend, headings and calendar colors now match. No problems found. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12458 --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Whaou, a one-day-resolved bug ;) Thanks everyone. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12458 --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes.