[Bug 10818] New: System preference OAI-PMH:ConfFile isn't translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Bug ID: 10818 Summary: System preference OAI-PMH:ConfFile isn't translatable Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr This text, from System preference OAI-PMH:ConfFile, isn't translatable, and is still in english in the staff interface: "If empty, Koha OAI Server operates in normal mode, otherwise it operates in extended mode. In extended mode, it's possible to parameter other formats than marcxml or Dublin Core. OAI-PMH:ConfFile specify a YAML configuration file which list available metadata formats and XSL file used to create them from marcxml records." The reason is, obviously, that this text isn't in the *-pref.po files on translate.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|3.12 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug still valid on current master branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Not only that text is not translated. Also file description is missing in english. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26519&action=edit Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable This patch correct english display for OAI-PMH:ConfFile syspref, and makes it's strings translatable To test: 1) On Administration > System preferences > Web Services OAI-PMH:ConfFile syspref doesn't have description before file box. Text after that box is not translated. 2) Choose your prefered language, xx-YY, update po files cd misc/translator perl translate update xx-YY 3) Look into xx-YY-pref.po for any occurence of "YAML", there is none 4) Apply the patch 5) Update po files again 6) Look into xx-YY-pref.po, now there are 2 entries 7) Also reload page from 1) and check for text before file box. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26519|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26697&action=edit Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable This patch correct english display for OAI-PMH:ConfFile syspref, and makes it's strings translatable To test: 1) On Administration > System preferences > Web Services OAI-PMH:ConfFile syspref doesn't have description before file box. Text after that box is not translated. 2) Choose your prefered language, xx-YY, update po files cd misc/translator perl translate update xx-YY 3) Look into xx-YY-pref.po for any occurence of "YAML", there is none 4) Apply the patch 5) Update po files again 6) Look into xx-YY-pref.po, now there are 2 entries 7) Also reload page from 1) and check for text before file box. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I had to use install and not update, but the idea is the same. Having fixed the English po files, the other language po files (I used fr-FR) correctly generates text before the system preference text box. It's still English, but that is expected, as far as I know, since the French po files are lacking the translation for the strings. This corrects two problems at the same time, not just the original bug problem. 1) Missing text before system preference text box. 2) Missing string to translate in the po file. Where (2) is the original problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the step Mark was missing is 5.5 reinstall the templates. :) Bernardo, thx a lot for tackling all those translation problems! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26697|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26699&action=edit [PASSED QA] Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable This patch correct english display for OAI-PMH:ConfFile syspref, and makes it's strings translatable To test: 1) On Administration > System preferences > Web Services OAI-PMH:ConfFile syspref doesn't have description before file box. Text after that box is not translated. 2) Choose your prefered language, xx-YY, update po files cd misc/translator perl translate update xx-YY 3) Look into xx-YY-pref.po for any occurence of "YAML", there is none 4) Apply the patch 5) Update po files again 6) Look into xx-YY-pref.po, now there are 2 entries 7) Also reload page from 1) and check for text before file box. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I had to use install and not update, but the idea is the same. Having fixed the English po files, the other language po files (I used fr-FR) correctly generates text before the system preference text box. It's still English, but that is expected, as far as I know, since the French po files are lacking the translation for the strings. This corrects two problems at the same time, not just the original bug problem. 1) Missing text before system preference text box. 2) Missing string to translate in the po file. Where (2) is the original problem. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works for me as described, only changes YAML pref file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 3.12.x, will be in 3.12.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org