[Bug 30244] New: Hide lost items not repsected in OPAC results xslt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Bug ID: 30244 Summary: Hide lost items not repsected in OPAC results xslt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1 - Set systempreference hidelostitems to "Don't show" 2 - Edit a record to set one item as lost and one as available 3 - Perform an OPAC search that returns the record above 4 - Note that the lost item shows in availability line 5 - Click on the record - note the lost item does not show on details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131588&action=edit Bug 30244: Include lost items in list of hidden items When building search results for XSLT we generate and pass a list of hidden itemnumbers. We do skip the lost items in our parsing, however, we neglect to add the itemnumber to the hidden list This patch simply adds the lost itemnumbers to the list There is more work to be done here to simpliofy this process, however, this patch resolves the issue and can be backported to stable branches To test: 1 - Set systempreference hidelostitems to "Don't show" 2 - Edit a record to set one item as lost and one as available 3 - Perform an OPAC search that returns the record above 4 - Note that the lost item shows in availability line 5 - Click on the record - note the lost item does not show on details 6 - Apply patch 7 - Reload search results 8 - Lost itme no longer displays -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131588|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 131591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131591&action=edit Bug 30244: Include lost items in list of hidden items When building search results for XSLT we generate and pass a list of hidden itemnumbers. We do skip the lost items in our parsing, however, we neglect to add the itemnumber to the hidden list This patch simply adds the lost itemnumbers to the list There is more work to be done here to simpliofy this process, however, this patch resolves the issue and can be backported to stable branches To test: 1 - Set systempreference hidelostitems to "Don't show" 2 - Edit a record to set one item as lost and one as available 3 - Perform an OPAC search that returns the record above 4 - Note that the lost item shows in availability line 5 - Click on the record - note the lost item does not show on details 6 - Apply patch 7 - Reload search results 8 - Lost itme no longer displays Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hide lost items not |Hide lost items not |repsected in OPAC results |respected in OPAC results |xslt |XSLT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131591|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 132193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132193&action=edit Bug 30244: Include lost items in list of hidden items When building search results for XSLT we generate and pass a list of hidden itemnumbers. We do skip the lost items in our parsing, however, we neglect to add the itemnumber to the hidden list This patch simply adds the lost itemnumbers to the list There is more work to be done here to simpliofy this process, however, this patch resolves the issue and can be backported to stable branches To test: 1 - Set systempreference hidelostitems to "Don't show" 2 - Edit a record to set one item as lost and one as available 3 - Perform an OPAC search that returns the record above 4 - Note that the lost item shows in availability line 5 - Click on the record - note the lost item does not show on details 6 - Apply patch 7 - Reload search results 8 - Lost itme no longer displays Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Confirmed this resolves the issue and agree we should tidy up a bit in a future bug but keep this as a simple backport. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30244 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.05 released in| | CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org