[Bug 42451] New: "convert" op in guided_reports.pl is broken due to JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 Bug ID: 42451 Summary: "convert" op in guided_reports.pl is broken due to JS error Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com "convert" op in guided_reports.pl is broken due to JS error: Uncaught TypeError: Cannot read properties of undefined (reading 'backdrop') It should also be converted into "cud-convert" anyway -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Cook from comment #0)
Uncaught TypeError: Cannot read properties of undefined (reading 'backdrop')
This is an error related to Bootstrap modals which should not affect any functionality. It shows up on several staff interface pages. I'm not sure when this might have gotten broken, but it looks to me like the 'data-bs-toggle="modal"' might be overriding the click handler for "#update_sql_button". Since the button should act as a link which reloads the page I don't think we need the modal toggle action at all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- The context of this post is with React, but maybe it provides us some clues too: https://stackoverflow.com/questions/74906431/uncaught-typeerror-cannot-read-... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #1)
(In reply to David Cook from comment #0)
Uncaught TypeError: Cannot read properties of undefined (reading 'backdrop')
This is an error related to Bootstrap modals which should not affect any functionality. It shows up on several staff interface pages.
I'm not sure when this might have gotten broken, but it looks to me like the 'data-bs-toggle="modal"' might be overriding the click handler for "#update_sql_button". Since the button should act as a link which reloads the page I don't think we need the modal toggle action at all.
I didn't have time to dig in as I was working on something else, but thanks for that insight. You're probably right. Happy for you to make the change if you want, or I'll get to it at some point -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 [Bug 42548] Add possibility to list multiple barcodes or one biblionumber on attach item action -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42548 Depends on|42548 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 [Bug 42548] Add possibility to list multiple barcodes or one biblionumber on attach item action -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199001&action=edit Bug 42451: Remove JS error when converting a report Test plan: Create a report with: SELECT marcxml from biblioitems Hit /reports/guided_reports.pl?op=list Notice the "Update SQL" button in the "Update" column, Click "Update" => JS error "Uncaught TypeError: can't access property "backdrop", this._config is undefined" (in Firefox) And nothing happens Apply this patch, reload, click the button => Success, the report is updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199002&action=edit Bug 42451: Remove duplicate success message Patch from commit 65f47a8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Created attachment 199002 [details] [review] Bug 42451: Remove duplicate success message
Patch from commit 65f47a8
Caused by commit cb01b253308060bad942723413feef1fd70825fd Bug 17047: SQL reports management with Mana-KB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199001|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199006&action=edit Bug 42451: Remove JS error when converting a report Test plan: Create a report with: SELECT marcxml from biblioitems Hit /reports/guided_reports.pl?op=list Notice the "Update SQL" button in the "Update" column, Click "Update" => JS error "Uncaught TypeError: can't access property "backdrop", this._config is undefined" (in Firefox) And nothing happens Apply this patch, reload, click the button => Success, the report is updated Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199007&action=edit Bug 42451: Remove duplicate success message Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #7)
Created attachment 199006 [details] [review] Bug 42451: Remove JS error when converting a report
Test plan: Create a report with: SELECT marcxml from biblioitems Hit /reports/guided_reports.pl?op=list Notice the "Update SQL" button in the "Update" column, Click "Update" => JS error "Uncaught TypeError: can't access property "backdrop", this._config is undefined" (in Firefox) And nothing happens Apply this patch, reload, click the button => Success, the report is updated
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Is this still valid? there is no Update button in the Update column for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass (lukeg) from comment #9)
Is this still valid? there is no Update button in the Update column for me.
I see the update button if I create a new report with the SQL in the test plan, "SELECT marcxml from biblioitems." It says "This report seems obsolete, it uses biblioitems.marcxml field." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #10)
(In reply to Lucas Gass (lukeg) from comment #9)
Is this still valid? there is no Update button in the Update column for me.
I see the update button if I create a new report with the SQL in the test plan, "SELECT marcxml from biblioitems." It says "This report seems obsolete, it uses biblioitems.marcxml field."
Yeah the key part is having old school fields in the SQL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42548 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42548 [Bug 42548] Add possibility to list multiple barcodes or one biblionumber on attach item action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42451 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org