[Bug 43204] New: ILL availability search: Source column links to plain OPAC URL instead of the deep link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 Bug ID: 43204 Summary: ILL availability search: Source column links to plain OPAC URL instead of the deep link Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edith.speller@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 --- Comment #1 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 202737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202737&action=edit Bug 43204: Fix ILL availability Source column ignoring deep link ill-availability.js renders results from ILL availability plugins. Each result can carry a `url` (deep link to the record) and an `opac_url` (generic fallback). The Title column correctly prefers `url`, but the Source column links to `opac_url` unconditionally and never checks `url`, so results always link to the bare OPAC URL even when a deep link is available. Make Source prefer `url`, falling back to `opac_url`, same as Title. To test: 1) Install the latest release of the plugin: https://github.com/openfifth/koha-plugin-ill-avail-z3950/releases 2) Enable ILLModule, ILLCheckAvailability. 3) Set AdditionalFieldsInZ3950ResultSearch = 856$a, 999$c, 001. 4) Add Z39.50 server: Name KTD, Hostname localhost, Port 2100, Database biblios, Syntax MARC21/USMARC. 5) Configure the ILL z3950 plugin: tick the 'KTD' box, set bib ID field 999$c, deep link http://localhost:8081/cgi-bin/koha/opac-detail.pl?biblionumber=source_record..., OPAC URL http://localhost:8080, tick the last 3 display checkboxes, leave Partner ID blank. 6) Add a new ILL request: type book, ISBN 0879307447, cardnumber 42, destination library Centerville. 7) Go to availability search, confirm the result links to the correct deep-linked biblio, not a bare fallback. Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202737|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 --- Comment #2 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 203217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203217&action=edit Bug 43204: Fix ILL availability Source column ignoring deep link ill-availability.js renders results from ILL availability plugins. Each result can carry a `url` (deep link to the record) and an `opac_url` (generic fallback). The Title column correctly prefers `url`, but the Source column links to `opac_url` unconditionally and never checks `url`, so results always link to the bare OPAC URL even when a deep link is available. Make Source prefer `url`, falling back to `opac_url`, same as Title. To test: 1) Install the latest release of the plugin: https://github.com/openfifth/koha-plugin-ill-avail-z3950/releases 2) Enable ILLModule, ILLCheckAvailability. 3) Set AdditionalFieldsInZ3950ResultSearch = 856$a, 999$c, 001. 4) Add Z39.50 server: Name KTD, Hostname localhost, Port 2100, Database biblios, Syntax MARC21/USMARC. 5) Configure the ILL z3950 plugin: tick the 'KTD' box, set bib ID field 999$c, deep link http://localhost:8081/cgi-bin/koha/opac-detail.pl?biblionumber=source_record..., OPAC URL http://localhost:8080, tick the last 3 display checkboxes, leave Partner ID blank. 6) Add a new ILL request: type book, ISBN 0879307447, cardnumber 42, destination library Centerville. 7) Go to availability search, confirm the result links to the correct deep-linked biblio, not a bare fallback. Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 --- Comment #3 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43204 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.05 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org