[Bug 26602] New: Datatables - Actions columns should not be exported
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Bug ID: 26602 Summary: Datatables - Actions columns should not be exported Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org th should contain the NoExport class to prevent these columns to be exported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's "noExport". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115237&action=edit Bug 26602: Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27251 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115237|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115249&action=edit Bug 26602: Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115249|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 116433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116433&action=edit Bug 26602: Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 116434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116434&action=edit Bug 26602: (QA follow-up) Cleanup datatables settings On letter.tt we had nosort and set things via settings that are default in KohaTable so removed those from letter.js. Also made the last updated column exportable On upload.tt the noExport didn't do anything, because we couldn't export, so moved to used KohaTable Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27646 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27646 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27646 [Bug 27646] Allow export of acquisitions home and funds table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.03 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05. Please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117203&action=edit Bug 26602: [20.05.x] Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 26602: (QA follow-up) Cleanup datatables settings On letter.tt we had nosort and set things via settings that are default in KohaTable so removed those from letter.js. Also made the last updated column exportable On upload.tt the noExport didn't do anything, because we couldn't export, so moved to used KohaTable Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117203|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117212&action=edit Bug 26602: [20.05.x] Don't export "actions" column This patch add the noExport class to all "Actions" columns in the codebase. It's a stupid search and replace, maybe the class is added to table where there is no export button. Test plan: Search tables where the export button is available. Confirm that the "Actions" columns is not exported. Example: /admin/branches.pl, /admin/cities.pl Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 26602: (QA follow-up) Cleanup datatables settings On letter.tt we had nosort and set things via settings that are default in KohaTable so removed those from letter.js. Also made the last updated column exportable On upload.tt the noExport didn't do anything, because we couldn't export, so moved to used KohaTable Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Bug 26602: Rebase fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26602 --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 117216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117216&action=edit Bug 26602:[20.05.x] Remove stray merge marker -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org