[Bug 27653] New: Do not include 'caption' row in print/copy export of datatables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Bug ID: 27653 Summary: Do not include 'caption' row in print/copy export of datatables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The 'caption' field is used a a few dataTables as a place to store filters etc. We do not wish this to be included when copying/printing the tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |27646 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27646 [Bug 27646] Allow export of acquisitions home and funds table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 116495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116495&action=edit Bug 27653: Set messageTop to null for KohaTables This patch sets messageTop to null for KohaTables. This prevents the filter row from being included in an export. To test: 1 - Browse to acquisitions home 2 - Click Export->Copy 3 - Paste the data to a text editor 4 - Click Export->Print 5 - Note the 'Expand all...' row is included in both of the above 6 - Apply patch 7 - Repeat 8 - The row is gone from both copy and print -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116495|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116530&action=edit Bug 27653: Set messageTop to null for KohaTables This patch sets messageTop to null for KohaTables. This prevents the filter row from being included in an export. To test: 1 - Browse to acquisitions home 2 - Click Export->Copy 3 - Paste the data to a text editor 4 - Click Export->Print 5 - Note the 'Expand all...' row is included in both of the above 6 - Apply patch 7 - Repeat 8 - The row is gone from both copy and print Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116530|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 116531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116531&action=edit Bug 27653: Set messageTop to null for KohaTables This patch sets messageTop to null for KohaTables. This prevents the filter row from being included in an export. To test: 1 - Browse to acquisitions home 2 - Click Export->Copy 3 - Paste the data to a text editor 4 - Click Export->Print 5 - Note the 'Expand all...' row is included in both of the above 6 - Apply patch 7 - Repeat 8 - The row is gone from both copy and print Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I'm a little concerned about this change because the example in the test plan isn't really good HTML. We shouldn't put controls like "expand all" links into a <caption> tag because it's not semantically correct. Ideally the caption is designed to provide information about the contents of the table, so a good caption wouldn't be unwanted in a printout. We don't use <caption> very consistently, so I don't really know how often we have a situation where this patch would affect the output. But I am concerned about making this a global change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, do you have an idea, how we could set this individuallyfor those 2 tables (acq home page and funds table) or handle otherwise? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 116576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116576&action=edit Bug 27653: [Alternate] Use toolbar elements instead of captions The aqbudgets and aqui-home tables use captions for additional table controls - these are more appropriate as a toolbar To test: 1 - View the tables on acquisitions home and budgets views 2 - Note the 'Expand all...' control row 3 - Apply patch 4 - The row remains, but is above table rows 5 - The row is not included when printing or copying the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116576|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 116611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116611&action=edit Bug 27653: [Alternate] Use toolbar elements instead of captions The aqbudgets and aqui-home tables use captions for additional table controls - these are more appropriate as a DataTables custom toolbar To test: 1 - View the tables on acquisitions home and budgets views 2 - Note the 'Expand all...' control row 3 - Apply patch 4 - The row remains, but is below the table controls 5 - The row is not included when printing or copying the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116611|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 116614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116614&action=edit Bug 27653: [Alternate] Use toolbar elements instead of captions The aqbudgets and aqui-home tables use captions for additional table controls - these are more appropriate as a DataTables custom toolbar To test: 1 - View the tables on acquisitions home and budgets views 2 - Note the 'Expand all...' control row 3 - Apply patch 4 - The row remains, but is below the table controls 5 - The row is not included when printing or copying the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116615&action=edit Bug 27653: [Alternate][Alternate][Alternate] Use div instead of caption for controls The funds and acquisitions home page tables use captions for additional table controls. These are more appropriate as "toolbar" divs. This patch converts the <caption> to <div class="toolbar btn-toolbar"> and moves it just above <table> in the markup to keep it valid. To test: 1 - View the tables on acquisitions home and budgets views 2 - Note the 'Expand all...' control row 3 - Apply patch 4 - The row remains, but is below the table controls 5 - The row is not included when printing or copying the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- The row is not included when printing or copying the table but there's a display problem. The 'Expand all' control row is duplicated. Also there is extraneous data such as <<<<<<< HEAD ======= and >>>>>>> Bug 27653: [Alternate][Alternate][Alternate] Use div instead of caption for controls. I attached a screenshot of the display I got. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 --- Comment #11 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 116690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116690&action=edit Display problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Barbara Johnson from comment #11)
Created attachment 116690 [details] Display problem
Hi Barbara, these are called "merge markers" - they sometimes are visible when a patch hasn't applied correctly. I will obsolete the other alternates, maybe that will help. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116615|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 116841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116841&action=edit Bug 27653: [Alternate][Alternate][Alternate] Use div instead of caption for controls The funds and acquisitions home page tables use captions for additional table controls. These are more appropriate as "toolbar" divs. This patch converts the <caption> to <div class="toolbar btn-toolbar"> and moves it just above <table> in the markup to keep it valid. To test: 1 - View the tables on acquisitions home and budgets views 2 - Note the 'Expand all...' control row 3 - Apply patch 4 - The row remains, but is below the table controls 5 - The row is not included when printing or copying the table Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Thanks Katrin. I re-retested and everything worked great. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116841|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116864&action=edit Bug 27653: [Alternate][Alternate][Alternate] Use div instead of caption for controls The funds and acquisitions home page tables use captions for additional table controls. These are more appropriate as "toolbar" divs. This patch converts the <caption> to <div class="toolbar btn-toolbar"> and moves it just above <table> in the markup to keep it valid. To test: 1 - View the tables on acquisitions home and budgets views 2 - Note the 'Expand all...' control row 3 - Apply patch 4 - The row remains, but is below the table controls 5 - The row is not included when printing or copying the table Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Bug 27653 depends on bug 27646, which changed state. Bug 27646 Summary: Allow export of acquisitions home and funds table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27646 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency for 20.05, not backporting. If this is needed, please rebase bug 26602, thereby allowing backport of bug 27646. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in| | --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27653 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org