[Bug 29271] New: Cash register report not displaying or exporting correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Bug ID: 29271 Summary: Cash register report not displaying or exporting correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1 - Add some debits and credits to accounts 2 - Browse to Reports->Cash register 3 - Select transaction type 'All transactions' 4 - Output to screen 5 - Run report 6 - Note transaction types column is empty 7 - Output to a file 8 - Run report 9 - Open file and note: amount column is out of place extra line before total -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126498&action=edit Bug 29271: Fix cash register report results This patch changes accounts.inc to use the credit/debit type codes directly rather than needlessly fetching the credit_type/debit_type object jsut to get the code. This allows the BLOCK to work on non-object lines We also only pass a debit or credit type to csv (accountline cannot be both) empty-line.inc is also removed in favor of correcting the markup one more column added to total line To test: 1 - Add some debits and credits to accounts 2 - Browse to Reports->Cash register 3 - Select transaction type 'All transactions' 4 - Output to screen 5 - Run report 6 - Note transaction types column is empty 7 - Output to a file 8 - Run report 9 - Open file and note: amount column is out of place extra line before total 10 - Apply patch 11 - Repeat and note display and export are correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Note, this affects stables too, but they made need patches for their own version as the issues are slightly different (in 20.05 at least) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126498|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 126505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126505&action=edit Bug 29271: Fix cash register report results This patch changes accounts.inc to use the credit/debit type codes directly rather than needlessly fetching the credit_type/debit_type object jsut to get the code. This allows the BLOCK to work on non-object lines We also only pass a debit or credit type to csv (accountline cannot be both) empty-line.inc is also removed in favor of correcting the markup one more column added to total line To test: 1 - Add some debits and credits to accounts 2 - Browse to Reports->Cash register 3 - Select transaction type 'All transactions' 4 - Output to screen 5 - Run report 6 - Note transaction types column is empty 7 - Output to a file 8 - Run report 9 - Open file and note: amount column is out of place extra line before total 10 - Apply patch 11 - Repeat and note display and export are correct Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126548&action=edit Bug 29271: (QA follow-up) Add missing filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is definitely a bug fix and improvement. I notice that the table displays the descriptions of the transaction types, but the export only lists the codes. Could we switch the export to descriptions too please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126590&action=edit Bug 29271: (QA follow-up) Fetch and send descriptions to template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5)
This is definitely a bug fix and improvement. I notice that the table displays the descriptions of the transaction types, but the export only lists the codes. Could we switch the export to descriptions too please?
Done, I was wrong before, we use the objects for the case where the type is not a system defined one. This report should eventually be updated to use object, for now I just fetch the description during the SQL call for simplicity/backportability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126505|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126611&action=edit Bug 29271: Fix cash register report results This patch changes accounts.inc to use the credit/debit type codes directly rather than needlessly fetching the credit_type/debit_type object jsut to get the code. This allows the BLOCK to work on non-object lines We also only pass a debit or credit type to csv (accountline cannot be both) empty-line.inc is also removed in favor of correcting the markup one more column added to total line To test: 1 - Add some debits and credits to accounts 2 - Browse to Reports->Cash register 3 - Select transaction type 'All transactions' 4 - Output to screen 5 - Run report 6 - Note transaction types column is empty 7 - Output to a file 8 - Run report 9 - Open file and note: amount column is out of place extra line before total 10 - Apply patch 11 - Repeat and note display and export are correct Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126548|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126612&action=edit Bug 29271: (QA follow-up) Add missing filter Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126590|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126613&action=edit Bug 29271: (QA follow-up) Fetch and send descriptions to template Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This code must be moved to a module.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Caused an unexpected failure, please fix ASAP: t/db_dependent/Letters/TemplateToolkit.t .. 25/28 # Failed test 'Include used in notice' # at t/db_dependent/Letters/TemplateToolkit.t line 1120. # got: ' <span><span> (Cancelled)</span> </span>' # expected: ' <span>Payment<span> (Cancelled)</span> </span>' # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126655&action=edit Bug 29271: (follow-up) Remove changes to accounts.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13)
Caused an unexpected failure, please fix ASAP:
t/db_dependent/Letters/TemplateToolkit.t .. 25/28 # Failed test 'Include used in notice' # at t/db_dependent/Letters/TemplateToolkit.t line 1120. # got: ' <span><span> (Cancelled)</span> </span>' # expected: ' <span>Payment<span> (Cancelled)</span> </span>' # Looks like you failed 1 test of 1.
I missed a variable when undoing my changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #14)
Created attachment 126655 [details] [review] Bug 29271: (follow-up) Remove changes to accounts.inc
Pushed to master, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Conflics on 20.11.x, mainly because of Bug 16486 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28264 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28264 [Bug 28264] Transaction type is empty in cash register statistics wizard report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133084&action=edit [20.11] Bug 29271: Fix cash register report results This patch changes accounts.inc to use the credit/debit type codes directly rather than needlessly fetching the credit_type/debit_type object jsut to get the code. This allows the BLOCK to work on non-object lines We also only pass a debit or credit type to csv (accountline cannot be both) empty-line.inc is also removed in favor of correcting the markup one more column added to total line To test: 1 - Add some debits and credits to accounts 2 - Browse to Reports->Cash register 3 - Select transaction type 'All transactions' 4 - Output to screen 5 - Run report 6 - Note transaction types column is empty 7 - Output to a file 8 - Run report 9 - Open file and note: amount column is out of place extra line before total 10 - Apply patch 11 - Repeat and note display and export are correct Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133085&action=edit [20.11] Bug 29271: (QA follow-up) Add missing filter Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133086&action=edit [20.11] Bug 29271: (QA follow-up) Fetch and send descriptions to template Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133087&action=edit [20.11] Bug 29271: (follow-up) Remove changes to accounts.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tried my hand at a rebase, with it things seem to be ok in the latest 20.11.17. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Katrin. Question also in regard other branches: Is that expected that the patches add spaces? Before patch: Manager name;Patron cardnumber;Patron name;Transaction library;Transaction date;Transaction type;Notes;Amount;Title;Barcode;Item type koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;;LOST;;1.00;;; koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;;LOST;;3.00;;; koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;CREDIT;;;-343.00;;; koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;;LOST;;112.00;;; TOTAL ;;;;;;-227.00 After patch: Manager name;Patron cardnumber;Patron name;Transaction library;Transaction date;Transaction type;Notes;Amount;Title;Barcode;Item type koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;Lost item;;1.00;;; koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;Lost item;;3.00;;; koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;Credit;;-343.00;;; koha;eda;Eda Eda;Centerville;2022-04-07T00:00:00;Lost item;;112.00;;; TOTAL;;;;;;;-227.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I didn't touch that file so I'd say no. Could some '-' in the variables be missing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Could some '-' in the variables be missing?
Is that about template toolkit whitespace chomping? http://www.template-toolkit.org/docs/manual/Syntax.html#section_Chomping_Whi... Anyway, is that an issue? Can that cause issues to consume the export? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.19 released in| | --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Anyway, is that an issue?
Assuming it's not. Backported: Pushed to 20.11.x branch for 20.11.19 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #26)
Could some '-' in the variables be missing?
Is that about template toolkit whitespace chomping? http://www.template-toolkit.org/docs/manual/Syntax. html#section_Chomping_Whitespace
Anyway, is that an issue? Can that cause issues to consume the export?
Hi Victor, sorry for not getting back to you about this earlier. I assume since this also happens on the other stable branches, it would be best to fix it on a separate bug. Thx for pushing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30704 [Bug 30704] Remove whitespace added by bug 29271 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #29 from wainuiwitikapark@catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like we might be missing the line breaks when using the exports in another language - I feel like we already fixed this before? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #30)
It looks like we might be missing the line breaks when using the exports in another language - I feel like we already fixed this before?
bug 30704? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29968 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29968 [Bug 29968] CSV export of cash register misses newlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #31)
(In reply to Katrin Fischer from comment #30)
It looks like we might be missing the line breaks when using the exports in another language - I feel like we already fixed this before?
bug 30704?
Now we overlapped, actually this one is more 29968. The whitespace within the fields is another issue. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org