https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126505|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126611&action=edit Bug 29271: Fix cash register report results This patch changes accounts.inc to use the credit/debit type codes directly rather than needlessly fetching the credit_type/debit_type object jsut to get the code. This allows the BLOCK to work on non-object lines We also only pass a debit or credit type to csv (accountline cannot be both) empty-line.inc is also removed in favor of correcting the markup one more column added to total line To test: 1 - Add some debits and credits to accounts 2 - Browse to Reports->Cash register 3 - Select transaction type 'All transactions' 4 - Output to screen 5 - Run report 6 - Note transaction types column is empty 7 - Output to a file 8 - Run report 9 - Open file and note: amount column is out of place extra line before total 10 - Apply patch 11 - Repeat and note display and export are correct Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.