[Bug 17047] New: Mana webservice : share and use common information between Kohas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Bug ID: 17047 Summary: Mana webservice : share and use common information between Kohas Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: morgane.alonso@biblibre.com QA Contact: testopia@bugs.koha-community.org RFC : https://wiki.koha-community.org/wiki/SharingDatasBetweenKohas_rfc Progress of the Mana features : https://wiki.koha-community.org/wiki/Mana_central_database -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #1 from alonso morgane <morgane.alonso@biblibre.com> --- Code : Server source code : http://git.biblibre.com/biblibre/koha-mana Client source code integrated in Koha : http://git.biblibre.com/biblibre/kohac/commits/koha-mana -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17045 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16994 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 alonso morgane <morgane.alonso@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |morgane.alonso@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Alonso, Just glancing a little bit thru your Koha code, I see you introduce Koha::Branch. Did you see Koha::Library already? Confusingly true :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quick code review: 1/ The default value for the new pref should be "off" 2/ Tabulation chars should be replaced with 4 tabs 3/ $tmp is rarely a correct variable name :) 4/ Additional fields are displayed (but not taken into account) on the mana subscriptions search form 5/ The Koha::Branch[es] should not be added, use Koha::Librar[y|ies] instead 6/ Share> "Language of your sharing" is hidden on the right. 7/ "The export is done, thank you for your contribution." => It should not be yellow (alert) but green (message) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
2/ Tabulation chars should be replaced with 4 tabs
Hope that this is not a recursive rule.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #4)
2/ Tabulation chars should be replaced with 4 tabs
Hope that this is not a recursive rule..
It is a rule for all new files added to Koha and for all changed lines in patches. https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #6 from alonso morgane <morgane.alonso@biblibre.com> --- (In reply to Marcel de Rooy from comment #2)
Hi Alonso, Just glancing a little bit thru your Koha code, I see you introduce Koha::Branch. Did you see Koha::Library already? Confusingly true :)
Hi Marcel de Rooy, I don't see it, sorry! I'll change that and use the right Koha object. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #7 from alonso morgane <morgane.alonso@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
Quick code review:
1/ The default value for the new pref should be "off"
2/ Tabulation chars should be replaced with 4 tabs
3/ $tmp is rarely a correct variable name :)
4/ Additional fields are displayed (but not taken into account) on the mana subscriptions search form
5/ The Koha::Branch[es] should not be added, use Koha::Librar[y|ies] instead
6/ Share> "Language of your sharing" is hidden on the right.
7/ "The export is done, thank you for your contribution." => It should not be yellow (alert) but green (message)
1/ Paul says that it's better to have "on" in default value to promote the use of Mana (he'll discuss about it later) 2/3/7/ I'll clean my code 4/ the flied "deprecated" is not used yet because I didn't have the time to code the comment feature where librarians can say if a model is deprecated. I can remove the flied if you prefer. 5/ I'll do that 6/ Fixed Thanks for all your comments! I will do my best to apply them all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For features like this that have you communicate with an external server should definitely turned off by default in my opinion. You can promote in other ways. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 56175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56175&action=edit Bug 17047 add mana syspref Add the system preference to enable or disable mana webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #10 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 56176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56176&action=edit Bug 17047 add frequencies and numberpattern in subscription class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #11 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 56177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56177&action=edit Bug 17047 ability to search subscription model on mana - add a class SharedContent.pm to communicate with mana server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for mana - create datatable in mana-subscription-search-result.inc to show results from a research on mana - modify serials-search.pl to manage research on mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #12 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 56178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56178&action=edit Bug 17047 ability to share a subscription to mana - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a mana subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #13 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 56179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56179&action=edit Bug 17047 ability to import a subscription model from mana - modify subscription-add.tt and subscription.pl to manage a import from mana during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with mana server during a asubscription creation - add a function in Subscription.pm to have all the info for a mana research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from mana server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #14 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 56180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56180&action=edit Bug 17047 Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #15 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 56181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56181&action=edit Bug 17047 - Use Koha::Libraries instead of GetBranches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #16 from Alex Arnaud <alex.arnaud@biblibre.com> --- Here is a test plan: - Install and run a Mana server as described in the README file: http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md, - apply this patch on Koha, - change the $MANA_IP variable in Koha/SharedContent.pm with the one used by your Mana server (may be http://localhost:5000 for a local instance), - go to a subscription detail page (cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=xx) and click on the share button in the toolbar. - check that the subscription has been recorded in the Mana database (subscription table), - in Koha, remove this subscription and the related frequency and numbering pattern, - go to the biblio detail page of the related deleted subscription (cgi-bin/koha/catalogue/detail.pl?biblionumber=xx), - click on New -> new subscription in the toolbar - click on next on the first step form. On the second step you should get the message: " Frequency and Numbering pattern have been already proposed for this subscription on Mana [...]", - click on "here", choose the subscription (Use) and finish the new subscription. - check that the subscription has been created with the corresponding frequency and numbering pattern. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is it ready for testing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #18 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 59728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59728&action=edit Bug 17047 - Don't create numberpattern if the same exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #19 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 59729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59729&action=edit Bug 17047 - Remove action column from mana search result table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #20 from Alex Arnaud <alex.arnaud@biblibre.com> --- Remember, test plan is here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047#c16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #21 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 59931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59931&action=edit Bug 17047 - Don't show action column (use link) on mana search page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Summary|Mana webservice : share and |Mana Knowledge Base : share |use common information |data |between Kohas | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #22 from David Cook <dcook@prosentient.com.au> --- (In reply to morgane alonso from comment #0)
RFC : https://wiki.koha-community.org/wiki/SharingDatasBetweenKohas_rfc
Progress of the Mana features : https://wiki.koha-community.org/wiki/Mana_central_database
One question... why is it "Statistics management" and not "Reports management"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> --- Hi David, I think that we use the "reports" word on the code, the term "statistic" is used only on the RFC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #24 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 61905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61905&action=edit Bug 17047: Add report, factorize code, add a comment feature Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redisigned to improve the user experience - New Feature : report a record. - peoples can now report a weird report - if a record is reported a lot of time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - Added the syspref "AutoShareWithMana", which enables to select which fields you want to share automatically with mana API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) - Factorize a lot of code in order to improve the speed of next developments SytemPreferences: Mana Activation: - add a field "no, let me think" at the syspref "Mana" - as long as this field is selected, messages ask if user want to activate it messages in pages: - Administration - Add-subscription(page 2) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set) Report Share - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana - New feature: search report in Mana Knowledge Base with keywords - New feature: load reports from Mana Comment Resources - The comments can now be manually added - On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent - Comments are NOT dynamically generated on the table you need to reload the page when you vote Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56175|0 |1 is obsolete| | Attachment #56176|0 |1 is obsolete| | Attachment #56177|0 |1 is obsolete| | Attachment #56178|0 |1 is obsolete| | Attachment #56179|0 |1 is obsolete| | Attachment #56180|0 |1 is obsolete| | Attachment #56181|0 |1 is obsolete| | Attachment #59728|0 |1 is obsolete| | Attachment #59931|0 |1 is obsolete| | Attachment #61905|0 |1 is obsolete| | --- Comment #25 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62045&action=edit Bug 17047 add mana syspref Add the system preference to enable or disable mana webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #26 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62046&action=edit Bug 17047 add frequencies and numberpattern in subscription class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #27 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62047&action=edit Bug 17047 ability to search subscription model on mana - add a class SharedContent.pm to communicate with mana server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for mana - create datatable in mana-subscription-search-result.inc to show results from a research on mana - modify serials-search.pl to manage research on mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #28 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62048&action=edit Bug 17047 ability to share a subscription to mana - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a mana subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #29 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62049&action=edit Bug 17047 ability to import a subscription model from mana - modify subscription-add.tt and subscription.pl to manage a import from mana during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with mana server during a asubscription creation - add a function in Subscription.pm to have all the info for a mana research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from mana server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #30 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62050&action=edit Bug 17047 Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #31 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62051&action=edit Bug 17047 - Use Koha::Libraries instead of GetBranches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #32 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62052&action=edit Bug 17047 - Don't create numberpattern if the same exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #33 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62053&action=edit Bug 17047 - Don't show action column (use link) on mana search page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #34 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62054&action=edit Bug 17047: Add report, factorize code, add a comment feature Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redisigned to improve the user experience - New Feature : report a record. - peoples can now report a weird report - if a record is reported a lot of time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - Added the syspref "AutoShareWithMana", which enables to select which fields you want to share automatically with mana API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) - Factorize a lot of code in order to improve the speed of next developments SytemPreferences: Mana Activation: - add a field "no, let me think" at the syspref "Mana" - as long as this field is selected, messages ask if user want to activate it messages in pages: - Administration - Add-subscription(page 2) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set) Report Share - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana - New feature: search report in Mana Knowledge Base with keywords - New feature: load reports from Mana Comment Resources - The comments can now be manually added - On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent - Comments are NOT dynamically generated on the table you need to reload the page when you vote Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #35 from Paul Poulain <paul.poulain@biblibre.com> --- Verified that, with mana OFF, nothing changes & Koha still working : * SQL => everything is OK * subscriptions => ERROR On the logs I see: Use of uninitialized value $loggedinuser in string ne at /home/koha/src/Koha/SharedContent.pm line 89. Can't call method "email" on an undefined value at /home/koha/src/Koha/SharedContent.pm line 91. Some QA comments: * patch description : "2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml" => not very clear. Better "copy in your koha-conf.xml the 3 lines about mana configuration the 3 lines you'll find in $KOHA_SRC/etc/koha-conf.xml" * some "+# Copyright ByWater Solutions 2015" => Yikes, it's Biblibre 2017, not ByWater 2015 ;-) * Not sure we should use Koha/Reports.pm & Report.pm. Why not something related to Mana (ie: Koha/Mana/Reports.pm, Koha/Mana/Reports.pm) [this is a question] * Some "+# Copyright 2016 BibLibre Morgane Alonso" => you're Baptiste, not Morgane (and we're now 2017) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Paul Poulain from comment #35)
* Not sure we should use Koha/Reports.pm & Report.pm. Why not something related to Mana (ie: Koha/Mana/Reports.pm, Koha/Mana/Reports.pm) [this is a question]
They make sense to me, they are related to the (badly named) table saved_sql
* Some "+# Copyright 2016 BibLibre Morgane Alonso" => you're Baptiste, not Morgane (and we're now 2017)
After a very quick look at the code it seems that it is some code written by Morgane and moved by Baptiste, sounds right to keep it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62054|0 |1 is obsolete| | --- Comment #37 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62075&action=edit Bug 17047: Add report, factorize code, add a comment feature Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redisigned to improve the user experience - New Feature : report a record. - peoples can now report a weird report - if a record is reported a lot of time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - Added the syspref "AutoShareWithMana", which enables to select which fields you want to share automatically with mana API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) - Factorize a lot of code in order to improve the speed of next developments SytemPreferences: Mana Activation: - add a field "no, let me think" at the syspref "Mana" - as long as this field is selected, messages ask if user want to activate it messages in pages: - Administration - Add-subscription(page 2) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set) Report Share - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana - New feature: search report in Mana Knowledge Base with keywords - New feature: load reports from Mana Comment Resources - The comments can now be manually added - On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent - Comments are NOT dynamically generated on the table you need to reload the page when you vote Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #38 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62465&action=edit Bug 17047: Add security token against spam, Rework messages from Mana. - A syspref contains an authentication token - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages ar now correctly displayed and there shouldn't be any crash when mana answer wrong/doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click on other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. - If to a result has been reported a lot (>5, >10 and >15), it should appear differently 8 - For each precedent test, try to send wrong datas, to delete the security token, to send nothing: it should send you a propper message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62465|0 |1 is obsolete| | --- Comment #39 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62475&action=edit Bug 17047: Add security token against spam, Rework messages from Mana. - A syspref contains an authentication token - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages ar now correctly displayed and there shouldn't be any crash when mana answer wrong/doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click on other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. - If to a result has been reported a lot (>5, >10 and >15), it should appear differently 8 - For each precedent test, try to send wrong datas, to delete the security token, to send nothing: it should send you a propper message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62475|0 |1 is obsolete| | --- Comment #40 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62485&action=edit Bug 17047: Add security token against spam, Rework messages from Mana. - A syspref contains an authentication token - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages ar now correctly displayed and there shouldn't be any crash when mana answer wrong/doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click on other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. - If to a result has been reported a lot (>5, >10 and >15), it should appear differently 8 - For each precedent test, try to send wrong datas, to delete the security token, to send nothing: it should send you a propper message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #41 from Paul Poulain <paul.poulain@biblibre.com> --- Extensive testing : == Mana set to "No, let me think about it" == * subscriptions => no change, still working: - The subscription add says "You haven't activated the Mana Knowledge Base, click here to configure." as expected - add OK - view OK * sql reports => no change, still working (nothing related to mana visible) => OK == Mana set to OFF == * subscriptions => no change, still working * sql reports => no change, still working => OK == Mana set to ON == * AutoShare = nothing * I create a token for Mana by entering my firstname, lastname, email. I receive the email and can validate the token by clicking on the link in the email === Testing subscriptions === * I create a subscription => OK * I see the button "share" after validating creation * hitting "share" button, I get a confirmation box and a "thanks for sharing" message once I've confirmed * I create a new subscription, on the same biblio. - when reaching the 2nd screen of subscription-add, I see the box "something found in mana, quick fill". I select "quick fill", and select the subscription displayed. - the pattern & periodicity are now filled - I validate the subscription-add => OK I've also verified that, as the pattern & frequency already exist, they're not duplicated, the existing ones are used. === Testing SQL reports === * trying to share a report - go to SQL report - in the actions list (on the right), I see the option "share" - I click on "share", a popup appear asking me to enter more than 20 chars in name and description to enable sharing => OK - I update the name & description, hit "share" again - I validate the sharing * trying to retrieve a shared report - go to guided-reports page - hit the Quick search link on "You want more reports? Check the Mana Knowledge Base " - search what I've shared - click "use" - nothing visible happen. After talking with Baptiste, there's no redirect to the report that has been derived from Mana-KB. Baptiste will send a follow-up ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #42 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62540&action=edit Bug 17047: minor corrections on report share - Use a report now redirects on the created report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62045|0 |1 is obsolete| | Attachment #62046|0 |1 is obsolete| | Attachment #62047|0 |1 is obsolete| | Attachment #62048|0 |1 is obsolete| | Attachment #62049|0 |1 is obsolete| | Attachment #62050|0 |1 is obsolete| | Attachment #62051|0 |1 is obsolete| | Attachment #62052|0 |1 is obsolete| | Attachment #62053|0 |1 is obsolete| | Attachment #62075|0 |1 is obsolete| | Attachment #62485|0 |1 is obsolete| | Attachment #62540|0 |1 is obsolete| | --- Comment #43 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62542&action=edit Bug 17047 add mana syspref Add the system preference to enable or disable mana webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #44 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62543&action=edit Bug 17047 add frequencies and numberpattern in subscription class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #45 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62544&action=edit Bug 17047 ability to search subscription model on mana - add a class SharedContent.pm to communicate with mana server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for mana - create datatable in mana-subscription-search-result.inc to show results from a research on mana - modify serials-search.pl to manage research on mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #46 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62545&action=edit Bug 17047 ability to share a subscription to mana - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a mana subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #47 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62546&action=edit Bug 17047 ability to import a subscription model from mana - modify subscription-add.tt and subscription.pl to manage a import from mana during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with mana server during a asubscription creation - add a function in Subscription.pm to have all the info for a mana research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from mana server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #48 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62547&action=edit Bug 17047 Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #49 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62548&action=edit Bug 17047 - Use Koha::Libraries instead of GetBranches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #50 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62549&action=edit Bug 17047 - Don't create numberpattern if the same exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #51 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62550&action=edit Bug 17047 - Don't show action column (use link) on mana search page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #52 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62551&action=edit Bug 17047: Add report, factorize code, add a comment feature Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redisigned to improve the user experience - New Feature : report a record. - peoples can now report a weird report - if a record is reported a lot of time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - Added the syspref "AutoShareWithMana", which enables to select which fields you want to share automatically with mana API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) - Factorize a lot of code in order to improve the speed of next developments SytemPreferences: Mana Activation: - add a field "no, let me think" at the syspref "Mana" - as long as this field is selected, messages ask if user want to activate it messages in pages: - Administration - Add-subscription(page 2) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set) Report Share - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana - New feature: search report in Mana Knowledge Base with keywords - New feature: load reports from Mana Comment Resources - The comments can now be manually added - On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent - Comments are NOT dynamically generated on the table you need to reload the page when you vote Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #53 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62552&action=edit Bug 17047: Add security token against spam, Rework messages from Mana. - A syspref contains an authentication token - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages ar now correctly displayed and there shouldn't be any crash when mana answer wrong/doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click on other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. - If to a result has been reported a lot (>5, >10 and >15), it should appear differently 8 - For each precedent test, try to send wrong datas, to delete the security token, to send nothing: it should send you a propper message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #54 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62553&action=edit Bug 17047: minor corrections on report share -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #55 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 62589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62589&action=edit Bug 17047: Add report_group as shared attribute -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Assignee|morgane.alonso@biblibre.com |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62542|0 |1 is obsolete| | --- Comment #56 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62591&action=edit Bug 17047 add mana syspref Add the system preference to enable or disable mana webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62543|0 |1 is obsolete| | --- Comment #57 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62592&action=edit Bug 17047 add frequencies and numberpattern in subscription class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62544|0 |1 is obsolete| | Attachment #62545|0 |1 is obsolete| | Attachment #62546|0 |1 is obsolete| | Attachment #62547|0 |1 is obsolete| | Attachment #62548|0 |1 is obsolete| | Attachment #62549|0 |1 is obsolete| | Attachment #62550|0 |1 is obsolete| | Attachment #62551|0 |1 is obsolete| | Attachment #62552|0 |1 is obsolete| | Attachment #62553|0 |1 is obsolete| | Attachment #62589|0 |1 is obsolete| | --- Comment #58 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62593&action=edit Bug 17047 ability to search subscription model on mana - add a class SharedContent.pm to communicate with mana server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for mana - create datatable in mana-subscription-search-result.inc to show results from a research on mana - modify serials-search.pl to manage research on mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #59 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62594&action=edit Bug 17047 ability to share a subscription to mana - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a mana subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #60 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62595&action=edit Bug 17047 ability to import a subscription model from mana - modify subscription-add.tt and subscription.pl to manage a import from mana during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with mana server during a asubscription creation - add a function in Subscription.pm to have all the info for a mana research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from mana server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #61 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62596&action=edit Bug 17047 - Don't create numberpattern if the same exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #62 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62597&action=edit Bug 17047 Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #63 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62598&action=edit Bug 17047: Add report, factorize code, add a comment feature Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redisigned to improve the user experience - New Feature : report a record. - peoples can now report a weird report - if a record is reported a lot of time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - Added the syspref "AutoShareWithMana", which enables to select which fields you want to share automatically with mana API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) - Factorize a lot of code in order to improve the speed of next developments SytemPreferences: Mana Activation: - add a field "no, let me think" at the syspref "Mana" - as long as this field is selected, messages ask if user want to activate it messages in pages: - Administration - Add-subscription(page 2) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set) Report Share - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana - New feature: search report in Mana Knowledge Base with keywords - New feature: load reports from Mana Comment Resources - The comments can now be manually added - On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent - Comments are NOT dynamically generated on the table you need to reload the page when you vote Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #64 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62599&action=edit Bug 17047: Add security token against spam, Rework messages from Mana. - A syspref contains an authentication token - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages ar now correctly displayed and there shouldn't be any crash when mana answer wrong/doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => mana shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Comments. - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other". - If you click on other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. - If to a result has been reported a lot (>5, >10 and >15), it should appear differently 8 - For each precedent test, try to send wrong datas, to delete the security token, to send nothing: it should send you a propper message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62591|0 |1 is obsolete| | Attachment #62592|0 |1 is obsolete| | Attachment #62593|0 |1 is obsolete| | Attachment #62594|0 |1 is obsolete| | Attachment #62595|0 |1 is obsolete| | Attachment #62596|0 |1 is obsolete| | Attachment #62597|0 |1 is obsolete| | Attachment #62598|0 |1 is obsolete| | Attachment #62599|0 |1 is obsolete| | --- Comment #65 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62603&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #66 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62604&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #67 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62605&action=edit Bug 17047 Mana-KB, Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #68 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62606&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #69 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62607&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #70 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 62768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62768&action=edit Mana-KB documentation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62607|0 |1 is obsolete| | --- Comment #71 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63476&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 [Bug 18618] Mana - Add reading suggestions (crontab - scripts) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #72 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63601&action=edit Bug 17047: Correct encoding issues Modify the function manaRequest in order to set the right encoding format (UTF-8). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |josef.moravec@gmail.com --- Comment #73 from Josef Moravec <josef.moravec@gmail.com> --- Could you rebase please? I am getting: fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17047 SQL reports management with Mana-KB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62603|0 |1 is obsolete| | --- Comment #74 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63618&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62604|0 |1 is obsolete| | --- Comment #75 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63619&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62605|0 |1 is obsolete| | --- Comment #76 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63620&action=edit Bug 17047 Mana-KB, Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62606|0 |1 is obsolete| | --- Comment #77 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63621&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63476|0 |1 is obsolete| | --- Comment #78 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63622&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63601|0 |1 is obsolete| | --- Comment #79 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 63623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63623&action=edit Bug 17047: Correct encoding issues Modify the function manaRequest in order to set the right encoding format (UTF-8). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #80 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Hum.. it tried to rebase it but it applyied without any problem.. I just reuploadad it, could you please try again ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #81 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Baptiste from comment #80)
Hum.. it tried to rebase it but it applyied without any problem..
I just reuploadad it, could you please try again ?
Now it applies, I had to do something wrong... anyway, going to test it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #82 from Brendan Gallagher <brendan@bywatersolutions.com> --- Had some trouble applying it. Can you rebase - I think it's an easy one in koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #83 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64484&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64484|0 |1 is obsolete| | --- Comment #84 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64530&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #85 from Brendan Gallagher <brendan@bywatersolutions.com> --- It's still not applying cleanly for me. I would love to sign off on this and get it towards the next step! If I sign off on it - I'll start begging for some QAers. I'm using the latest version of kohadevbox - maybe try applying it there and rebasing this? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #86 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Hi ! It is on my todo list, I'll rebase it soon, take a bit time cause it concerns tests I didn't change by myself and I'm not pretty sure ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63618|0 |1 is obsolete| | --- Comment #87 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64618&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63619|0 |1 is obsolete| | --- Comment #88 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64619&action=edit Bug 17047: subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63620|0 |1 is obsolete| | --- Comment #89 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64620&action=edit Bug 17047 Mana-KB, Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63621|0 |1 is obsolete| | --- Comment #90 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64621&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63622|0 |1 is obsolete| | --- Comment #91 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64622&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63623|0 |1 is obsolete| | --- Comment #92 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64623&action=edit Bug 17047: Correct encoding issues Modify the function manaRequest in order to set the right encoding format (UTF-8). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64530|0 |1 is obsolete| | --- Comment #93 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64624&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #94 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64618|0 |1 is obsolete| | --- Comment #95 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64625&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #96 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64626&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64620|0 |1 is obsolete| | --- Comment #97 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64627&action=edit Bug 17047 Mana-KB, Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64621|0 |1 is obsolete| | --- Comment #98 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64628&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64622|0 |1 is obsolete| | --- Comment #99 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64629&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #100 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64630&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64623|0 |1 is obsolete| | --- Comment #101 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64631&action=edit Bug 17047: Correct encoding issues Modify the function manaRequest in order to set the right encoding format (UTF-8). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64624|0 |1 is obsolete| | --- Comment #102 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64632&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64619|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64626|0 |1 is obsolete| | --- Comment #103 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64633&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64625|0 |1 is obsolete| | --- Comment #104 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64634&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64633|0 |1 is obsolete| | --- Comment #105 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64635&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64634|0 |1 is obsolete| | --- Comment #106 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64636&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64635|0 |1 is obsolete| | --- Comment #107 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64637&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64627|0 |1 is obsolete| | --- Comment #108 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64638&action=edit Bug 17047 Mana-KB, Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64628|0 |1 is obsolete| | --- Comment #109 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64639&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64629|0 |1 is obsolete| | Attachment #64630|0 |1 is obsolete| | --- Comment #110 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64640&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #111 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64641&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64631|0 |1 is obsolete| | --- Comment #112 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64642&action=edit Bug 17047: Correct encoding issues Modify the function manaRequest in order to set the right encoding format (UTF-8). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64632|0 |1 is obsolete| | --- Comment #113 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64643&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #114 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Correctly rebased on Master this time (I hope so) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64636|0 |1 is obsolete| | --- Comment #115 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64648&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64637|0 |1 is obsolete| | --- Comment #116 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64649&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64638|0 |1 is obsolete| | --- Comment #117 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64650&action=edit Bug 17047 Mana-KB, Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64639|0 |1 is obsolete| | --- Comment #118 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64651&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64640|0 |1 is obsolete| | Attachment #64641|0 |1 is obsolete| | --- Comment #119 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64652&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64642|0 |1 is obsolete| | --- Comment #120 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64653&action=edit Bug 17047: Correct encoding issues Modify the function manaRequest in order to set the right encoding format (UTF-8). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64643|0 |1 is obsolete| | --- Comment #121 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64654&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64654|0 |1 is obsolete| | --- Comment #122 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64706&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18922 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 [Bug 18922] Mana - Share review -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #123 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64962&action=edit Bug 17047: Minor changes - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #124 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Whilst going through this http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md to install Mana I run the following command: plackup -r -R lib -E production bin/app.psgi And I get the following output: Error while loading /home/vagrant/kohaclone/koha-mana/bin/app.psgi: Can't locate Dancer2/Plugin/REST.pm in @INC (you may need to install the Dancer2::Plugin::REST module) (@INC contains: /home/vagrant/kohaclone/koha-mana/bin/../lib ~/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /home/vagrant/kohaclone/koha-mana/bin/../lib/Mana.pm line 8. I try to install the Dancer2/Plugin/REST package using the command: sudo apt-get install libdancer2-plugin-rest-perl However the package cannot be found. I have tried many different variations of the name without any success (and I cannot find any help with this online) therefore can someone please inform me of the correct command to install the Dancer2/Plugin/REST package? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64648|0 |1 is obsolete| | --- Comment #125 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65058&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64649|0 |1 is obsolete| | --- Comment #126 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65059&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64650|0 |1 is obsolete| | --- Comment #127 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65060&action=edit Bug 17047 Mana-KB, Add unit tests Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64651|0 |1 is obsolete| | --- Comment #128 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65061&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64652|0 |1 is obsolete| | --- Comment #129 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65062&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64653|0 |1 is obsolete| | --- Comment #130 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65063&action=edit Bug 17047: Correct encoding issues Modify the function manaRequest in order to set the right encoding format (UTF-8). Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64706|0 |1 is obsolete| | Attachment #64962|0 |1 is obsolete| | --- Comment #131 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65064&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #132 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 65065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65065&action=edit Bug 17047: Minor changes - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #133 from Brendan Gallagher <brendan@bywatersolutions.com> --- I am getting some errors. I will fill this out later - in a rush at the moment. Giving presentation on this in a few minutes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #134 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65773&action=edit Bug 17047 [QA Followup] - Misc minor fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #135 from Brendan Gallagher <brendan@bywatersolutions.com> --- The "use" button for grabbing a report from the search results of the mana reports - did not work. when creating a new serial subscription it was not able to complete - it threw an error. Searching serials in mana did not return any results. just a blank status code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #136 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Brendan Gallagher from comment #135)
The "use" button for grabbing a report from the search results of the mana reports - did not work. It works for me. Can you check you have the column saved_sql.mana_id ? It may be an updatedatabase issue.
when creating a new serial subscription it was not able to complete - it threw an error.
Patch is coming.
Searching serials in mana did not return any results. just a blank status code.
Patch is coming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #137 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 66667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66667&action=edit Bug 17047 - Fix an error when cretaing subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #138 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 66668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66668&action=edit Bug 17047 - Fix mana search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #139 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66987&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66987|0 |1 is obsolete| | --- Comment #140 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67003&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #141 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67004&action=edit Bug 17047 [QA Followup] - Fix up database schema change, add to kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #142 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67005&action=edit Bug 17047 [QA Followup] - Update schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #143 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67006&action=edit Bug 17047 [QA Followup] - Remove javascript debugger call -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65058|0 |1 is obsolete| | Attachment #65059|0 |1 is obsolete| | Attachment #65060|0 |1 is obsolete| | Attachment #65061|0 |1 is obsolete| | Attachment #65062|0 |1 is obsolete| | Attachment #65063|0 |1 is obsolete| | Attachment #65064|0 |1 is obsolete| | Attachment #65065|0 |1 is obsolete| | Attachment #65773|0 |1 is obsolete| | Attachment #66667|0 |1 is obsolete| | Attachment #66668|0 |1 is obsolete| | Attachment #67003|0 |1 is obsolete| | Attachment #67004|0 |1 is obsolete| | Attachment #67005|0 |1 is obsolete| | Attachment #67006|0 |1 is obsolete| | --- Comment #144 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67009&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #145 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67010&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #146 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67011&action=edit Bug 17047 Mana-KB, Add unit tests Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #147 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67012&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #148 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67013&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #149 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67014&action=edit Bug 17047: Correct encoding issues Modify the function manaRequest in order to set the right encoding format (UTF-8). Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #150 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67015&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #151 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67016&action=edit Bug 17047: Minor changes - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #152 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67017&action=edit Bug 17047 [QA Followup] - Misc minor fixes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #153 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67018&action=edit Bug 17047 - Fix an error when cretaing subscription Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #154 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67019&action=edit Bug 17047 - Fix mana search Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #155 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67020&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #156 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67021&action=edit Bug 17047 [QA Followup] - Fix up database schema change, add to kohastructure.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #157 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67022&action=edit Bug 17047 [QA Followup] - Update schema files Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #158 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67023&action=edit Bug 17047 [QA Followup] - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #159 from Kyle M Hall <kyle@bywatersolutions.com> --- QA Notes: 1) Interface is a bit rough around the edges. Could probably use some Owen magic to clean it up ; ) 2) It appears that the whitespace/newlines on reports are not preserved correctly. It would be nice to keep the original formatting of shared reports instead of the long run-on queries that result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #160 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi I am in the process of testing bug 18618 on kohadevbox and I installed the Mana server by following the steps outlined here: http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md I then applied the patches attached to bug 17047, changed the $MANA_IP address to http://localhost:5000 because I am using a local instance Mana server. Then when I tried to submit the form for creating a Mana token, the form is not returning a security token instead it is returning the following error when I display the outcome of the result js object in activatemana.js: ({msg:"An error occurred, mana server returned: URL must be absolute", code:400}) Does anyone have idea as to the reason why the /cgi-bin/koha/svc/mana/getToken is not successfully returning a security token? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #161 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Alex Buckley from comment #160)
Does anyone have idea as to the reason why the /cgi-bin/koha/svc/mana/getToken is not successfully returning a security token?
This needs an answer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #162 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Quick code review: 1/ Please squash patches when possible to ease readability 2/ Some strings are not translatable (at least "Subscription found on Mana Knowledge Base") 3/ Please fix indentation 4/ Remove use of onclick attribute 5/ - [% INCLUDE 'serials-toolbar.inc' %] + [% INCLUDE 'serials-toolbar.inc' mana_id = mana_id %] Not sure it is needed 6/ + 'mana_success' => $input->param('mana_success'), CGI->param raises warning called in list context (there are other occurrences) 7/ subroutines added in serials/subscription-add.pl smell 8/ serials/subscription-add.pl + my $mana_id; + if ( $query->param('mana_id') ne "" ) { + $mana_id = $query->param('mana_id'); + Koha::SharedContent::manaIncrementRequest("subscription",$mana_id, "nbofusers"); + } + else { + $mana_id = undef; + } => the else block is useless 9/ Too many "use" statements in serials/subscription-detail.pl 10/ script names in svc/mana are not consistent 11/ +my $templatename; +$templatename = "mana/mana-".$input->param( "resource" )."-search-result.tt"; That smells too. There are only 2 files, list them (same for other occurrences). 12/ Test coverage for Koha::SharedContent is nonexistent 13/ Why tests have been removed from t/db_dependent/Serials/GetFictiveIssueNumber.t 14/ No reference of mana_config from debian/templates/koha-conf-site.xml.in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #163 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 15/ hide_marc appears twice in sysprefs.sql 16/ CDATA close tag removed from guided_reports_start.tt, looks wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #164 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- How can we open issue on http://git.biblibre.com/biblibre/koha-mana I'd like a more complete README to run the server and the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67009|0 |1 is obsolete| | Attachment #67010|0 |1 is obsolete| | Attachment #67011|0 |1 is obsolete| | Attachment #67012|0 |1 is obsolete| | Attachment #67013|0 |1 is obsolete| | Attachment #67014|0 |1 is obsolete| | Attachment #67015|0 |1 is obsolete| | Attachment #67016|0 |1 is obsolete| | Attachment #67017|0 |1 is obsolete| | Attachment #67018|0 |1 is obsolete| | Attachment #67019|0 |1 is obsolete| | Attachment #67020|0 |1 is obsolete| | Attachment #67021|0 |1 is obsolete| | Attachment #67022|0 |1 is obsolete| | Attachment #67023|0 |1 is obsolete| | --- Comment #165 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69034&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #166 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69035&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #167 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69036&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #168 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69037&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #169 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69038&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #170 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69039&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #171 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69040&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69040|0 |1 is obsolete| | --- Comment #172 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69041&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #173 from Brendan Gallagher <brendan@bywatersolutions.com> --- Alex should this be set back to "signed qa" or even "passed qa"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #174 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Brendan Gallagher from comment #173)
Alex should this be set back to "signed qa" or even "passed qa"?
Hello Brendan. Sorry no. Here is a QA fix. I have to do some code refacto and fonctional changes (moving the comment feature from the mana results table) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #175 from Alex Arnaud <alex.arnaud@biblibre.com> --- Also, unit tests are missing for Koha::Subscription::Numberpatterns::new_or_existing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #176 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69091&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #177 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Can I get an answer to my comments 162-164? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nick@bywatersolutions.com --- Comment #178 from Nick Clemens <nick@bywatersolutions.com> --- Can you rebase please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69034|0 |1 is obsolete| | --- Comment #179 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70203&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69035|0 |1 is obsolete| | --- Comment #180 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70204&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69036|0 |1 is obsolete| | --- Comment #181 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70205&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69037|0 |1 is obsolete| | --- Comment #182 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70206&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69038|0 |1 is obsolete| | --- Comment #183 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70208&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69039|0 |1 is obsolete| | --- Comment #184 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70209&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69041|0 |1 is obsolete| | --- Comment #185 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70210&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69091|0 |1 is obsolete| | --- Comment #186 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70211&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #187 from Nick Clemens <nick@bywatersolutions.com> --- Tried testing, seems to be some issues: 1 - Template code in subscription-add.js file breaks serial biblio search: 620 //[% IF Koha.Preference('Mana') == 1 %] 2 - When I attempt to save a serial: Variable "$loggedinuser" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 371. Variable "$template" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 372. Variable "$loggedinuser" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 371. Variable "$template" is not available at /home/vagrant/kohaclone/serials/subscription-add.pl line 372. Can't use string ("koha_login_context") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/Koha/Subscription/Numberpatterns.pm line 63. 3 - Blank modal when attempting to share report with no notes 4 - Internal server error when trying to share a new report with notes: Use of uninitialized value $loggedinuser in string ne at /home/vagrant/kohaclone/Koha/SharedContent.pm line 106. Can't call method "first_valid_email_address" on an undefined value at /home/vagrant/kohaclone/Koha/SharedContent.pm line 108. I stopped testing at this point -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #188 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70561&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #189 from Hugo Agud <hagud@orex.es> --- I have applied the patch propertly, but I am not able to make the local mana server work.. I follow all instructions. I have installed in a kohadev server, I had to install manual via cpan some of the perl packages, everything seems to goes fine.. but on localhost:5000 nothing appears.. is that the normal behaviour? PID/Program name tcp 0 0 0.0.0.0:5000 0.0.0.0:* LISTEN 2814/plackup tcp 0 0 127.0.0.1:3306 0.0.0.0:* LISTEN - tcp 0 0 127.0.0.1:11211 0.0.0.0:* LISTEN - tcp 0 0 0.0.0.0:111 0.0.0.0:* LISTEN - tcp 0 0 0.0.0.0:45397 0.0.0.0:* LISTEN - tcp 0 0 0.0.0.0:22 0.0.0.0:* LISTEN - tcp 0 0 127.0.0.1:25 0.0.0.0:* LISTEN - tcp6 0 0 :::41475 :::* LISTEN - tcp6 0 0 :::111 :::* LISTEN - tcp6 0 0 :::8080 :::* LISTEN - tcp6 0 0 :::80 :::* LISTEN - tcp6 0 0 :::22 :::* LISTEN - tcp6 0 0 ::1:25 :::* LISTEN - -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #190 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Hugo Agud from comment #189)
I have applied the patch propertly, but I am not able to make the local mana server work.. I follow all instructions.
I have installed in a kohadev server, I had to install manual via cpan some of the perl packages, everything seems to goes fine.. but on localhost:5000 nothing appears.. is that the normal behaviour?
PID/Program name tcp 0 0 0.0.0.0:5000 0.0.0.0:* LISTEN 2814/plackup tcp 0 0 127.0.0.1:3306 0.0.0.0:* LISTEN - tcp 0 0 127.0.0.1:11211 0.0.0.0:* LISTEN - tcp 0 0 0.0.0.0:111 0.0.0.0:* LISTEN - tcp 0 0 0.0.0.0:45397 0.0.0.0:* LISTEN - tcp 0 0 0.0.0.0:22 0.0.0.0:* LISTEN - tcp 0 0 127.0.0.1:25 0.0.0.0:* LISTEN - tcp6 0 0 :::41475 :::* LISTEN - tcp6 0 0 :::111 :::* LISTEN - tcp6 0 0 :::8080 :::* LISTEN - tcp6 0 0 :::80 :::* LISTEN - tcp6 0 0 :::22 :::* LISTEN - tcp6 0 0 ::1:25 :::* LISTEN -
Hello Hugo, You can use the test server: https://mana-test.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #191 from Hugo Agud <hagud@orex.es> --- Dear Alex thank you very much! we have added this line to Shared our $MANA_IP = "https://mana-test.koha-community.org"; and we have been able to work. REPORTS: We have been able to download reports from MANA BUT they are not able to execute because it dissapears spaces between orders.. we have got to review and separate some statements in order to make it works. We have NOT been able to upload a report or a serial patter , the systema it claims Can't call method "first_valid_email_address" on an undefined value at /home/vagrant/kohaclone/Koha/SharedContent.pm line 108. We have checked that the user has primary and secondary email and the library has also a library defined... (perhas it needs to be registered in MANA? we have not been able to register in MANA using syspref. Orex Digital (XXXXX) Primary email:info@orex.es Secondary email: info@orex.es SERIAL We have added a serial with a issn that MANA manage and it never finds it No subscription found on Mana Knowledge Base :( Please feel free to share you pattern with all others librarians once you are done Reviewing logs... dozens of Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc line 53. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc line 53. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #192 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #177)
Can I get an answer to my comments 162-164?
Still waiting for that, I am switching to FQA until I get what I asked 4 months ago, to avoid testers to lose their time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #193 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 70874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70874&action=edit Bug 17047 - Fix retrieving Mana token -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #194 from Alex Arnaud <alex.arnaud@biblibre.com> --- To be clear with the job done since Jonathan's QA:
Comment 161 - /cgi-bin/koha/svc/mana/getToken is not successfully returning a security token? Fixed
Comment 162 and Comment 163 Fixed
Comment 164 - How can we open issue on http://git.biblibre.com/biblibre/koha-mana We plan to move Mana server sources on Koha community repository
Comment 164 - I'd like a more complete README to run the server and the tests. http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md. Need to be completed
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #195 from Alex Arnaud <alex.arnaud@biblibre.com> --- I will work on Comment 191 as soon as possible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #196 from Hugo Agud <hagud@orex.es> --- good morning I have applied last patch 'Fix reteiving Mana Token' I am able to get token but I am not able to share anything with mana, same error than before Use of uninitialized value $loggedinuser in string ne at /home/vagrant/kohaclone/Koha/SharedContent.pm line 106. Can't call method "first_valid_email_address" on an undefined value at /home/vagrant/kohaclone/Koha/SharedContent.pm line 108. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m Assignee|baptiste.wojtkowski@biblibr |alex.arnaud@biblibre.com |e.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70203|0 |1 is obsolete| | --- Comment #197 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72660&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70204|0 |1 is obsolete| | --- Comment #198 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72661&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70205|0 |1 is obsolete| | --- Comment #199 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72662&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70206|0 |1 is obsolete| | --- Comment #200 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72663&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70208|0 |1 is obsolete| | --- Comment #201 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72664&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70209|0 |1 is obsolete| | --- Comment #202 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72665&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70210|0 |1 is obsolete| | --- Comment #203 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72666&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70211|0 |1 is obsolete| | --- Comment #204 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72667&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70561|0 |1 is obsolete| | --- Comment #205 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72668&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70874|0 |1 is obsolete| | --- Comment #206 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72669&action=edit Bug 17047 - Fix retrieving Mana token -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #207 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 72670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72670&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #208 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Hugo Agud from comment #191)
Dear Alex
thank you very much! we have added this line to Shared
our $MANA_IP = "https://mana-test.koha-community.org";
and we have been able to work.
REPORTS: We have been able to download reports from MANA BUT they are not able to execute because it dissapears spaces between orders.. we have got to review and separate some statements in order to make it works. Yes, there is bad reports in Mana database. They came here when the share method was broken. We should clear them now.
We have NOT been able to upload a report or a serial patter , the systema it claims Can't call method "first_valid_email_address" on an undefined value at /home/vagrant/kohaclone/Koha/SharedContent.pm line 108. Works for me. But i did some little changes today. Can you apply them and test again?
We have checked that the user has primary and secondary email and the library has also a library defined... (perhas it needs to be registered in MANA? we have not been able to register in MANA using syspref.
Orex Digital (XXXXX)
Primary email:info@orex.es Secondary email: info@orex.es
SERIAL We have added a serial with a issn that MANA manage and it never finds it
No subscription found on Mana Knowledge Base :(
Please feel free to share you pattern with all others librarians once you are done
Reviewing logs...
dozens of Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana- subscription-search-result.inc line 53. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana- subscription-search-result.inc line 53.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|victor.grousset@biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #209 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73699&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #210 from Jesse Maseto <jesse@bywatersolutions.com> --- Hello Alex, This patch is not applying. There are a few merge conflicts. -JesseM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72660|0 |1 is obsolete| | --- Comment #211 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73737&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72661|0 |1 is obsolete| | --- Comment #212 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73738&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72662|0 |1 is obsolete| | --- Comment #213 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73739&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72663|0 |1 is obsolete| | --- Comment #214 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73740&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72664|0 |1 is obsolete| | --- Comment #215 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73741&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72665|0 |1 is obsolete| | --- Comment #216 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73742&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72666|0 |1 is obsolete| | --- Comment #217 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73743&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72667|0 |1 is obsolete| | --- Comment #218 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73744&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72668|0 |1 is obsolete| | --- Comment #219 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73745&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72669|0 |1 is obsolete| | --- Comment #220 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73746&action=edit Bug 17047 - Fix retrieving Mana token -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72670|0 |1 is obsolete| | --- Comment #221 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73747&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73699|0 |1 is obsolete| | --- Comment #222 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73748&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #223 from Jesse Maseto <jesse@bywatersolutions.com> --- Getting some errors in the plack logs while testing. Use of uninitialized value $ressourcetype in ucfirst at /home/vagrant/kohaclone/Koha/SharedContent.pm line 123. Use of uninitialized value $ressourcetype in ucfirst at /home/vagrant/kohaclone/Koha/SharedContent.pm line 124. Can't locate object method "get_sharable_info" via package "Koha::" (perhaps you forgot to load "Koha::"?) at /home/vagrant/kohaclone/Koha/SharedContent.pm line 125. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73737|0 |1 is obsolete| | --- Comment #224 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73975&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73738|0 |1 is obsolete| | --- Comment #225 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73976&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73739|0 |1 is obsolete| | --- Comment #226 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73977&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73740|0 |1 is obsolete| | --- Comment #227 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73978&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73741|0 |1 is obsolete| | --- Comment #228 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73979&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73742|0 |1 is obsolete| | --- Comment #229 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73980&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #230 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73981&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73744|0 |1 is obsolete| | --- Comment #231 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73982&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73745|0 |1 is obsolete| | --- Comment #232 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73983&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73746|0 |1 is obsolete| | --- Comment #233 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73984&action=edit Bug 17047 - Fix retrieving Mana token Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73747|0 |1 is obsolete| | --- Comment #234 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73985&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73748|0 |1 is obsolete| | --- Comment #235 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 73986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73986&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #236 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is there a plan to avoid never-ending rebases? (In reply to Alex Arnaud from comment #194)
Comment 164 - How can we open issue on http://git.biblibre.com/biblibre/koha-mana We plan to move Mana server sources on Koha community repository
Comment 164 - I'd like a more complete README to run the server and the tests. http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md. Need to be completed
What about these two points? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73743|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #237 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #236)
Is there a plan to avoid never-ending rebases?
(In reply to Alex Arnaud from comment #194)
Comment 164 - How can we open issue on http://git.biblibre.com/biblibre/koha-mana We plan to move Mana server sources on Koha community repository
Comment 164 - I'd like a more complete README to run the server and the tests. http://git.biblibre.com/biblibre/koha-mana/blob/master/README.md. Need to be completed
What about these two points?
I think only the second point needs an answer. What do you miss on the README file? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #238 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #236)
Is there a plan to avoid never-ending rebases?
Make QA and push? :p -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #239 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I can get back to this one when the documentation to test locally (server too) will be completed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73975|0 |1 is obsolete| | --- Comment #240 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76673&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73976|0 |1 is obsolete| | --- Comment #241 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76674&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73977|0 |1 is obsolete| | --- Comment #242 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76675&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73978|0 |1 is obsolete| | --- Comment #243 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76676&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73979|0 |1 is obsolete| | --- Comment #244 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76677&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73980|0 |1 is obsolete| | --- Comment #245 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76678&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73981|0 |1 is obsolete| | --- Comment #246 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76679&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73982|0 |1 is obsolete| | --- Comment #247 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76680&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73983|0 |1 is obsolete| | --- Comment #248 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76681&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73984|0 |1 is obsolete| | --- Comment #249 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76682&action=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73985|0 |1 is obsolete| | --- Comment #250 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76683&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73986|0 |1 is obsolete| | --- Comment #251 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 76684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76684&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #252 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #239)
I can get back to this one when the documentation to test locally (server too) will be completed.
I have updated the README.md of Mana server. There you'll find a link to the documentation of Mana feature in Koha. And a documentation on Mana server (install and use). Also i've just rebased the 12 patches above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #253 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Unit tests: [kohadev-koha@kohadevbox:/home/vagrant/kohaclone (BZ17047_s) ✹ ✭]% prove -r t/db_dependent/Koha/SharedContent.t t/db_dependent/Koha/Subscription* t/db_dependent/Serial* t/db_dependent/Koha/SharedContent.t ................ Name "Koha::SharedContent::MANA_IP" used only once: possible typo at t/db_dependent/Koha/SharedContent.t line 44. t/db_dependent/Koha/Subscription.t ................. "my" variable $builder masks earlier declaration in same scope at t/db_dependent/Koha/Subscription.t line 38. t/db_dependent/Koha/Subscription.t ................. 1/9 Can't call method "biblionumber" on an undefined value at /home/vagrant/kohaclone/Koha/Subscription.pm line 143. # Looks like your test exited with 255 just after 8. t/db_dependent/Koha/Subscription.t ................. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/9 subtests t/db_dependent/Serials/ReNewSubscription.t ......... Undefined subroutine &Koha::SharedContent::manaGetRequestWithId called at /home/vagrant/kohaclone/C4/Serials.pm line 303. 2. QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt FAIL forbidden patterns forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 196) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 196) FAIL t/db_dependent/Koha/SharedContent.t FAIL valid Name "Koha::SharedContent::MANA_IP" used only once: possible typo FAIL t/db_dependent/Koha/Subscription.t FAIL valid "my" variable $builder masks earlier declaration in same scope About MANA_IP, you should move it to a Koha::SharedContent method. It would be the only way to retrieve mana_config from the config. It will help to handle non-existent/invalid entry. Moreover I think we should avoid having config at package level (because of usage of Memcached and Plack). It will be easy to mock with mock_config. 3. There is a CamelCase/snake_case mix in method's names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #254 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- - Message on the admin page - click here, then you enable, then? We should link to a documentation page. - log_path is not in the default yaml file or specify in any docs. I did not manage to configure the server config file to make it work locally. Can you share a working example please? - What is supposed to happen when I click on "Send" in the ManaToken syspref block? There is a wrong error handling, as my server is not setup properly, I click and nothing happens. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76673|0 |1 is obsolete| | --- Comment #255 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78215&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76674|0 |1 is obsolete| | --- Comment #256 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78216&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76675|0 |1 is obsolete| | --- Comment #257 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78217&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76676|0 |1 is obsolete| | --- Comment #258 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78218&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76677|0 |1 is obsolete| | --- Comment #259 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78219&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76678|0 |1 is obsolete| | --- Comment #260 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78220&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76679|0 |1 is obsolete| | --- Comment #261 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78221&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76680|0 |1 is obsolete| | --- Comment #262 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78222&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76681|0 |1 is obsolete| | --- Comment #263 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78223&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76682|0 |1 is obsolete| | --- Comment #264 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78224&action=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76683|0 |1 is obsolete| | --- Comment #265 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78225&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76684|0 |1 is obsolete| | --- Comment #266 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78226&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #267 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78227&action=edit Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA script warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #268 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78228&action=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest => search_entities buildRequest => build_request manaUrl => get_sharing_url -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #269 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #253)
1. Unit tests: [kohadev-koha@kohadevbox:/home/vagrant/kohaclone (BZ17047_s) ✹ ✭]% prove -r t/db_dependent/Koha/SharedContent.t t/db_dependent/Koha/Subscription* t/db_dependent/Serial* t/db_dependent/Koha/SharedContent.t ................ Name "Koha::SharedContent::MANA_IP" used only once: possible typo at t/db_dependent/Koha/SharedContent.t line 44.
t/db_dependent/Koha/Subscription.t ................. "my" variable $builder masks earlier declaration in same scope at t/db_dependent/Koha/Subscription.t line 38. t/db_dependent/Koha/Subscription.t ................. 1/9 Can't call method "biblionumber" on an undefined value at /home/vagrant/kohaclone/Koha/Subscription.pm line 143. # Looks like your test exited with 255 just after 8. t/db_dependent/Koha/Subscription.t ................. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/9 subtests
t/db_dependent/Serials/ReNewSubscription.t ......... Undefined subroutine &Koha::SharedContent::manaGetRequestWithId called at /home/vagrant/kohaclone/C4/Serials.pm line 303.
2. QA script:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt FAIL forbidden patterns forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 196) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 196)
FAIL t/db_dependent/Koha/SharedContent.t FAIL valid Name "Koha::SharedContent::MANA_IP" used only once: possible typo
FAIL t/db_dependent/Koha/Subscription.t FAIL valid "my" variable $builder masks earlier declaration in same scope
About MANA_IP, you should move it to a Koha::SharedContent method. It would be the only way to retrieve mana_config from the config. It will help to handle non-existent/invalid entry. Moreover I think we should avoid having config at package level (because of usage of Memcached and Plack). It will be easy to mock with mock_config.
3. There is a CamelCase/snake_case mix in method's names
Fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78228|0 |1 is obsolete| | --- Comment #270 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 78229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78229&action=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest => search_entities buildRequest => build_request manaUrl => get_sharing_url -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #271 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #254)
- Message on the admin page - click here, then you enable, then? We should link to a documentation page.
- log_path is not in the default yaml file or specify in any docs. I did not manage to configure the server config file to make it work locally. Can you share a working example please? I don't know what your are talking about for these 2 points
- What is supposed to happen when I click on "Send" in the ManaToken syspref block? There is a wrong error handling, as my server is not setup properly, I click and nothing happens.
You are supposed to receive an email containing a link to activate your Mana account. Like this one: " Hello Alex Arnaud, Someone asked on 2018-08-28 for an authentication on the Mana KB webservice. To activate your account definitively, please click on the following link and follow the instruction https://mana-test.koha-community.org/registration?id=DnX********************... " It works for me because i set the official Mana server url in Koha. May be you are using a locale one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #272 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #271)
(In reply to Jonathan Druart from comment #254)
- Message on the admin page - click here, then you enable, then? We should link to a documentation page.
IIRC there is a link on the admin page, which point to the syspref. But it's not clear what "mana" is and what need to be done to configure/use it correctly. I suggested to add a link to point to a documentation page (wiki or manual)
- log_path is not in the default yaml file or specify in any docs. I did not manage to configure the server config file to make it work locally. Can you share a working example please?
Server-side, I am trying to make it work locally to test the whole things. I did not manage to get a working config file to make the server run properly.
- What is supposed to happen when I click on "Send" in the ManaToken syspref block? There is a wrong error handling, as my server is not setup properly, I click and nothing happens.
You are supposed to receive an email containing a link to activate your Mana account. Like this one:
" Hello Alex Arnaud, Someone asked on 2018-08-28 for an authentication on the Mana KB webservice. To activate your account definitively, please click on the following link and follow the instruction https://mana-test.koha-community.org/ registration?id=DnX************************
"
It works for me because i set the official Mana server url in Koha. May be you are using a locale one?
Yes, the server I am using does not return a correct message and nothing happens when I click, which means errors are not handled correctly in JS code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #273 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #272)
IIRC there is a link on the admin page, which point to the syspref. But it's not clear what "mana" is and what need to be done to configure/use it correctly. I suggested to add a link to point to a documentation page (wiki or manual)
I didn't write all the code, so i may have missed something: I don't see any "Mana" link on the admin page.
- log_path is not in the default yaml file or specify in any docs. I did not manage to configure the server config file to make it work locally. Can you share a working example please?
Server-side, I am trying to make it work locally to test the whole things. I did not manage to get a working config file to make the server run properly.
Quite complicated to solve server side problems from here. At which step are you stuck ? Did you get errors? I can take a moment to help you (with screen share) to set up the server when you are available.
Yes, the server I am using does not return a correct message and nothing happens when I click, which means errors are not handled correctly in JS code.
Work to be done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78215|0 |1 is obsolete| | --- Comment #274 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79868&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78216|0 |1 is obsolete| | --- Comment #275 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79869&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78217|0 |1 is obsolete| | --- Comment #276 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79870&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78218|0 |1 is obsolete| | --- Comment #277 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79871&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78219|0 |1 is obsolete| | --- Comment #278 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79872&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78220|0 |1 is obsolete| | --- Comment #279 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79874&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78221|0 |1 is obsolete| | --- Comment #280 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79877&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78222|0 |1 is obsolete| | --- Comment #281 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79878&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78223|0 |1 is obsolete| | --- Comment #282 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79879&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78224|0 |1 is obsolete| | --- Comment #283 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79880&action=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78225|0 |1 is obsolete| | --- Comment #284 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79881&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78226|0 |1 is obsolete| | --- Comment #285 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79882&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78227|0 |1 is obsolete| | --- Comment #286 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79883&action=edit Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA script warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78229|0 |1 is obsolete| | --- Comment #287 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79884&action=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest => search_entities buildRequest => build_request manaUrl => get_sharing_url -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #288 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79885&action=edit Bug 17047: add a dedicated page for Mana setup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #289 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79886&action=edit Bug 17047: [DO NOT PUSH] provide staff-global.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #290 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79887&action=edit Bug 17047: [DO NOT PUSH] provides schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #291 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79888&action=edit Bug 17047: Fix reports sharing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #292 from Alex Arnaud <alex.arnaud@biblibre.com> --- Work done: - Add a dedicated page for configuring Mana, - provides css and schema files in separated patches, - fix report sharing (probably broken by a rebase), - On server side: update config.yaml. Was missing some keys -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #293 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Applying: Bug 17047 SQL reports management with Mana-KB error: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79868|0 |1 is obsolete| | --- Comment #294 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79922&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79869|0 |1 is obsolete| | --- Comment #295 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79923&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79870|0 |1 is obsolete| | --- Comment #296 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79924&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79871|0 |1 is obsolete| | --- Comment #297 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79925&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79872|0 |1 is obsolete| | --- Comment #298 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79926&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79874|0 |1 is obsolete| | --- Comment #299 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79927&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79877|0 |1 is obsolete| | --- Comment #300 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79928&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79878|0 |1 is obsolete| | --- Comment #301 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79929&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79879|0 |1 is obsolete| | --- Comment #302 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79930&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79880|0 |1 is obsolete| | --- Comment #303 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79931&action=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79881|0 |1 is obsolete| | --- Comment #304 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79932&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79882|0 |1 is obsolete| | --- Comment #305 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79933&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79883|0 |1 is obsolete| | --- Comment #306 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79934&action=edit Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA script warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79884|0 |1 is obsolete| | --- Comment #307 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79935&action=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest => search_entities buildRequest => build_request manaUrl => get_sharing_url -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79885|0 |1 is obsolete| | --- Comment #308 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79936&action=edit Bug 17047: add a dedicated page for Mana setup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79886|0 |1 is obsolete| | --- Comment #309 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79937&action=edit Bug 17047: [DO NOT PUSH] provide staff-global.css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79887|0 |1 is obsolete| | --- Comment #310 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79938&action=edit Bug 17047: [DO NOT PUSH] provides schema files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79888|0 |1 is obsolete| | --- Comment #311 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 79939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79939&action=edit Bug 17047: Fix reports sharing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #312 from Brendan Gallagher <brendan@bywatersolutions.com> --- In the system preferences there isn't a place to fill out a request for a mana token anymore. Did I miss something in the comments that I don't need to get a token anymore? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #313 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to Brendan Gallagher from comment #312)
In the system preferences there isn't a place to fill out a request for a mana token anymore. Did I miss something in the comments that I don't need to get a token anymore?
Hi brendan, There's now a page on admin/admin-home, like for HEA (bottom right, close to the hea page ;) ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #314 from Brendan Gallagher <brendan@bywatersolutions.com> --- oh very cool Paul! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #315 from Michal Denar <black23@gmail.com> --- Hi, If I filled registration and cliked on activation link, I was on 404 page. So registration wasn't confirmed. I'm not able to test comunication between Kohadexbox and Mana. What I can to do? Mana will be great tool :-) Mike -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #316 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Michal Denar from comment #315)
Hi, If I filled registration and cliked on activation link, I was on 404 page. So registration wasn't confirmed. I'm not able to test comunication between Kohadexbox and Mana. What I can to do?
Mana will be great tool :-)
Mike
Hello Mike, I your mana config points to mana-test.koha-community.org, it's normal. Mana server is temporarily unavailable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79922|0 |1 is obsolete| | Attachment #79923|0 |1 is obsolete| | Attachment #79924|0 |1 is obsolete| | Attachment #79925|0 |1 is obsolete| | Attachment #79926|0 |1 is obsolete| | Attachment #79927|0 |1 is obsolete| | Attachment #79928|0 |1 is obsolete| | Attachment #79929|0 |1 is obsolete| | Attachment #79930|0 |1 is obsolete| | Attachment #79931|0 |1 is obsolete| | Attachment #79932|0 |1 is obsolete| | Attachment #79933|0 |1 is obsolete| | Attachment #79934|0 |1 is obsolete| | Attachment #79935|0 |1 is obsolete| | Attachment #79936|0 |1 is obsolete| | Attachment #79937|0 |1 is obsolete| | Attachment #79938|0 |1 is obsolete| | Attachment #79939|0 |1 is obsolete| | --- Comment #317 from Michal Denar <black23@gmail.com> --- Created attachment 80183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80183&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #318 from Michal Denar <black23@gmail.com> --- Created attachment 80184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80184&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #319 from Michal Denar <black23@gmail.com> --- Created attachment 80185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80185&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #320 from Michal Denar <black23@gmail.com> --- Created attachment 80186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80186&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #321 from Michal Denar <black23@gmail.com> --- Created attachment 80187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80187&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #322 from Michal Denar <black23@gmail.com> --- Created attachment 80188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80188&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #323 from Michal Denar <black23@gmail.com> --- Created attachment 80189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80189&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #324 from Michal Denar <black23@gmail.com> --- Created attachment 80190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80190&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #325 from Michal Denar <black23@gmail.com> --- Created attachment 80191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80191&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #326 from Michal Denar <black23@gmail.com> --- Created attachment 80192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80192&action=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #327 from Michal Denar <black23@gmail.com> --- Created attachment 80193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80193&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #328 from Michal Denar <black23@gmail.com> --- Created attachment 80194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80194&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #329 from Michal Denar <black23@gmail.com> --- Created attachment 80195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80195&action=edit Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA script warnings Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #330 from Michal Denar <black23@gmail.com> --- Created attachment 80196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80196&action=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest => search_entities buildRequest => build_request manaUrl => get_sharing_url Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #331 from Michal Denar <black23@gmail.com> --- Created attachment 80197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80197&action=edit Bug 17047: add a dedicated page for Mana setup Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #332 from Michal Denar <black23@gmail.com> --- Created attachment 80198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80198&action=edit Bug 17047: [DO NOT PUSH] provide staff-global.css Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #333 from Michal Denar <black23@gmail.com> --- Created attachment 80199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80199&action=edit Bug 17047: [DO NOT PUSH] provides schema files Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #334 from Michal Denar <black23@gmail.com> --- Created attachment 80200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80200&action=edit Bug 17047: Fix reports sharing Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12710 [Bug 12710] Import/export reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|12710 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12710 [Bug 12710] Import/export reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vfernandes@keep.pt --- Comment #335 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- *** Bug 12710 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80198|0 |1 is obsolete| | --- Comment #336 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80471&action=edit Bug 17047: [DO NOT PUSH] provide staff-global.css Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80199|0 |1 is obsolete| | --- Comment #337 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80472&action=edit Bug 17047: [DO NOT PUSH] provides schema files Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80200|0 |1 is obsolete| | --- Comment #338 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80473&action=edit Bug 17047: Fix reports sharing Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #339 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Cannot apply, there is something wrong (patches order?) error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80183|0 |1 is obsolete| | --- Comment #340 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80907&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80184|0 |1 is obsolete| | --- Comment #341 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80908&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80185|0 |1 is obsolete| | --- Comment #342 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80909&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80186|0 |1 is obsolete| | --- Comment #343 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80910&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80187|0 |1 is obsolete| | --- Comment #344 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80911&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80188|0 |1 is obsolete| | --- Comment #345 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80912&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80189|0 |1 is obsolete| | --- Comment #346 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80913&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80190|0 |1 is obsolete| | --- Comment #347 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80914&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80191|0 |1 is obsolete| | --- Comment #348 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80915&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80192|0 |1 is obsolete| | --- Comment #349 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80916&action=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80193|0 |1 is obsolete| | --- Comment #350 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80917&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80194|0 |1 is obsolete| | --- Comment #351 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80918&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80195|0 |1 is obsolete| | --- Comment #352 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80919&action=edit Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA script warnings Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80196|0 |1 is obsolete| | --- Comment #353 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80920&action=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest => search_entities buildRequest => build_request manaUrl => get_sharing_url Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80197|0 |1 is obsolete| | --- Comment #354 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80921&action=edit Bug 17047: add a dedicated page for Mana setup Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80471|0 |1 is obsolete| | --- Comment #355 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80922&action=edit Bug 17047: [DO NOT PUSH] provide staff-global.css Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80472|0 |1 is obsolete| | --- Comment #356 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80923&action=edit Bug 17047: [DO NOT PUSH] provides schema files Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80473|0 |1 is obsolete| | --- Comment #357 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 80924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80924&action=edit Bug 17047: Fix reports sharing Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #358 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I will try to have a look at this one before the feature freeze to evaluate if this could be part of 18.11. Could you catch possible QA failures (update the QA script repo and run it over the whole patchset)? It would also help to have a remote branch with the stack up-to-date (the one on the biblibre repo is 18 months old), I tried to rebase but got: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80907|0 |1 is obsolete| | --- Comment #359 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81935&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80908|0 |1 is obsolete| | --- Comment #360 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81936&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80909|0 |1 is obsolete| | --- Comment #361 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81937&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80910|0 |1 is obsolete| | --- Comment #362 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81938&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80911|0 |1 is obsolete| | --- Comment #363 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81939&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80912|0 |1 is obsolete| | --- Comment #364 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81940&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80913|0 |1 is obsolete| | --- Comment #365 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81941&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80914|0 |1 is obsolete| | --- Comment #366 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81942&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80915|0 |1 is obsolete| | --- Comment #367 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81943&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80916|0 |1 is obsolete| | --- Comment #368 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81944&action=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80917|0 |1 is obsolete| | --- Comment #369 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81945&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80918|0 |1 is obsolete| | --- Comment #370 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81946&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80919|0 |1 is obsolete| | --- Comment #371 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81947&action=edit Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA script warnings Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80920|0 |1 is obsolete| | --- Comment #372 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81948&action=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest => search_entities buildRequest => build_request manaUrl => get_sharing_url Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80921|0 |1 is obsolete| | --- Comment #373 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81949&action=edit Bug 17047: add a dedicated page for Mana setup Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80922|0 |1 is obsolete| | --- Comment #374 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81950&action=edit Bug 17047: [DO NOT PUSH] provide staff-global.css Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80923|0 |1 is obsolete| | --- Comment #375 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81951&action=edit Bug 17047: [DO NOT PUSH] provides schema files Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80924|0 |1 is obsolete| | --- Comment #376 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81952&action=edit Bug 17047: Fix reports sharing Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #377 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 81968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81968&action=edit Bug 17047: [QA tool] add template filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #378 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #358)
I will try to have a look at this one before the feature freeze to evaluate if this could be part of 18.11.
Could you catch possible QA failures (update the QA script repo and run it over the whole patchset)? Done => nothing to fix. Also, i run the tools on joubu/qa-test-tools-issue_3 branch which caused my last patch.
It would also help to have a remote branch with the stack up-to-date (the one on the biblibre repo is 18 months old), I tried to rebase but got: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt).
Which repo ? github, biblibre ? Mana server ? All patches are rebased here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #379 from Kyle M Hall <kyle@bywatersolutions.com> --- Alex, could you rebase this patch set again? I'd like to QA it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81935|0 |1 is obsolete| | --- Comment #380 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83863&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81936|0 |1 is obsolete| | --- Comment #381 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83864&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81937|0 |1 is obsolete| | --- Comment #382 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83865&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81938|0 |1 is obsolete| | --- Comment #383 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83866&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81939|0 |1 is obsolete| | --- Comment #384 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83867&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81940|0 |1 is obsolete| | --- Comment #385 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83868&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81941|0 |1 is obsolete| | --- Comment #386 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83869&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81942|0 |1 is obsolete| | --- Comment #387 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83870&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81943|0 |1 is obsolete| | --- Comment #388 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83871&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81944|0 |1 is obsolete| | --- Comment #389 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83872&action=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81945|0 |1 is obsolete| | --- Comment #390 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83873&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81946|0 |1 is obsolete| | --- Comment #391 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83874&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81947|0 |1 is obsolete| | --- Comment #392 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83875&action=edit Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA script warnings Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81948|0 |1 is obsolete| | --- Comment #393 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83876&action=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest => search_entities buildRequest => build_request manaUrl => get_sharing_url Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81949|0 |1 is obsolete| | --- Comment #394 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83877&action=edit Bug 17047: add a dedicated page for Mana setup Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81950|0 |1 is obsolete| | --- Comment #395 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83878&action=edit Bug 17047: [DO NOT PUSH] provide staff-global.css Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81951|0 |1 is obsolete| | --- Comment #396 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83879&action=edit Bug 17047: [DO NOT PUSH] provides schema files Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81952|0 |1 is obsolete| | --- Comment #397 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83880&action=edit Bug 17047: Fix reports sharing Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81968|0 |1 is obsolete| | --- Comment #398 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 83881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83881&action=edit Bug 17047: [QA tool] add template filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83863|0 |1 is obsolete| | Attachment #83864|0 |1 is obsolete| | Attachment #83865|0 |1 is obsolete| | Attachment #83866|0 |1 is obsolete| | Attachment #83867|0 |1 is obsolete| | Attachment #83868|0 |1 is obsolete| | Attachment #83869|0 |1 is obsolete| | Attachment #83870|0 |1 is obsolete| | Attachment #83871|0 |1 is obsolete| | Attachment #83872|0 |1 is obsolete| | Attachment #83873|0 |1 is obsolete| | Attachment #83874|0 |1 is obsolete| | Attachment #83875|0 |1 is obsolete| | Attachment #83876|0 |1 is obsolete| | Attachment #83877|0 |1 is obsolete| | Attachment #83878|0 |1 is obsolete| | Attachment #83879|0 |1 is obsolete| | Attachment #83880|0 |1 is obsolete| | Attachment #83881|0 |1 is obsolete| | --- Comment #399 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83892&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #400 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83893&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #401 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83894&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB ========= Test plan ========= (see BibLibre complete documentation, attached to this patch) 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - subscriptions - Try create a new subscription for a first serial => Koha shouldn't show you anything (except if the base hase been filled) - Share this serial on Mana-KB (on the subscription detail page there must be a Share button) - Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 5 - SQL Report - Create a new report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it on Mana-KB => you will have a success message - On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 6 - Comments. - On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values]. - If you click other, a new textbox appears. Enter a short comment. - Reload the whole page, the comment should appear in the menu and in the comment column. - If you select a comment and reload the whole page, there should be one more comment with this name - If you select a comment and click on cancel just after, there shouldn't be any change when you reload. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #402 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83895&action=edit Bug 17047 security token agst flooding for Mana-KB Rework messages from Mana-KB. - Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB - To get an Authentication token, you have to fill a form and validate your e-mail address - Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #403 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83896&action=edit Bug 17047: Minor changes - search on reports module is now also validated by pressing enter. - AutoShare now initialized with nothing autmaticaly shared. - To create a report you now have to click on New report => New report from Mana. - Error messages are displayed in case of fail - Correct the display of sql reports containing "'" - Importing a report from Mana now opens the edit page - You don't get message after a successful import from mana (you simply get redirected) - Fix an error when cretaing subscription - Fix mana search - Correct encoding issues Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #404 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83897&action=edit Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema change, add to kohastructure.sql - Update schema files - Remove javascript debugger call Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #405 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83898&action=edit Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html attribute - Remove useless passing of mana_id variable in serials-toolbar.inc - Remove using CGI::param in list context - remove new subs from serials/subscription-add.pl - remov Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #406 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83899&action=edit Bug 17047 - Move ability to comment mana entities from search results table to report/subscription detail page + code refactoring Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #407 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83900&action=edit Bug 17047 - Fix template code in subscription-add.js Fix errors when saving a serial Provide a more visible message when sharing a report without note Fix Internal server error when trying to share a new report Make update DB idempotent Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #408 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83901&action=edit Bug 17047 - Fix retrieving Mana token Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #409 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83902&action=edit Bug 17047 - Remove changes on Koha/Schema/Result/SavedSql.pm and Subscription.pm - mana.inc included twice Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #410 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83903&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #411 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83904&action=edit Bug 17047: Fix unit tests Replace MANA_IP variable with subroutine Fix QA script warnings Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #412 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83905&action=edit Bug 17047: Koha::SharedContent subs snake casing/renaming manaRequest => process_request manaIncrementRequest => increment_entity_value manaPostRequest => send_entity prepareSharedData => prepare_entity_data manaGetRequestWithId => get_entity_by_id manaGetRequest => search_entities buildRequest => build_request manaUrl => get_sharing_url Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #413 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83906&action=edit Bug 17047: add a dedicated page for Mana setup Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #414 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83907&action=edit Bug 17047: [DO NOT PUSH] provide staff-global.css Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #415 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83908&action=edit Bug 17047: [DO NOT PUSH] provides schema files Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #416 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83909&action=edit Bug 17047: Fix reports sharing Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #417 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83910&action=edit Bug 17047: [QA tool] add template filters Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #418 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83911&action=edit Bug 17047 [QA Followup] - Fixes to make unit tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #419 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 83912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83912&action=edit Bug 17047 [QA Followup] - Don't enable by default Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #420 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84142&action=edit Bug 17047: QA fixes: - don't search subscriptions when mana is disabled, - subscription detail page: don't show share button or search link if Mana is disabled, - fix report sharing, - submit report search form by pressing enter, - add a waittin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84142|0 |1 is obsolete| | --- Comment #421 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84145&action=edit Bug 17047: QA fixes: - don't search subscriptions when mana is disabled, - subscription detail page: don't show share button or search link if Mana is disabled, - fix report sharing, - submit report search form by pressing enter, - add a waittin foo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #422 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 84210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84210&action=edit Bug 17047: (follow-up) Improve mana messages, enable by default, show messages if not configured -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #423 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #422)
Created attachment 84210 [details] [review] Bug 17047: (follow-up) Improve mana messages, enable by default, show messages if not configured
Hi Alex, I added a followup to enable by default, show a helpful tip if not configured, and updated some language - if this one is okay can you remove the third option from the syspref, squash the followups and then I think we can push this one. -Nick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #424 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi all, as this means you are communicating with an external server, I am not sure if we should enable by default. I think all those should be opt-in choices. Even an IP address is considered personal data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #425 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- So last comment doesn't get missed (it's a looong bug) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #426 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to Katrin Fischer from comment #424)
Hi all, as this means you are communicating with an external server, I am not sure if we should enable by default. I think all those should be opt-in choices. Even an IP address is considered personal data.
If it the syspref is set to 0, BUT there is no mana token, there's no communication. The patch just remove the syspref value "I haven't decided" and replace it by "set to yes + no token = the librarian hasn't decided" And the token is set only when the library ask for it by clicking on the "get token button". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #427 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Paul, thx for replying! I've applied the patches and taken a look at the configuration page. What's the difference between the 'no' and 'no, let me think about it'? Where is it explained? I think as the system preference reads "Enable request to Mana Webservice" this is not clear to the user that there is no communication without the token. I would feel better if we left to "no". We can still advertise Mana of course - I am not against the service at all, but I feel we should be consistent and clear about protecting user's privacy. Noticing while testing: commmit messages are a bit messy and not following guidelines (old patch, I know, but easy to fix). I even volunteer doing it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83892|0 |1 is obsolete| | Attachment #83893|0 |1 is obsolete| | Attachment #83894|0 |1 is obsolete| | Attachment #83895|0 |1 is obsolete| | Attachment #83896|0 |1 is obsolete| | Attachment #83897|0 |1 is obsolete| | Attachment #83898|0 |1 is obsolete| | Attachment #83899|0 |1 is obsolete| | Attachment #83900|0 |1 is obsolete| | Attachment #83901|0 |1 is obsolete| | Attachment #83902|0 |1 is obsolete| | Attachment #83903|0 |1 is obsolete| | Attachment #83904|0 |1 is obsolete| | Attachment #83905|0 |1 is obsolete| | Attachment #83906|0 |1 is obsolete| | Attachment #83907|0 |1 is obsolete| | Attachment #83908|0 |1 is obsolete| | Attachment #83909|0 |1 is obsolete| | Attachment #83910|0 |1 is obsolete| | Attachment #83911|0 |1 is obsolete| | Attachment #83912|0 |1 is obsolete| | Attachment #84145|0 |1 is obsolete| | Attachment #84210|0 |1 is obsolete| | --- Comment #428 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84260&action=edit Bug 17047 add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #429 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84261&action=edit Bug 17047 subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #430 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84262&action=edit Bug 17047 SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #431 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84263&action=edit Bug 17047: add a dedicated page for Mana setup Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #432 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84264&action=edit Bug 17047: [DO NOT PUSH] provide staff-global.css Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #433 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84265&action=edit Bug 17047: [DO NOT PUSH] provides schema files Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #434 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Nick Clemens from comment #423)
(In reply to Nick Clemens from comment #422)
Created attachment 84210 [details] [review] [review] Bug 17047: (follow-up) Improve mana messages, enable by default, show messages if not configured
Hi Alex,
I added a followup to enable by default, show a helpful tip if not configured, and updated some language - if this one is okay can you remove the third option from the syspref, squash the followups and then I think we can push this one.
-Nick
Hi Nick, Removed the third option, restore the IGNORE in SQL statement to make it idempotent and did a big squash. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #435 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Katrin Fischer from comment #427)
Hi Paul, thx for replying!
I've applied the patches and taken a look at the configuration page. What's the difference between the 'no' and 'no, let me think about it'? Where is it explained? I think as the system preference reads "Enable request to Mana Webservice" this is not clear to the user that there is no communication without the token. I would feel better if we left to "no". We can still advertise Mana of course - I am not against the service at all, but I feel we should be consistent and clear about protecting user's privacy.
Noticing while testing: commmit messages are a bit messy and not following guidelines (old patch, I know, but easy to fix). I even volunteer doing it :)
Hello Katrin, It was a way to promote the feature (i say "it was" since we decided to remove this third option). "No, let me think about it" was the default choice, and, in this case, the user saw a message telling him he has not decided yet to use or not Mana. You can communicate with Mana if you did not set a token. You can retrieve subscriptions and reports but not share them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #436 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Alex Arnaud from comment #435) guidelines (old patch, I know, but easy to fix). I even volunteer doing it :)
Hello Katrin,
It was a way to promote the feature (i say "it was" since we decided to remove this third option). "No, let me think about it" was the default choice, and, in this case, the user saw a message telling him he has not decided yet to use or not Mana.
You can communicate with Mana if you did not set a token. You can retrieve subscriptions and reports but not share them.
Thx Alex for clearing this up! In this case I really think we should default to no, like we do for other external services like Covers, Hea etc. I see the file attached. What could be a good way to provide that information to the users interested in Mana? We could update the wiki page: https://wiki.koha-community.org/wiki/Mana_central_database. Adding the information to the manual might also be good. -- You are receiving this mail because: You are watching all bug changes.
Thx Alex for clearing this up! In this case I really think we should default to no, like we do for other external services like Covers, Hea etc. mana defaulted to yes/no token is similar to "I haven't explicitly decided". If we set it to "no" by default, then the library can miss the feature. I want to avoid the hea case where the default set to "no" result in many libraries missing the feature, and not saying "I don't want to share".
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #437 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to Katrin Fischer from comment #436) the proposed behavior is harmless from privacy as well as from ergonomics point of view. So I really think we must not default to "no" and the proposed change is fine. Hea is a good example of something we could have promoted better: how many libraries are not sharing because they don't know that hea exist vs not sharing because they don't want to share ? I want to avoid this behavior.
I see the file attached. What could be a good way to provide that information to the users interested in Mana?
We could update the wiki page: https://wiki.koha-community.org/wiki/Mana_central_database. Adding the information to the manual might also be good. I agree with promoting & documenting. But that's not enough, many libraries don't read the doc, or don't investigate. Add the case where an IT makes upgrade and the library don't even know... So making mana visible in the staff interface, to be sure the librarian chose, and not only "don't know" is the way to go.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #438 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hea is actually sending data. While it's not personal data, I still think having Hea turned off by default was the only way to go. We should not create an application that is calling home without asking. I actually liked your approach with the third option - turn off, but show a message to give them a note. Maybe this idea could be explored further? But ultimately it would be nice to get more opinions on this, because we won't agree :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #439 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to Katrin Fischer from comment #438)
Hea is actually sending data. While it's not personal data, I still think having Hea turned off by default was the only way to go. We should not create an application that is calling home without asking.
I actually liked your approach with the third option - turn off, but show a message to give them a note. Maybe this idea could be explored further?
But ultimately it would be nice to get more opinions on this, because we won't agree :)
Hey, but we agree !!! I fully agree that we don't want to activate HEA by default ! The mistake we made, was to set it OFF by default. The right approach would have been to have "undecided yet" by default. And show the "please, look at HEA, there's some important decision we want YOU do take". So the library can be warned they have a decision to take, a choice to make. I'm sure that it would have been resulting in more libraries sharing. That's what I wanted to avoid with MANA, and that's what's Kyle patch improve: our initial dev was a syspref with 3 status (explicit yes, explicit no, no explicit decision), and kyle found a way to have those 3 options with a binary syspref and the token * syspref=yes / token empty => no explicit decision * syspref=yes / token filled => explicit decision * syspref=no => explicit decision do you agree that we agree ? :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #440 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- "No undecided" sounds fine to me indeed :) But I wonder if this is really the behaviur of the current patches? I think it said "Enabled" when I test installed the other day. But I won't have time for another test the next days :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #441 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Katrin Fischer from comment #440)
"No undecided" sounds fine to me indeed :)
But I wonder if this is really the behaviur of the current patches? I think it said "Enabled" when I test installed the other day. But I won't have time for another test the next days :(
Katrin, Does that means you are ok for the third option (the so called "No, let me think about it") as described above ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #442 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Alex Arnaud from comment #441)
(In reply to Katrin Fischer from comment #440)
"No undecided" sounds fine to me indeed :)
But I wonder if this is really the behaviur of the current patches? I think it said "Enabled" when I test installed the other day. But I won't have time for another test the next days :(
Katrin,
Does that means you are ok for the third option (the so called "No, let me think about it") as described above ?
Yes, if I understood the feature correctly, I would be fine. I understand it would mean off by default, but with an information to the user that they might want to turn it on. Turning it yes or no would turn the message off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84260|0 |1 is obsolete| | --- Comment #443 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84323&action=edit Bug 17047: add Mana-KB syspref Add the system preference to enable or disable Mana-KB webservice on koha. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84261|0 |1 is obsolete| | --- Comment #444 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84324&action=edit Bug 17047: subscriptions management with Mana-KB - add a class SharedContent.pm to communicate with Mana-KB server - add a link in serials-menu.inc to serials_search.pl to open a mana-subscription research form - modify the research form in serials-search.tt to show the right fields for Mana-KB - create datatable in mana-subscription-search-result.inc to show results from a research on Mana-KB - modify serials-search.pl to manage research on Mana-KB - add a mana_id to subscription table - add a share button on serials-toolbar.inc and a modal to ask the language of the share and to alert if the subscription is already link to a Mana-KB subscription model - add function in C4/Serials to get all the info for a subscription sharing - modify subscription-detail.pl to manage sharing to Mana-KB - modify subscription-add.tt and subscription.pl to manage a import from Mana-KB during a subscription creation - add 2 script in svc for ajax calling from subscription-add.tt to communicate with Mana-KB server during a asubscription creation - add a function in Subscription.pm to have all the info for a Mana-KB research from a biblionumber - modify functions used by subscription-add.pl in C4/Serials to manage a frequency which came from Mana-KB server and not already created on the koha database, and modify the tests of the said functions Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84262|0 |1 is obsolete| | --- Comment #445 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84325&action=edit Bug 17047: SQL reports management with Mana-KB Includes: * code factorization Some code from subscription & Mana-KB has been factorized in order to speed-up next developments * SytemPreferences: Mana Activation: - add a value "no, let me think about it", that is the default value. - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) ) AutoShareWithMana - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default) * Interface : - On mana-search, rows are now sorted by date of last import, then by number of users - Windows redesigned to improve the user experience * New Feature : report a mistake. - people can now report an invalid data (wrong, obsolete,...) - if a data is reported as invalid many time, it will appear differently - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature) - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists * API (svc/mana) - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource - no hardcoding for resources in the code of api (api needs to be called with a ressourcename) * New feature : SQL report sharing - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports - New feature: share reports with Mana-KB - New feature: search report in Mana-KB with keywords - New feature: load reports from Mana-KB Test plan: 1 - Apply Patch + update database 2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example) <!-- URL of the mana KB server --> <!-- alternative value http://mana-test.koha-community.org to query the test server --> <mana_config>https://mana-kb.koha-community.org</mana_config> 3 - Check Mana syspref and AutoShareWithMana syspref are not activated 4 - Search the syspref ManaToken and follow the instructions 5 - subscriptions - Try create a new subscription for a first serial => Mana-KB shouldn't show you anything (except if the base hase been filled) - Share this serial with Mana-KB (on the serial individual's page there must be a Share button) - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear - Activate AutoShareWithMana => Subscriptions - Create a new subscription for a second serial - There shouldn't be any Share button - Create a second subscription => the message should appear, click again on use 6 - SQL Report - Create a new SQL report, without notes. - On the table with all report (reports > use saved), there should be the action "Share" - If you click on share, you have an error message - Create a new report, with a title and notes longer than 20 characters - You can share it with mana => you will have a success message - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list. 7 - Report mistakes. - On any table containing Mana-KB search results, you can report a mistake and add a comment. 8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message. Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> (2018-07-04) Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84263|0 |1 is obsolete| | --- Comment #446 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84326&action=edit Bug 17047: add a dedicated page for Mana setup Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #447 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84327&action=edit Bug 17047: Add a third option for Mana system preference This adds the "No, let me think about it" option. It is the default option. If the Mana system preference is set to "No, let me think about it", the user is warned on the admin home page that he has not decided yet to use or not Mana knowlegde base. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84264|0 |1 is obsolete| | --- Comment #448 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84328&action=edit Bug 17047: [DO NOT PUSH] provide staff-global.css Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84265|0 |1 is obsolete| | --- Comment #449 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 84329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84329&action=edit Bug 17047: [DO NOT PUSH] provides schema files Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #450 from Alex Arnaud <alex.arnaud@biblibre.com> --- I re-added the third "No, let me think about it" option. Also, reword the commit message to be consistent with the naming conventions. Need a signoff for this last patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84327|0 |1 is obsolete| | --- Comment #451 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 84332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84332&action=edit Bug 17047: Add a third option for Mana system preference This adds the "No, let me think about it" option. It is the default option. If the Mana system preference is set to "No, let me think about it", the user is warned on the admin home page that he has not decided yet to use or not Mana knowlegde base. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Keywords| |release-notes-needed --- Comment #452 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! This adds Mana with default setting 'No,let me think about it' which advertises the feature. I think before release we may want to consider a way to move this to a yes/no, but I think it will help advertise for testing and usage before release. Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22193 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193 [Bug 22193] Mana - share comments about reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 [Bug 22196] Clean up Mana KB administration template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22197 [Bug 22197] Add Mana KB link to administration sidebar menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22198 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22198 [Bug 22198] Add granular permission setting for Mana KB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22202 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22202 [Bug 22202] Breadcrumbs wrong in Mana admin page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22210 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 [Bug 22210] Allow organisations to sign up to Mana KB more easily -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22222 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222 [Bug 22222] Mana subscription search always returns all results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 [Bug 22237] Subscriptions are not linked to Mana upon edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 [Bug 22248] Error when incrementing Mana comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 [Bug 22249] Error when submitting Mana comment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 [Bug 22250] Clean up Mana KB integration with serials and reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22252 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22252 [Bug 22252] Status messages returned by Mana are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #453 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This enhancement will not be backported to the 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22257 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22257 [Bug 22257] Mana should prevent duplicate comments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #454 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please add POD to Koha::SharedContent: perldoc Koha/SharedContent.pm DESCRIPTION Package for accessing shared content via Mana Package Functions process_request increment_entity_value send_entity prepare_entity_data get_entity_by_id search_entities build_request get_sharing_url -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22358 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 [Bug 22358] Add POD to Koha::SharedContent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #455 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #454)
Please add POD to Koha::SharedContent:
perldoc Koha/SharedContent.pm
DESCRIPTION Package for accessing shared content via Mana
Package Functions process_request increment_entity_value send_entity prepare_entity_data get_entity_by_id search_entities build_request get_sharing_url
Moved to Bug 22358 - Add POD to Koha::SharedContent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #456 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A couple of things wrong in serials/subscription-add.pl 1. 447 if ( defined( $query->param('mana_id') ) ) { It's always defined, you wanted to test with "" 2. 375 if ( (C4::Context->preference('Mana')) and ( grep { $_ eq "subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){ Mana == 2 == let me think about it => I am not expecting to reach Koha::SharedContent in that case -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #457 from Lisette Scheer <lisetteslatah@gmail.com> --- *** Bug 17045 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22400 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22400 [Bug 22400] There should be a 'dismiss' button on the admin page for the Mana message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #458 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #456)
A couple of things wrong in serials/subscription-add.pl
1. 447 if ( defined( $query->param('mana_id') ) ) {
It's always defined, you wanted to test with ""
2. 375 if ( (C4::Context->preference('Mana')) and ( grep { $_ eq "subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){
Mana == 2 == let me think about it => I am not expecting to reach Koha::SharedContent in that case
Should we move this to a separate bug as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #459 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- t/db_dependent/Koha/SharedContent.t:C4::Context->set_userenv(0,0,0, ->set_userenv should no longer be used in tests. See bug 21817. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22488 [Bug 22488] Mana: Improve confirmation email text and formatting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22452 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 [Bug 22452] Typos in add a comment to Mana modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #460 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #458)
(In reply to Jonathan Druart from comment #456)
A couple of things wrong in serials/subscription-add.pl
1. 447 if ( defined( $query->param('mana_id') ) ) {
It's always defined, you wanted to test with ""
2. 375 if ( (C4::Context->preference('Mana')) and ( grep { $_ eq "subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){
Mana == 2 == let me think about it => I am not expecting to reach Koha::SharedContent in that case
Should we move this to a separate bug as well?
See bug 22849, I would have expected someone else to deal with that. I have opened the bug report, it's blocker for 19.05 IMO. Comments should not be ignored, even when the work is pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22850 [Bug 22850] SharedContent.t wrongly use ->set_userenv -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #461 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #459)
t/db_dependent/Koha/SharedContent.t:C4::Context->set_userenv(0,0,0,
->set_userenv should no longer be used in tests. See bug 21817.
See bug 22850. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22849 [Bug 22849] Data shared without agreement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature adds the release notes| |ability for Koha to talk to | |a Mana Knowledge Base | |server, allowing libraries | |to share a small, but | |hopefully growing, number | |sets of data. | | | |Currently | |this includes subscription | |patterns and ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds the |This new feature adds the release notes|ability for Koha to talk to |ability for Koha to talk to |a Mana Knowledge Base |a Mana Knowledge Base |server, allowing libraries |server, allowing libraries |to share a small, but |to share a small, but |hopefully growing, number |hopefully growing, number |sets of data. |sets of data. | | |Currently |Currently |this includes subscription |this includes sharing |patterns and ... |serial subscription | |patterns and reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Mana Knowledge Base : share |Mana Knowledge Base : Data |data |sharing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23087 [Bug 23087] Update DB system for Mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26142 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26142 [Bug 26142] variable used has hashref when they are objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26604 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25572 [Bug 25572] Permissions for Mana Reports are currently linked to Permissions in Serials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27061 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27061 [Bug 27061] Double permission check in svc/mana/search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #462 from Andrew Nugged <nugged@gmail.com> --- Comment on attachment 84325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84325 Bug 17047: SQL reports management with Mana-KB Hidden gem in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84325&action=diff&headers=0#a/reports/guided_reports.pl_sec3 ➟ 185 'mana_success' => $input->param('mana_success'), 186 'mana_success' => scalar $input->param('mana_success'), "Double Mana" feature, but of course that's the hash so first one useless + more: it generates warning: /koha/intranet/cgi-bin/reports/guided_reports.pl line 188 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30253 [Bug 30253] Double mana_success line is no success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org