https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 77276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77276&action=edit Bug 21121 - Added new system preference to control hiding of personal patron information in the circulation page Libraries may want to hide personal patron data from the circulation page for privacy reasons this syspref introduces that ability for library staff to control the display of this data themselves without having to ask support vendors to hide it for them. Test plan: 1. View circulation page and input a patrons barcode or name 2. Notice if the patron has a phone number, email, street address and city set then these are displayed in the left hand side of the screen under the patrons name. Otherwise if all/any of these fields are not set for the patron then the text: "No <datafield> stored." is displayed. 3. Apply this patch 4. Run ./updatedatabase.pl from the Koha shell to run the atomicupdate 5. Restart memcached and plack 6. Notice a new systempreference named 'HidePersonalPatronDetailOnCirculation' has been added, which has the default value 'Dont' 7. Without changing the default value notice the personal patron information is still displayed on the circulation page 8. Change the value of the syspref to 'Do' and now notice the phone number, email address, street address and city are now hidden in the circulation page Sponsored-By: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77276|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77280&action=edit Bug 21121: Added new system preference to control hiding of personal patron information in the circulation page Libraries may want to hide personal patron data from the circulation page for privacy reasons this syspref introduces that ability for library staff to control the display of this data themselves without having to ask support vendors to hide it for them. Test plan: 1. View circulation page and input a patrons barcode or name 2. Notice if the patron has a phone number, email, street address and city set then these are displayed in the left hand side of the screen under the patrons name. Otherwise if all/any of these fields are not set for the patron then the text: "No <datafield> stored." is displayed. 3. Apply this patch 4. Run ./updatedatabase.pl from the Koha shell to run the atomicupdate 5. Restart memcached and plack 6. Notice a new systempreference named 'HidePersonalPatronDetailOnCirculation' has been added, which has the default value 'Dont' 7. Without changing the default value notice the personal patron information is still displayed on the circulation page 8. Change the value of the syspref to 'Do' and now notice the phone number, email address, street address and city are now hidden in the circulation page Sponsored-By: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77280|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77367&action=edit Bug 21121: Added new system preference to control hiding of personal patron information in the circulation page Libraries may want to hide personal patron data from the circulation page for privacy reasons this syspref introduces that ability for library staff to control the display of this data themselves without having to ask support vendors to hide it for them. Test plan: 1. View circulation page and input a patrons barcode or name 2. Notice if the patron has a phone number, email, street address and city set then these are displayed in the left hand side of the screen under the patrons name. Otherwise if all/any of these fields are not set for the patron then the text: "No <datafield> stored." is displayed. 3. Apply this patch 4. Run ./updatedatabase.pl from the Koha shell to run the atomicupdate 5. Restart memcached and plack 6. Notice a new systempreference named 'HidePersonalPatronDetailOnCirculation' has been added, which has the default value 'Dont' 7. Without changing the default value notice the personal patron information is still displayed on the circulation page 8. Change the value of the syspref to 'Do' and now notice the phone number, email address, street address and city are now hidden in the circulation page Sponsored-By: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Just a note to say this was sponsored-by: Toi Ohomai Institute of Technology in New Zealand and Catalyst IT. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Added to the 'Text to go in the release notes' box for you Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored-by: Toi Ohomai |Sponsored by: Toi Ohomai release notes|Institute of Technology in |Institute of Technology in |New Zealand and Catalyst |New Zealand and Catalyst |IT. |IT. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is it relevant to have HidePatronName and this new pref HidePersonalPatronDetailOnCirculation? Should not we merge them? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21121 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #10)

Is it relevant to have HidePatronName and this new pref HidePersonalPatronDetailOnCirculation? Should not we merge them?

I think HidePatronName is for hiding patron information outside circulation, while the other targets pages in the circulation module specifically. Something more general would still be nice, but I think both make sense right now. -- You are receiving this mail because: You are watching all bug changes.