https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14294 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Karen <karenliang.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58181|0 |1 is obsolete| | --- Comment #2 from Karen <karenliang.student@wegc.school.nz> --- Created attachment 59035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59035&action=edit Bug 17777: koha-remove should deal with temporary uploads If the temporary upload folder exists, it should be discarded when removing an instance. If we do not, it may/will create problems when recreating the same instance. A function in koha-functions.sh is added to determine the temp directory instead of hardcoding /tmp. Test plan: [1] Copy koha-functions.sh to /usr/share/koha/bin [2] Run koha-create --create-db newinstancexx [3] Run mkdir /tmp/koha_newinstancexx_upload (if /tmp is your temp!) [4] Run debian/scripts/koha-remove newinstancexx Do not run the regular one, but verify that you use the updated one. [5] Check that /tmp/koha_newinstancexx_upload is gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Karen Jen <karenliang.student@wegc.school.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59035|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59076&action=edit Bug 17777: koha-remove should deal with temporary uploads If the temporary upload folder exists, it should be discarded when removing an instance. If we do not, it may/will create problems when recreating the same instance. A function in koha-functions.sh is added to determine the temp directory instead of hardcoding /tmp. Test plan: [1] Copy koha-functions.sh to /usr/share/koha/bin [2] Run koha-create --create-db newinstancexx [3] Run mkdir /tmp/koha_newinstancexx_upload (if /tmp is your temp!) [4] Run debian/scripts/koha-remove newinstancexx Do not run the regular one, but verify that you use the updated one. [5] Check that /tmp/koha_newinstancexx_upload is gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Karen Jen <karenliang.student@wegc.school.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Karen <karenliang.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karenliang.student@wegc.sch | |ool.nz Assignee|m.de.rooy@rijksmuseum.nl |karenliang.student@wegc.sch | |ool.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.