[Bug 21346] New: Remove return2 div from returns.tt now that modal interface exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Bug ID: 21346 Summary: Remove return2 div from returns.tt now that modal interface exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Someone added a new modal for holds/transfers in return.tt (yay!). They left the old dialog in the background, and if you ignore the modal, it remains. To replicate: 1) Place a hold on an item from Branch A to be delivered to Branch B. 2) Checkin in the item at Branch A and confirm the hold to transfer. 3) Be human and make a mistake. Login as Branch C and check the item in. 4) Note the great modal to redirect the hold. Note that the old dialog is behind it! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cbrannon@cdalibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 78724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78724&action=edit [PATCH] Bug 21346: Remove old hold/transfer dialog TO TEST: 1) Place a hold on an item from Branch A to be delivered to Branch B. 2) Checkin the item at Branch A and confirm the hold to transfer. 3) Be human and make a mistake. Login as Branch C and check the item in. 4) Note the great modal to redirect the hold. Note that the old dialog is behind it! 5) Apply the patch. 6) Repeat step 3. Now note that the old dialog is no longer on the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78724|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 78726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78726&action=edit Bug 21346: Remove old hold/transfer dialog TO TEST: 1) Place a hold on an item from Branch A to be delivered to Branch B. 2) Checkin the item at Branch A and confirm the hold to transfer. 3) Be human and make a mistake. Login as Branch C and check the item in. 4) Note the great modal to redirect the hold. Note that the old dialog is behind it! 5) Apply the patch. 6) Repeat step 3. Now note that the old dialog is no longer on the page. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- I found that this broke something else. Back to the drawing board! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove return2 div from |Remove return2 div from |returns.tt now that modal |returns.tt now that modal |interface exists |interface exists / Fix | |waiting holds at wrong | |location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- I managed to fix the patch AND fix the bug with the waiting holds being checked in at the wrong location that do nothing! Test plan to come. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 78902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78902&action=edit Bug 21346: Update/Fix dialogs - Fix hold waiting TEST PLAN 1) Place a hold on an item from Branch A to be delivered to Branch B. 2) Checkin the item at Branch A and confifm the hold to transfer. 3) Be human and make a mistake. Login as Branch C and check the item in 4) Note the great modal to redirect the hold. Note that the old dialog is behind it! 5) Check in the item at Branch B to put it in waiting status. 6) Be human and make another mistake. Login as Branch C and check the item in. Notice it does nothing except a local hold. 7) Check out an item at Branch A. 8) Check in the item at Branch B. Notice the classic blue transfer dialog at the top of page. 9) Apply the patch. 10) Check everything in at their branches. 11) Repeat steps 1-8. Now note the classic dialogs are gone and nothing but the modals left. Note that the waiting hold will now reroute back the place it should be waiting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78726|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Spencer <ssmith3@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ssmith3@mckinneytexas.org Status|Needs Signoff |Failed QA --- Comment #6 from Spencer <ssmith3@mckinneytexas.org> --- Everything is functional- however when an item is checked in to transfer back to its home branch (not on hold) there is no confirm option- only a force to print a slip. WE don't print slips for non-hold transfers. If that scenario offered a simple "confirm" choice, it would work well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 78915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78915&action=edit Bug 21346: Update buttons on transfer only Added a confirm only button and updated text on print button for the transfer dialog so you are not forced to print. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- Added button per Spencer's suggestion. Thanks for testing! Please try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78915|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 78916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78916&action=edit Bug 21346: Update buttons on transfer only Added a confirm only button and updated text on print button for the transfer dialog so you are not forced to print. Signed-off-by: Spencer <ssmith3@mckinneytexas.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- *** Bug 17339 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove return2 div from |Clean up dialogs in |returns.tt now that modal |returns.pl / Fix waiting |interface exists / Fix |holds at wrong location bug |waiting holds at wrong | |location | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to ByWater Sandboxes from comment #9)
Created attachment 78916 [details] [review] Bug 21346: Update buttons on transfer only
Added a confirm only button and updated text on print button for the transfer dialog so you are not forced to print.
Signed-off-by: Spencer <ssmith3@mckinneytexas.org>
Spencer, when signing off, if there is more than one patch involved, you need to sign off on the whole thing, not just a single patch. Have Ed show you how. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18490 [Bug 18490] Transfer message confusing, cancel button missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Fred King <fred.king@medstar.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fred.king@medstar.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78902|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 78942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78942&action=edit Bug 21346: Update/Fix dialogs - Fix hold waiting TEST PLAN 1) Place a hold on an item from Branch A to be delivered to Branch B. 2) Checkin the item at Branch A and confifm the hold to transfer. 3) Be human and make a mistake. Login as Branch C and check the item in 4) Note the great modal to redirect the hold. Note that the old dialog is behind it! 5) Check in the item at Branch B to put it in waiting status. 6) Be human and make another mistake. Login as Branch C and check the item in. Notice it does nothing except a local hold. 7) Check out an item at Branch A. 8) Check in the item at Branch B. Notice the classic blue transfer dialog at the top of page. 9) Apply the patch. 10) Check everything in at their branches. 11) Repeat steps 1-8. Now note the classic dialogs are gone and nothing but the modals left. Note that the waiting hold will now reroute back the place it should be waiting. Signed-off-by: Fred King <fred.king@medstar.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78916|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 78943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78943&action=edit Bug 21346: Update buttons on transfer only Added a confirm only button and updated text on print button for the transfer dialog so you are not forced to print. Signed-off-by: Spencer <ssmith3@mckinneytexas.org> Signed-off-by: Fred King <fred.king@medstar.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #14 from Christopher Brannon <cbrannon@cdalibrary.org> --- *** Bug 13153 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- *** Bug 19720 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is bugfix, not an enhancement, right? I would suggest to provide a patch which would not contain the indentation changes, that will generate conflicts and make the backport harder. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #17 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Jonathan Druart from comment #16)
This is bugfix, not an enhancement, right? I would suggest to provide a patch which would not contain the indentation changes, that will generate conflicts and make the backport harder.
It is both. Please explain. I don't understand the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #18 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Christopher Brannon from comment #17)
(In reply to Jonathan Druart from comment #16)
This is bugfix, not an enhancement, right? I would suggest to provide a patch which would not contain the indentation changes, that will generate conflicts and make the backport harder.
It is both. Please explain. I don't understand the issue.
Never mind. I think I understand. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78942|0 |1 is obsolete| | Attachment #78943|0 |1 is obsolete| | --- Comment #19 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 79685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79685&action=edit Bug 21346: Update/Fix dialogs - Fix hold waiting TEST PLAN 1) Place a hold on an item from Branch A to be delivered to Branch B. 2) Checkin the item at Branch A and confifm the hold to transfer. 3) Be human and make a mistake. Login as Branch C and check the item in 4) Note the great modal to redirect the hold. Note that the old dialog is behind it! 5) Check in the item at Branch B to put it in waiting status. 6) Be human and make another mistake. Login as Branch C and check the item in. Notice it does nothing except a local hold. 7) Check out an item at Branch A. 8) Check in the item at Branch B. Notice the classic blue transfer dialog at the top of page. 9) Apply the patch. 10) Check everything in at their branches. 11) Repeat steps 1-8. Now note the classic dialogs are gone and nothing but the modals left. Note that the waiting hold will now reroute back the place it should be waiting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #20 from Christopher Brannon <cbrannon@cdalibrary.org> --- Resubmitted patch, removing indent changes per request and combined patches. No new code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79685|0 |1 is obsolete| | --- Comment #21 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 79686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79686&action=edit Bug 21346: Update/Fix dialogs - Fix hold waiting TEST PLAN 1) Place a hold on an item from Branch A to be delivered to Branch B. 2) Checkin the item at Branch A and confifm the hold to transfer. 3) Be human and make a mistake. Login as Branch C and check the item in 4) Note the great modal to redirect the hold. Note that the old dialog is behind it! 5) Check in the item at Branch B to put it in waiting status. 6) Be human and make another mistake. Login as Branch C and check the item in. Notice it does nothing except a local use. 7) Check out an item at Branch A. 8) Check in the item at Branch B. Notice the classic blue transfer dialog at the top of page. 9) Apply the patch. 10) Check everything in at their branches. 11) Repeat steps 1-8. Now note the classic dialogs are gone and nothing but the modals left. Note that the waiting hold will now reroute back the place it should be waiting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #22 from Christopher Brannon <cbrannon@cdalibrary.org> --- Fixed typo in plan. We should be good now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Christopher Brannon <cbrannon@cdalibrary.org> --- Found a logic problem. Hold-found2 modal triggering on top of hold-found1 modal if you check an item that is already waiting at that location. I will go in and update the logic to not show hold-found2 modal if waiting. I will put this back to needs sign-off when complete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #24 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 80879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80879&action=edit Bug 21346: Fixes dual modals on waiting hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Christopher Brannon <cbrannon@cdalibrary.org> --- I've isolated the flaw. We are good to go again. Test plan remains the same. I will also submit a patch to clean up the tabs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #26 from Christopher Brannon <cbrannon@cdalibrary.org> --- Changing this to a bug fix, as it fixes dialog issues and a known bug. Not really adding anything new in terms of features. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Christopher Brannon <cbrannon@cdalibrary.org> --- Found another issue. While I have fixed the routing issue, an item marked waiting and turned in to the wrong branch will re-route the item correctly, but does not set the item back to top priority. Looking into this. Failing for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #28 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 81100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81100&action=edit Bug 21346: Restore values needed for buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21664 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21186 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #29 from Christopher Brannon <cbrannon@cdalibrary.org> --- I am going to revamp this bug, once again. There are some other issues at hand that need to be done to handle this more appropriately: * I will be mapping out hold and transfer behaviors * Clean up some logic - some of it is a bit cobbled together: For example, found is used specificly when a hold is found, but has been used for some simple transfers as well. * Clarify some variables - found is too generic * Add a routine for correcting waiting holds - there is no current method for reverting a hold from waiting to in transit in returns. * Finish converting dialogs to modals. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79686|0 |1 is obsolete| | Attachment #80879|0 |1 is obsolete| | Attachment #81100|0 |1 is obsolete| | --- Comment #30 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 81836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81836&action=edit Bug 21346: Streamline logic in holds and transfers 1) Replaced comparison with string to make testing branch easier. 2) Replaced useless 0 values with undef. Does not change any behavior, only simplifies code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #31 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 81853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81853&action=edit Bug 21346: Remove double dialog To Test: 1) Place a hold on an item for pickup at another branch. 2) Check in item to trigger hold and transfer. 3) Check in item again without changing location. Note modal AND old dialog behind modal. 4) Apply patch. 5) Check in item again without changing location. Note modal without the old dialog. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #32 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 81921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81921&action=edit Bug 21346: Convert dialogs to modals This addresses most of the transfer dialogs. There are some dialogs that I have not converted because I don't know what triggers them, therefore I cannot test them. The following scenarios have been addresses, and should be tested: FOR TRANSFERS 1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't) * Should give 3 options - Yes, Yes with print, or No. * Yes and Yes with print should trigger a transfer back home. * No should do nothing. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Set AutomaticItemREturn to Don't. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do) * Should give 2 options - Print or OK. * Should automatically set transfer. * Print should open a window for printing, with correct information. * Both buttons should close modal. TO TEST: 1) Set AutomaticItemReturn to Do. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 3) Checkin with no issues or holds, but transfer already set * Should give 3 options - OK, Print or Cancel. * OK and print should not touch existing transfer. * Cancel should remove the exisiting transfer. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Check in an item following step 2 of either test above. 2) Check in item again, while a transfer exists. 3) Test conditions above. WRONG BRANCH 4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up: * Should give 1 option - OK. * Should not check anything in or initiate a transfer. * OK should close the modal. TO TEST: 1) Set AllowReturnToBranch to "only the library the item is from". You can test the other settings, as long as you pay attention to where you are checking the item in at. 2) Check in an item at a branch other than the owning library. 3) Test conditions above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #33 from Christopher Brannon <cbrannon@cdalibrary.org> --- Okay, patches for cleanup are set. Now addressing the waiting hold at the wrong location. It must: * Bring up a modal. * Only prompt to send the item to the pickup location. * Update current location in item. * Initiate a transfer. * Update the reserve from a W to T in the found field. * Remove the waiting date in the reserves. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81921|0 |1 is obsolete| | --- Comment #34 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 81924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81924&action=edit Bug 21346: Convert dialogs to modals. This addresses most of the transfer dialogs. There are some dialogs that I have not converted because I don't know what triggers them, therefore I cannot test them. The following scenarios have been addresses, and should be tested: FOR TRANSFERS 1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't) * Should give 3 options - Yes, Yes with print, or No. * Yes and Yes with print should trigger a transfer back home. * No should do nothing. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Set AutomaticItemREturn to Don't. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do) * Should give 2 options - Print or OK. * Should automatically set transfer. * Print should open a window for printing, with correct information. * Both buttons should close modal. TO TEST: 1) Set AutomaticItemReturn to Do. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 3) Checkin with no issues or holds, but transfer already set * Should give 3 options - OK, Print or Cancel. * OK and print should not touch existing transfer. * Cancel should remove the exisiting transfer. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Check in an item following step 2 of either test above. 2) Check in item again, while a transfer exists. 3) Test conditions above. WRONG BRANCH 4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up: * Should give 1 option - OK. * Should not check anything in or initiate a transfer. * OK should close the modal. TO TEST: 1) Set AllowReturnToBranch to "only the library the item is from". You can test the other settings, as long as you pay attention to where you are checking the item in at. 2) Check in an item at a branch other than the owning library. 3) Test conditions above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #35 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 82049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82049&action=edit Bug 21346: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #36 from Christopher Brannon <cbrannon@cdalibrary.org> --- Finally. I think this was the best approach. Sorry for the number of changes. If someone thinks I need to create a test for the modification to C4/Circulation.pm, I can try to do that to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #37 from Christopher Brannon <cbrannon@cdalibrary.org> --- *** Bug 18490 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81836|0 |1 is obsolete| | --- Comment #38 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 82189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82189&action=edit Bug 21346: Streamline logic in holds and transfers 1) Replaced comparison with string to make testing branch easier. 2) Replaced useless 0 values with undef. Does not change any behavior, only simplifies code. Signed-off-by: Lisette <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81853|0 |1 is obsolete| | --- Comment #39 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 82190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82190&action=edit Bug 21346: Remove double dialog To Test: 1) Place a hold on an item for pickup at another branch. 2) Check in item to trigger hold and transfer. 3) Check in item again without changing location. Note modal AND old dialog behind modal. 4) Apply patch. 5) Check in item again without changing location. Note modal without the old dialog. Signed-off-by: Lisette <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81924|0 |1 is obsolete| | --- Comment #40 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 82191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82191&action=edit Bug 21346: Convert dialogs to modals. This addresses most of the transfer dialogs. There are some dialogs that I have not converted because I don't know what triggers them, therefore I cannot test them. The following scenarios have been addresses, and should be tested: FOR TRANSFERS 1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't) * Should give 3 options - Yes, Yes with print, or No. * Yes and Yes with print should trigger a transfer back home. * No should do nothing. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Set AutomaticItemREturn to Don't. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do) * Should give 2 options - Print or OK. * Should automatically set transfer. * Print should open a window for printing, with correct information. * Both buttons should close modal. TO TEST: 1) Set AutomaticItemReturn to Do. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 3) Checkin with no issues or holds, but transfer already set * Should give 3 options - OK, Print or Cancel. * OK and print should not touch existing transfer. * Cancel should remove the exisiting transfer. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Check in an item following step 2 of either test above. 2) Check in item again, while a transfer exists. 3) Test conditions above. WRONG BRANCH 4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up: * Should give 1 option - OK. * Should not check anything in or initiate a transfer. * OK should close the modal. TO TEST: 1) Set AllowReturnToBranch to "only the library the item is from". You can test the other settings, as long as you pay attention to where you are checking the item in at. 2) Check in an item at a branch other than the owning library. 3) Test conditions above. Signed-off-by: Lisette <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82049|0 |1 is obsolete| | --- Comment #41 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 82192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82192&action=edit Bug 21346: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an item. 2) Check in the item to trigger the hold. Item is now listed as waiting. 3) Set branch to a different library. 4) Check in the item to trigger the hold. Notice that nothing but a local use is recorded. 5) Apply the patch. 6) Repeat steps 1-4. Notice that the hold is triggered around routed to its original pickup location. A transfer is set and the hold status is changed from waiting to correctly showing the item as in transit. Signed-off-by: Lisette <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18117 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Hardware|All |Macintosh QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #42 from Josef Moravec <josef.moravec@gmail.com> --- Overall it looks good, just one thing - please don't use inline javascript (onclick="...") And could you please separate the fix for rerouting wating hold to its own bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Josef Moravec from comment #42)
And could you please separate the fix for rerouting wating hold to its own bug report?
And it would be nice to have regression test here... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #44 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Josef Moravec from comment #43)
(In reply to Josef Moravec from comment #42)
And could you please separate the fix for rerouting wating hold to its own bug report?
And it would be nice to have regression test here...
I don't know what that is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 [Bug 21944] Fix waiting holds at wrong location bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82192|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clean up dialogs in |Clean up dialogs in |returns.pl / Fix waiting |returns.pl |holds at wrong location bug | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #45 from Christopher Brannon <cbrannon@cdalibrary.org> --- Ignore. Everyone calls it something different. Okay. The waiting patch is on bug 21944. I will add the test there. Since nothing else involves a pm here, I am setting this back to signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|21944 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 [Bug 21944] Fix waiting holds at wrong location bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82192|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82192|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 [Bug 21944] Fix waiting holds at wrong location bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #46 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Josef Moravec from comment #42)
Overall it looks good, just one thing - please don't use inline javascript (onclick="...")
Please, fix this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #47 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Christopher Brannon from comment #45)
Ignore. Everyone calls it something different. Okay. The waiting patch is on bug 21944. I will add the test there. Since nothing else involves a pm here, I am setting this back to signed off.
I'm not native speaker, so maybe I'm sometimes not using the right words, sorry ;) Good job -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #48 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 82891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82891&action=edit Bug 21346: Remove inline onclicks per comment 42 To test: 1) Apply patch. 2) Check that there is no changed behavior with buttons or checkboxes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #49 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Josef Moravec from comment #46)
(In reply to Josef Moravec from comment #42)
Overall it looks good, just one thing - please don't use inline javascript (onclick="...")
Please, fix this.
Done. Waiting for sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #50 from Christopher Brannon <cbrannon@cdalibrary.org> --- Lisette, when you get a chance, would you test again. Make sure there are no differences with buttons or checkboxes. Thanks! Christopher -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #51 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 82891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82891 Bug 21346: Remove inline onclicks per comment 42 Review of attachment 82891: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21346&attachment=82891) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ +672,2 @@
[% ELSE %] + <input type="checkbox" id="return_date_override_remember" name="return_date_override_remember" />
While the code below actually fixes some of the inline javascript that you corrected, I don't see anything that is the equivalent of forcing the focus to barcode for this. I'll look at the full file to confirm if there is something already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #52 from Liz Rea <wizzyrea@gmail.com> --- Mark, Does this qualify as a FQA for you? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82189|0 |1 is obsolete| | Attachment #82190|0 |1 is obsolete| | Attachment #82191|0 |1 is obsolete| | Attachment #82891|0 |1 is obsolete| | --- Comment #53 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87625&action=edit Bug 21346: Streamline logic in holds and transfers 1) Replaced comparison with string to make testing branch easier. 2) Replaced useless 0 values with undef. Does not change any behavior, only simplifies code. Signed-off-by: Lisette <lisetteslatah@gmail.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #54 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87626&action=edit Bug 21346: Remove double dialog To Test: 1) Place a hold on an item for pickup at another branch. 2) Check in item to trigger hold and transfer. 3) Check in item again without changing location. Note modal AND old dialog behind modal. 4) Apply patch. 5) Check in item again without changing location. Note modal without the old dialog. Signed-off-by: Lisette <lisetteslatah@gmail.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #55 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87627&action=edit Bug 21346: Convert dialogs to modals. This addresses most of the transfer dialogs. There are some dialogs that I have not converted because I don't know what triggers them, therefore I cannot test them. The following scenarios have been addresses, and should be tested: FOR TRANSFERS 1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't) * Should give 3 options - Yes, Yes with print, or No. * Yes and Yes with print should trigger a transfer back home. * No should do nothing. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Set AutomaticItemREturn to Don't. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do) * Should give 2 options - Print or OK. * Should automatically set transfer. * Print should open a window for printing, with correct information. * Both buttons should close modal. TO TEST: 1) Set AutomaticItemReturn to Do. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 3) Checkin with no issues or holds, but transfer already set * Should give 3 options - OK, Print or Cancel. * OK and print should not touch existing transfer. * Cancel should remove the exisiting transfer. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Check in an item following step 2 of either test above. 2) Check in item again, while a transfer exists. 3) Test conditions above. WRONG BRANCH 4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up: * Should give 1 option - OK. * Should not check anything in or initiate a transfer. * OK should close the modal. TO TEST: 1) Set AllowReturnToBranch to "only the library the item is from". You can test the other settings, as long as you pay attention to where you are checking the item in at. 2) Check in an item at a branch other than the owning library. 3) Test conditions above. Signed-off-by: Lisette <lisetteslatah@gmail.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #56 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87628&action=edit Bug 21346: Remove inline onclicks per comment 42 To test: 1) Apply patch. 2) Check that there is no changed behavior with buttons or checkboxes. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87625|0 |1 is obsolete| | Attachment #87626|0 |1 is obsolete| | Attachment #87627|0 |1 is obsolete| | Attachment #87628|0 |1 is obsolete| | --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87894&action=edit Bug 21346: Streamline logic in holds and transfers 1) Replaced comparison with string to make testing branch easier. 2) Replaced useless 0 values with undef. Does not change any behavior, only simplifies code. Signed-off-by: Lisette <lisetteslatah@gmail.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87895&action=edit Bug 21346: Remove double dialog To Test: 1) Place a hold on an item for pickup at another branch. 2) Check in item to trigger hold and transfer. 3) Check in item again without changing location. Note modal AND old dialog behind modal. 4) Apply patch. 5) Check in item again without changing location. Note modal without the old dialog. Signed-off-by: Lisette <lisetteslatah@gmail.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87896&action=edit Bug 21346: Convert dialogs to modals. This addresses most of the transfer dialogs. There are some dialogs that I have not converted because I don't know what triggers them, therefore I cannot test them. The following scenarios have been addresses, and should be tested: FOR TRANSFERS 1) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Don't) * Should give 3 options - Yes, Yes with print, or No. * Yes and Yes with print should trigger a transfer back home. * No should do nothing. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Set AutomaticItemREturn to Don't. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 2) Checkin with no issue, hold or transfer; not at home (AutomaticItemReturn set to Do) * Should give 2 options - Print or OK. * Should automatically set transfer. * Print should open a window for printing, with correct information. * Both buttons should close modal. TO TEST: 1) Set AutomaticItemReturn to Do. 2) Check in an item with no issues, holds or transfers set, at a location other than the owning library. 3) Test conditions above. 3) Checkin with no issues or holds, but transfer already set * Should give 3 options - OK, Print or Cancel. * OK and print should not touch existing transfer. * Cancel should remove the exisiting transfer. * Print should open a window for printing, with correct information. * All three options should close the modal. TO TEST: 1) Check in an item following step 2 of either test above. 2) Check in item again, while a transfer exists. 3) Test conditions above. WRONG BRANCH 4) If AllowReturnToBranch is not set "to any library", and the item is not checked in at the appropriate branch, the wrong-branch-modal pops up: * Should give 1 option - OK. * Should not check anything in or initiate a transfer. * OK should close the modal. TO TEST: 1) Set AllowReturnToBranch to "only the library the item is from". You can test the other settings, as long as you pay attention to where you are checking the item in at. 2) Check in an item at a branch other than the owning library. 3) Test conditions above. Signed-off-by: Lisette <lisetteslatah@gmail.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #60 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 87898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87898&action=edit Bug 21346: Remove inline onclicks per comment 42 To test: 1) Apply patch. 2) Check that there is no changed behavior with buttons or checkboxes. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #61 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x series for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #63 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.05.00, 18.11.05 |19.05.00, 18.11.05, released in| |18.05.12 CC| |fridolin.somers@biblibre.co | |m --- Comment #64 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Does not apply on 17.11.x. But since its nearly end of life we may let it like that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22896 [Bug 22896] [18.11] Item to be transferred at checkin clears overridden due date -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #65 from Magnus Enger <magnus@libriotech.no> --- I have a library that objects rather strongly to some of the changes introduced here. The main problem is the message that says an item needs a transfer. They used to be able to keep on returning books even if that message appeared. Now their workflow is disrupted and they have to click the OK button to make the modal go away. Could we make it optional if the popup message is a modal or not? (On a separate bug, of course. Just commenting here to get the opinion of the people on this bug.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #66 from Magnus Enger <magnus@libriotech.no> --- PS. The library has AutomaticItemReturn = Do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #67 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Magnus Enger from comment #65)
Could we make it optional if the popup message is a modal or not?
Agree 100% -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23007 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23145 [Bug 23145] Confirming transfer during checkin clears the table of previously checked-in items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007 [Bug 23007] Make dialogs in returns.pl optionally modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #68 from George Williams (NEKLS) <george@nekls.org> --- (In reply to Magnus Enger from comment #65)
Could we make it optional if the popup message is a modal or not?
I also agree - whether or not the message is a modal or not should be tied to a system preference so that libraries that want the modal to interrupt staff workflow (like me) can have that and those that do not want the workflow to be interrupted can have that also. George -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sounds like a consensus to me.. could we open a new bug for this please :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24257 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257 [Bug 24257] item-transfer-modal does not initiate transfer when 'yes, print slip' is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434 [Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be removed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org