[Bug 36950] New: Improve placement of catalog concern banner in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 Bug ID: 36950 Summary: Improve placement of catalog concern banner in the OPAC Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 167118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167118&action=edit Screenshot of the poorly-placed catalog concern banner After submitting a catalog concern the banner obscures any cover image and looks awkward. I think it should be placed right under the breadcrumbs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167119&action=edit Bug 36950: Improve placement of catalog concern banner in the OPAC This patch changes the placement of the catalog concern banner in the OPAC. Changing the way it is added to the DOM will prevent it from obscuring content. To test, apply the patch and clear your browser cache if necessary. - In the staff interface, make sure the "OpacCatalogConcerns" system preference is enabled. - Locate a bibliographic record and view the detail page. - Click the "Report a concern" link in the sidebar. - Submit your concern. - When the concern is successfully submitted and the modal closes, the success banner ("Your concern was successfully submitted.") should appear below the breadcrumbs menu and above the biblio view tabs ("Normal view, "MARC view", etc.). Sponsored-By: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167119|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167128&action=edit Bug 36950: Improve placement of catalog concern banner in the OPAC This patch changes the placement of the catalog concern banner in the OPAC. Changing the way it is added to the DOM will prevent it from obscuring content. To test, apply the patch and clear your browser cache if necessary. - In the staff interface, make sure the "OpacCatalogConcerns" system preference is enabled. - Locate a bibliographic record and view the detail page. - Click the "Report a concern" link in the sidebar. - Submit your concern. - When the concern is successfully submitted and the modal closes, the success banner ("Your concern was successfully submitted.") should appear below the breadcrumbs menu and above the biblio view tabs ("Normal view, "MARC view", etc.). Sponsored-By: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167128|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168323&action=edit Bug 36950: Improve placement of catalog concern banner in the OPAC This patch changes the placement of the catalog concern banner in the OPAC. Changing the way it is added to the DOM will prevent it from obscuring content. To test, apply the patch and clear your browser cache if necessary. - In the staff interface, make sure the "OpacCatalogConcerns" system preference is enabled. - Locate a bibliographic record and view the detail page. - Click the "Report a concern" link in the sidebar. - Submit your concern. - When the concern is successfully submitted and the modal closes, the success banner ("Your concern was successfully submitted.") should appear below the breadcrumbs menu and above the biblio view tabs ("Normal view, "MARC view", etc.). Sponsored-By: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Owen, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm sequence... I don't think we have a real standard there. I would have probably put the location after the Home library, instead of having the collection between, but not a blocker for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #5)
Hm sequence... I don't think we have a real standard there. I would have probably put the location after the Home library, instead of having the collection between, but not a blocker for me.
Wrong bug... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36950 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz Resolution|--- |FIXED --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org