[Bug 36796] New: Fix mistake in database column descriptions for statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Bug ID: 36796 Summary: Fix mistake in database column descriptions for statistics table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: magnus@libriotech.no Depends on: 32312 from bug 32312: (In reply to Jonathan Druart from comment #12)
Something wrong here, statistics was present already.
245 statistics => { 246 "datetime" => __("Statistics date and time"), 247 "branch" => __("Library"), 248 "value" => __("Value"), 249 "type" => __("Transaction type"), 250 "other" => __("SIP mode"), 251 "itemnumber" => __("Item number"), 252 "itemtype" => __("Koha item type"), 253 "location" => __("Shelving location"), 254 "borrowernumber" => __("Borrower number"), 255 "ccode" => __("Collection"), 256 "categorycode" => __("Patron category"), 257 },
302 statistics => { 303 "borrowernumber" => __("Borrower number"), 304 "branch" => __("Library"), 305 "datetime" => __("Statistics date and time"), 306 "itemnumber" => __("Item number"), 307 "itemtype" => __("Itemtype"), 308 "other" => __(""), 309 "type" => __("Type"), 310 "value" => __("Value"), 311 },
In this second block "other" is getting __("") which leads to displaying the header of the po file when using a translated interface.
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 [Bug 32312] Complete database column descriptions for circulation module in guided reports -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | CC| |david@davidnind.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 166238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166238&action=edit Bug 36796: (follow-up) Fix column descriptions for the statistics table This follow-up to bug 32312 fixes the descriptions for the statistics database columns, used in guided reports. It removes the duplicate statistics section in Koha/Database/Columns.pm so that descriptions are displayed for all columns, as originally intended. It also adds a description for the interface column (a new column added after the original patch was pushed). Test plan: 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that some columns have descriptions and some don't: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Type / statistics.type Item number / statistics.itemnumber Item type / statistics.itemtype statistics.other statistics.location Borrower number / statistics.borrowernumber statistics.ccode statistics.categorycode statistics.interface 5. Apply the patch. 6. Restart all the things (restart_all). 7. Repeat steps 1 to 4. 8. Scroll down to the statistics table section again and note that all columns now have descriptions: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Transaction type / statistics.type SIP mode / statistics.other Item number / statistics.itemnumber Koha item type / statistics.itemtype Shelving location / statistics.location Borrower number / statistics.borrowernumber Collection / statistics.ccode Patron category / statistics.categorycode Interface / statistics.interface 9. Sign off :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the descriptions release notes| |for the statistics database | |columns, used in guided | |reports (Reports > Guided | |reports > Create guided | |report > select Circulation | |module) - all statistics | |columns now have a | |description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the descriptions | release notes|for the statistics database | |columns, used in guided | |reports (Reports > Guided | |reports > Create guided | |report > select Circulation | |module) - all statistics | |columns now have a | |description. | CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166238|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166279&action=edit Bug 36796: (follow-up) Fix column descriptions for the statistics table This follow-up to bug 32312 fixes the descriptions for the statistics database columns, used in guided reports. It removes the duplicate statistics section in Koha/Database/Columns.pm so that descriptions are displayed for all columns, as originally intended. It also adds a description for the interface column (a new column added after the original patch was pushed). Test plan: 1. Go to Reports > Guided reports > Create guided report. 2. Choose 'Circulation' for the module to report on and select 'Next'. 3. Choose 'Tabular' for the type of report and select 'Next'. 4. Scroll down to the statistics table section and note that some columns have descriptions and some don't: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Type / statistics.type Item number / statistics.itemnumber Item type / statistics.itemtype statistics.other statistics.location Borrower number / statistics.borrowernumber statistics.ccode statistics.categorycode statistics.interface 5. Apply the patch. 6. Restart all the things (restart_all). 7. Repeat steps 1 to 4. 8. Scroll down to the statistics table section again and note that all columns now have descriptions: Statistics date and time / statistics.datetime Library / statistics.branch Value / statistics.value Transaction type / statistics.type SIP mode / statistics.other Item number / statistics.itemnumber Koha item type / statistics.itemtype Shelving location / statistics.location Borrower number / statistics.borrowernumber Collection / statistics.ccode Patron category / statistics.categorycode Interface / statistics.interface 9. Sign off :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate, | |rel_23_05_candidate, | |rel_23_11_candidate, | |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Keywords|rel_23_11_candidate | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the descriptions release notes| |for the statistics database | |columns, used in guided | |reports, (it is a follow-up | |to bug 32312): | |- The | |descriptions for the | |statistics section columns | |now display as intended. | |- | |It adds a description for | |the interface column (a new | |column added after the | |original bug). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Bug 36796 depends on bug 32312, which changed state. Bug 32312 Summary: Complete database column descriptions for circulation module in guided reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32312 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36796 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |RESOLVED --- Comment #5 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org