[Bug 25541] New: Add ability to prevent checkin of items with holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Bug ID: 25541 Summary: Add ability to prevent checkin of items with holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Some libraries would like patrons to be unable to return items with holds via SIP. Instead, the screen message should indicate that the patron should return that item at the circ desk so a librarian can use it to fill the next hold right away and place it on the hold shelf. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105090&action=edit Bug 25541 - Add ability to prevent checkin of items with holds Some libraries would like patrons to be unable to return items with holds via SIP. Instead, the screen message should indicate that the patron should return that item at the circ desk so a librarian can use it to fill the next hold right away and place it on the hold shelf. Test Plan: 1) Apply this patch. 2) Place a hold for an item. 3) Enable the new SIP option no_holds_checkin for a SIP account. 4) Restart the SIP server. 5) Check in the item using the SIP CLI tool using the SIP account for which you set the new option. 6) Note the checkin fails with a screen message indicating you should return the item to the circulation desk. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to prevent |Add ability to prevent |checkin of items with holds |checkin via SIP of items | |with holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105090|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105098&action=edit Bug 25541: Add ability to prevent checkin via SIP of items with holds Some libraries would like patrons to be unable to return items with holds via SIP. Instead, the screen message should indicate that the patron should return that item at the circ desk so a librarian can use it to fill the next hold right away and place it on the hold shelf. Test Plan: 1) Apply this patch. 2) Place a hold for an item. 3) Enable the new SIP option no_holds_checkin for a SIP account. 4) Restart the SIP server. 5) Check in the item using the SIP CLI tool using the SIP account for which you set the new option. 6) Note the checkin fails with a screen message indicating you should return the item to the circulation desk. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bc@interleaf.ie --- Comment #3 from Barry Cannon <bc@interleaf.ie> --- Is this similar to Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729? I added similar functionality via a syspref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Barry Cannon from comment #3)
Is this similar to Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729? I added similar functionality via a syspref.
Looks good! The problem with a syspref though is that the behavior cannot be changed on a per-account basis. It very well may be that such behavior is desired for a self check machine for example, but not for an AMH. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105098|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 107791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107791&action=edit Bug 25541: Add ability to prevent checkin via SIP of items with holds Some libraries would like patrons to be unable to return items with holds via SIP. Instead, the screen message should indicate that the patron should return that item at the circ desk so a librarian can use it to fill the next hold right away and place it on the hold shelf. Test Plan: 1) Apply this patch. 2) Place a hold for an item. 3) Enable the new SIP option no_holds_checkin for a SIP account. 4) Restart the SIP server. 5) Check in the item using the SIP CLI tool using the SIP account for which you set the new option. 6) Note the checkin fails with a screen message indicating you should return the item to the circulation desk. Signed-off-by: Peter Lau <peter.lau@yccece.edu.hk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi I found two issues with this: - Does it need to be enabled by default? (we usually keep the previous behaviour) - It adds the option to etc/SIPconfig.xml but it doesn't touch the one in debian/templates I agree this fits better in the SIPconfig.xml, Barry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 108626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108626&action=edit Bug 25541: Add new param to debian sip config -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> ---
Hi I found two issues with this: - Does it need to be enabled by default? (we usually keep the previous behaviour)
It is not enabled by default, keeping previous behavior as the default.
- It adds the option to etc/SIPconfig.xml but it doesn't touch the one in debian/templates
Added! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor niggle.. I'm not sure about the variable name 'no_holds_checkin'.. I think something like 'holds_block_checkin' might clarify it's meaning a bit? Otherwise, this generally looks good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #9)
Minor niggle.. I'm not sure about the variable name 'no_holds_checkin'.. I think something like 'holds_block_checkin' might clarify it's meaning a bit?
Agreed, that's a much better name. Followup incoming... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109519&action=edit Bug 25541: (QA follow-up) Rename no_holds_checkin to holds_block_checkin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107791|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109534&action=edit Bug 25541: Add ability to prevent checkin via SIP of items with holds Some libraries would like patrons to be unable to return items with holds via SIP. Instead, the screen message should indicate that the patron should return that item at the circ desk so a librarian can use it to fill the next hold right away and place it on the hold shelf. Test Plan: 1) Apply this patch. 2) Place a hold for an item. 3) Enable the new SIP option no_holds_checkin for a SIP account. 4) Restart the SIP server. 5) Check in the item using the SIP CLI tool using the SIP account for which you set the new option. 6) Note the checkin fails with a screen message indicating you should return the item to the circulation desk. Signed-off-by: Peter Lau <peter.lau@yccece.edu.hk> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108626|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109535&action=edit Bug 25541: Add new param to debian sip config Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109519|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109536&action=edit Bug 25541: (QA follow-up) Rename no_holds_checkin to holds_block_checkin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109537&action=edit Bug 25541: (QA follow-up) Defualt to disabled + Correct message This patch defaults the 'holds_block_checkin' configuration to disabled (to maintain current behaviour on upgrades). It also updates a copy/paste for siplog logging to make the message triggered by this action unique as expected. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well. I took the liberty of adding a final QA followup to correct a copy/paste of the log message and, as Tomas highlighted, correct the default behaviour to allow check-ins as is currently the case. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15729 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26896 [Bug 26896] SIP option holds_block_checkin does not actually block checkin of items on hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #19 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hi, I have a few questions about this BZ: - which level is checked during the return: the biblio-level or the item-level? If an hold is on an item-level, the return of another item from the same biblio shouldn't be blocked. - If an hold is "served" because an item is waiting or in transfer to another branch for a reserve, will the other items of the same biblio be blocked? They shouldn't be if an item is already here for the hold. Thanks for your explanations :-) ! Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Some libraries would like release notes| |patrons to be unable to | |return items with holds via | |SIP. Instead, the screen | |message should indicate | |that the patron should | |return that item at the | |circ desk so a librarian | |can use it to fill the next | |hold right away and place | |it on the hold shelf. This | |feature is enabled by | |adding the flag | |holds_block_checkin to an | |account in the SIP | |configuration file, and | |setting the value of it to | |"1". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25541 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 15729 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org