https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28014 [Bug 28014] Add table settings to batch patron modification -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- No, the issue is happening in the batch modification itself -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134205&action=edit Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-a... Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate, | |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134205|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134220&action=edit Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-a... Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134220|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134286&action=edit Bug 30628: Fix patron selection in batch patron modification tool bug 28014 added Datatables to this view, but the form is submitted with only the checkboxes from the first page. Solution adapted from https://stackoverflow.com/questions/33240409/how-to-submit-checkboxes-from-a... Test plan: Have more than 20 cardnumbers, use the batch patron modification tool Select (not all) patrons from the first page and second page Submit the form Notice that the patrons you have selected appear on the confirmation page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the batch patron |This fixes the batch patron release notes|modification (Tools > |modification tool (Tools > |Patrons and circulation > |Patrons and circulation > |Batch patron modification) |Batch patron modification) |so that the changes for all |so that the changes for all |selected patrons are |selected patrons are |modified. Before this, only |modified. Before this, only |the patrons listed on the |the patrons listed on the |current page were modified. |current page were modified. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 21.05.x branch for 21.05.16 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30628 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Needs documenting |RESOLVED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bugfix with not visual or workflow change. No documentation changes needed. -- You are receiving this mail because: You are watching all bug changes.