https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checking in a waiting hold |Checking in a waiting hold |at another branch \ when |at another branch when | |HoldsAutoFill is enabled | |causes errors Depends on| |23070 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- To recreate: 1 - Enable HoldsAutoFill 2 - Place a title level hold 3 - Check in an item and confirm hold 4 - Switch to another branch 5 - Checkin the item, get an error: Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1577. at /kohadevbox/koha/C4/Reserves.pm line 1576 6- This causes lingering issues because the hold is now in-transit but has no itemnumber Root seems to be in circ/returns.pl: 477 ModReserveAffect( $reserve->{itemnumber}, $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_ id}, $desk_id ); RevertWaitingStatus has already removed the itemnumber from the hold, passing $itemnumber (from scanned item) should work, as it will reattach the hold to the item Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134203|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 134208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134208&action=edit Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON RevertWaitingStatus has already removed the itemnumber from the hold, passing $itemnumber (from scanned item) should work, as it will reattach the hold to the item Test plan: 1 - Enable HoldsAutoFill 2 - Place a title level hold 3 - Check in an item and confirm hold 4 - Switch to another branch 5 - Checkin the item Without this patch you got Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1577. at /kohadevbox/koha/C4/Reserves.pm line 1576 With this patch applied the operation succeeds Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134208|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134218&action=edit Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON RevertWaitingStatus has already removed the itemnumber from the hold, passing $itemnumber (from scanned item) should work, as it will reattach the hold to the item Test plan: 1 - Enable HoldsAutoFill 2 - Place a title level hold 3 - Check in an item and confirm hold 4 - Switch to another branch 5 - Checkin the item Without this patch you got Can't call method "biblionumber" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1577. at /kohadevbox/koha/C4/Reserves.pm line 1576 With this patch applied the operation succeeds Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.06 |22.05.00,21.11.06,21.05.16 released in| | CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 21.05.x branch for 21.05.16 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30630 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Martin Renvoize contact| | -- You are receiving this mail because: You are watching all bug changes.