[Bug 33939] New: javascript needs to distinguish between order budgets and default budgets when adding to staged file form a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Bug ID: 33939 Summary: javascript needs to distinguish between order budgets and default budgets when adding to staged file form a basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org
From bug 22802 comment 10:
Add orders from MARC file "show inactive funds" is not checked expand the order div to see the details You see Fund: Select a fund (will use default if set) Check "show inactive funds" You see Select a fund (will populate orders/items if set) Uncheck "show inactive funds" You see Select a fund (will populate orders/items if set)
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 [Bug 22802] When ordering from a staged file, if funds are populated per item order level fund should not be required -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 152106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152106&action=edit Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately The dropdowns have different hints after bug 22802. We need to preserve those when adding or hiding inactive budgets To test: 1 - Add some inactive budgets to Koha 2 - Use the settings and file from bug 22802 to stage a file and begin adding to basket 3 - When adding to basket test the 'Show inactive funds' on both the 'Select to import' tab and the 'Default accounting details' tab 4 - Ensure the dropdown hints/defaults don't change when hiding/showing budgets 5 - Confirm inactive budgets are correctly shown/hidden -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152106|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 152658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152658&action=edit Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately The dropdowns have different hints after bug 22802. We need to preserve those when adding or hiding inactive budgets To test: 1 - Add some inactive budgets to Koha 2 - Use the settings and file from bug 22802 to stage a file and begin adding to basket 3 - When adding to basket test the 'Show inactive funds' on both the 'Select to import' tab and the 'Default accounting details' tab 4 - Ensure the dropdown hints/defaults don't change when hiding/showing budgets 5 - Confirm inactive budgets are correctly shown/hidden Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|javascript needs to |JavaScript needs to |distinguish between order |distinguish between order |budgets and default budgets |budgets and default budgets |when adding to staged file |when adding to staged file |form a basket |form a basket QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152658|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 153223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153223&action=edit Bug 33939: Preserve order budget dropdowns and default budget dropdowns seperately The dropdowns have different hints after bug 22802. We need to preserve those when adding or hiding inactive budgets To test: 1 - Add some inactive budgets to Koha 2 - Use the settings and file from bug 22802 to stage a file and begin adding to basket 3 - When adding to basket test the 'Show inactive funds' on both the 'Select to import' tab and the 'Default accounting details' tab 4 - Ensure the dropdown hints/defaults don't change when hiding/showing budgets 5 - Confirm inactive budgets are correctly shown/hidden Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Took me a little to figure out, but then it was obvious. Just a thought... can we please unify the fund pull downs to the nice one we worked out for the receive page... pretty please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33939 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.11.00,23.05.02,22.11.08 |23.11.00,23.05.02,22.11.08, released in| |22.05.16 CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.16 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org