[Bug 15306] New: Don't show translate link for item types if only one language is installed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Bug ID: 15306 Summary: Don't show translate link for item types if only one language is installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. I think the page should check for the existence of multiple installed languages before showing the link. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46388&action=edit Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Enable only 1 language at the OPAC and the intranet. Edit an item type and confirm that the link "translate into..." is not displayed. Enable 1+ languages at the intranet and 1 at the opac, confirm that the link is displayed. Enable 1 language at the intranet and 1+ at the opac, confirm that the link is displayed. Enable 1+ language at the intranet and 1+ at the opac, confirm that the link is displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14828 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 [Bug 14828] Move the item types related code to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Another version of the patch could be provided to apply on top of 3.22. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- I'm not sure about taking enabled languages as a trigger for displaying the translation link. Use case for a country with multiple languages: - I have an installation with let's say English, German, French, Italian - English is and German are enabled. - Now I want to prepare my installation for French and / or Italian. I do all the translation work, but do not yet want to enbale the languages until I'm finished, e.g. because everithing has to be reviewed befor the new language is officially launched. With this patch, the translations would be have to be already visible while translating. Alternative: Use the _installed_ language as a trigger. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46391&action=edit [ALTERNATIVE-PATCH] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46388|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 46394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46394&action=edit Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Works as expected. Tested with English only installed. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 --- Comment #6 from Marc Véron <veron@veron.ch> --- @Owen: What do you think, is the alternative patch OK for you? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46394|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Comment on attachment 46394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46394 Bug 15306: Do not display the translate link if only 1 language is installed I think my sign-off here was on the alternative patch, but to make it sure I obsolete this one and sgn-off again on the alternative patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46391|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 46480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46480&action=edit [ALTERNATIVE-PATCH] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46480|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46483&action=edit Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just removed a trailing warn -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46483|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46764&action=edit [PASSED QA] Bug 15306: Do not display the translate link if only 1 language is installed It doesn't make sense to offer the option to translate an item type description into another language if there is only one language installed. Test plan: Generates templates for only 1 language Edit an item type and confirm that the link "translate into..." is not displayed. Generates templates for another language Confirm that the link is now displayed. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org