http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9743 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This report adds three cases where you could want to require a note when placing a hold. Each of these cases may be enabled separately via a system preference. (The hold note itself is triggered by OpacHoldNotes.) The three cases are: serial indication in the leader, collection indication in the leader, and MARC 300$a contains an indication of multiple parts/volumes (identified via a regular expression). A new sub in Reserves handles these cases and will be easily extensible. A unit test will be provided too. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 46688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46688&action=edit Bug 15545: Optionally require notes when placing a hold This report adds three cases where you could want to require a note when placing a hold. Each of these cases may be enabled separately via the system preference HoldNoteReasons. (The hold note itself is triggered by OpacHoldNotes.) These three cases are: [1] serial indication in the leader (called LEADER_SERIAL) [2] collection indication in the leader (LEADER_COLLECTION) [3] MARC 300$a contains an indication of multiple parts/volumes, as identified by a regular expression (MARC300A_PARTS). The new sub IsHoldNoteRequired in Reserves.pm handles these cases. And will be easily extensible. Also this patch removes some unused code in the reserves template for mandatory hold notes reasons. Test plan: [1] Enable OpacHoldNotes. Set HoldNoteReasons to LEADER_SERIAL. [2] In OPAC, place a hold on a serial record (with correct leader). Verify that the hold notes are required. [3] Set HoldNoteReasons to MARC300A_PARTS. Verify that the hold notes are no longer required for the record in the preceding step. (This actually depends on your 300$a..) Cancel the hold you placed. [4] Add "2 vols" to MARC 300$a in the same record. Try to place the hold again. The hold notes should be required again. [5] Place a multiple hold request with the same record and another one. Click Place Hold while more-options is collapsed (blank notes). Is the correct hold note made visible? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Would the need for this feature be eliminated if it was possible to limit item-level holds to the types of records defined in this patch? That is, serials, titles with volumes, etc? If so, shouldn't we be solving that problem instead? -- You are receiving this mail because: You are watching all bug changes.