https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16299 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50434&action=edit Bug 16299 - Use validation plugin when creating a patron attribute type This patch replaces custom client-side form validation with use of the jQuery validation plugin. Besides reducing the amount of code in the template, this allows us to eliminate use of "onclick." This patch also makes a correction for HTML validity: <option value="" /> is not accepted. I have also added an id attribute to a <select> which lacked it. To test, apply the patch and go to Administration -> Patron attribute types. - Test creating a new patron attribute type. Try to submit the form without a code, description, or both. You should be prevented from doing so. - Test editing an existing patron attribute type. You should not be able to remove the description and have it save successfully. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16299 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16299 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50499|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50596&action=edit Bug 16299 - Use validation plugin when creating a patron attribute type This patch replaces custom client-side form validation with use of the jQuery validation plugin. Besides reducing the amount of code in the template, this allows us to eliminate use of "onclick." This patch also makes a correction for HTML validity: <option value="" /> is not accepted. I have also added an id attribute to a <select> which lacked it. To test, apply the patch and go to Administration -> Patron attribute types. - Test creating a new patron attribute type. Try to submit the form without a code, description, or both. You should be prevented from doing so. - Test editing an existing patron attribute type. You should not be able to remove the description and have it save successfully. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.