https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16308 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50460&action=edit Bug 16308 - Remove the use of "onclick" from Z39.50/SRU servers template This patch removes the use of event attributes in the markup in favor of attaching events in JavaScript. This patch also revises the SRU search fields mapping template considerably while correcting multiple HTML validation issues: - Corrected label/id pairs. - Corrected incorrect capitalization. - Removed redundant <legend> - Restructured form so that it displays in two columns. Also changed in the z3950 servers template: Replaced empty [% script_name %] variable with actual path. To test, apply the patch and go to Administration -> Z39.50/SRU servers/ - In the list of servers, select Actions -> Delete. You should be prompted to confirm your choice. Test both confirming and cancelling. - Create or edit an SRU server. - After entering text in the server name field, moving to the next field should trigger transformation of that text to upper case. - On the SRU Search fields mapping line, clicking the "Modify" button should trigger a popup. - In the "Modify SRU search fields mapping" popup: - The fields should display in two columns. - All labels should be correctly associated with corresponding inputs. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16308 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50465|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50625&action=edit [PASSED QA] Bug 16308 - Remove the use of "onclick" from Z39.50/SRU servers template This patch removes the use of event attributes in the markup in favor of attaching events in JavaScript. This patch also revises the SRU search fields mapping template considerably while correcting multiple HTML validation issues: - Corrected label/id pairs. - Corrected incorrect capitalization. - Removed redundant <legend> - Restructured form so that it displays in two columns. Also changed in the z3950 servers template: Replaced empty [% script_name %] variable with actual path. To test, apply the patch and go to Administration -> Z39.50/SRU servers/ - In the list of servers, select Actions -> Delete. You should be prompted to confirm your choice. Test both confirming and cancelling. - Create or edit an SRU server. - After entering text in the server name field, moving to the next field should trigger transformation of that text to upper case. - On the SRU Search fields mapping line, clicking the "Modify" button should trigger a popup. - In the "Modify SRU search fields mapping" popup: - The fields should display in two columns. - All labels should be correctly associated with corresponding inputs. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.