[Bug 35983] New: Branch specific Refund lost item replacement fee cannot be 'refund_unpaid'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Bug ID: 35983 Summary: Branch specific Refund lost item replacement fee cannot be 'refund_unpaid' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Admin > Circ & fine rules 2. Select a library at the top of the forms ( #selectlibrary ) 3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)". 4. Press save and let the page reload. 5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161719&action=edit Bug 35983: Remove extra seleted=selected from dropdown menu To test: 1. Admin > Circ & fine rules 2. Select a library at the top of the forms ( #selectlibrary ) 3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)". 4. Press save and let the page reload. 5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine". 6. APPLY PATCH 7. Try steps 2 - 5 again but this time the value in the dropdown should not change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161719|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 161858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161858&action=edit Bug 35983: Remove extra seleted=selected from dropdown menu To test: 1. Admin > Circ & fine rules 2. Select a library at the top of the forms ( #selectlibrary ) 3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)". 4. Press save and let the page reload. 5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine". 6. APPLY PATCH 7. Try steps 2 - 5 again but this time the value in the dropdown should not change. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161858|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 162299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162299&action=edit Bug 35983: Remove extra seleted=selected from dropdown menu To test: 1. Admin > Circ & fine rules 2. Select a library at the top of the forms ( #selectlibrary ) 3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)". 4. Press save and let the page reload. 5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine". 6. APPLY PATCH 7. Try steps 2 - 5 again but this time the value in the dropdown should not change. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Passed QA --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Good catch - thanks for the fix! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Branch specific Refund lost |Library specific refund |item replacement fee cannot |lost item replacement fee |be 'refund_unpaid' |cannot be 'refund_unpaid' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.04 |24.05.00,23.11.04,23.05.10 released in| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35983 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org