[Bug 35800] New: edit_any_item permission required to see patron name in detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Bug ID: 35800 Summary: edit_any_item permission required to see patron name in detail page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com A staff member with limited permissions (mostly circulation-related) cannot see the name of the patron who has checked out an item from the detail page, if the patron is from another library, even if the staff member has view_borrower_infos_from_any_libraries. To recreate: 1. Check out an item to a patron from library A 2. Give permissions to a patron from library B (example of a circulation staff account) - circulate - catalogue - borrowers - reserveforothers - updatecharges - suggestions - lists - clubs -> enroll 3. If necessary, change the username and password of that staff member in order to be able to log in 4. In a private browser window, log in as the staff member 5. View the record with the checked out item --> Notice that it only says "Checked out" without any patron name 6. Back in the normal browser, give the additional permission "edit_any_item" to the staff member 7. Refresh the page in the private window (Ctrl+F5) --> Notice the name of the patron now appears I don't think not having the option to edit items from any library should impact the visibility of patron information. This should be managed by view_borrower_infos_from_any_libraries. With git bisect, I found that it was related to bug 33167, although I don't understand what happened... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 [Bug 33167] Cleanup staff interface catalog details page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #1 from Donna <bwsdonna@gmail.com> --- Caroline is absolutely correct - edit_any_item should not prevent staff from being able to see who has the item checked out, it should depend on view_borrower_infos_from_any_libraries -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Im not sure why there is a check for [% IF item.can_be_edited %] before displaying the patron name. That seems to be what is wrong here. Removing this check will make this work properly and honor 'view_borrower_infos_from_any_libraries' instead of 'edit_any_items'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161313&action=edit Bug 35800: Remove item.can.be.edited check To test: APPLY PATCH 1. Check out an item to a patron from library A 2. Give permissions to a patron from library B (example of a circulation staff account) - circulate - catalogue - borrowers ( including view_borrower_infos_from_any_libraries ) - reserveforothers - updatecharges - suggestions - lists - clubs -> enroll 3. If necessary, change the username and password of that staff member in order to be able to log in 4. In a private browser window, log in as the staff member 5. View the record with the checked out item 6. You should see the name/cardnumber of the patron the item is checked out ot. 7. Turn off the view_borrower_infos_from_any_libraries for this patron. 8. Now on the record detail page you should see text like `Checked out to A patron from library Midway : due 01/28/2024`. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Carolyn Hughesman <chughesman@cclsny.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman@cclsny.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Enica Davis <enica@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |enica@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161313|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 161316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161316&action=edit Bug 35800: Remove item.can.be.edited check To test: APPLY PATCH 1. Check out an item to a patron from library A 2. Give permissions to a patron from library B (example of a circulation staff account) - circulate - catalogue - borrowers ( including view_borrower_infos_from_any_libraries ) - reserveforothers - updatecharges - suggestions - lists - clubs -> enroll 3. If necessary, change the username and password of that staff member in order to be able to log in 4. In a private browser window, log in as the staff member 5. View the record with the checked out item 6. You should see the name/cardnumber of the patron the item is checked out ot. 7. Turn off the view_borrower_infos_from_any_libraries for this patron. 8. Now on the record detail page you should see text like `Checked out to A patron from library Midway : due 01/28/2024`. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161316|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 161508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161508&action=edit Bug 35800: Remove item.can.be.edited check To test: APPLY PATCH 1. Check out an item to a patron from library A 2. Give permissions to a patron from library B (example of a circulation staff account) - circulate - catalogue - borrowers ( including view_borrower_infos_from_any_libraries ) - reserveforothers - updatecharges - suggestions - lists - clubs -> enroll 3. If necessary, change the username and password of that staff member in order to be able to log in 4. In a private browser window, log in as the staff member 5. View the record with the checked out item 6. You should see the name/cardnumber of the patron the item is checked out ot. 7. Turn off the view_borrower_infos_from_any_libraries for this patron. 8. Now on the record detail page you should see text like `Checked out to A patron from library Midway : due 01/28/2024`. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Bug fix ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Marcel de Rooy from comment #7)
Bug fix ?
You're right. I changed the "importance" to minor instead of enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I noticed this in 23.05 btw. So if it could be backported, it would be great! Thanks! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Elise Konya <elise.konya@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elise.konya@bywatersolution | |s.com --- Comment #12 from Elise Konya <elise.konya@bywatersolutions.com> --- Seconding Caroline's request! Could this be backported to 23.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.03 |24.05.00,23.11.03,23.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35800 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org