[Bug 21639] New: Phone notice transports do not exist for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Bug ID: 21639 Summary: Phone notice transports do not exist for new installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org SELECT * FROM message_transports; there are no phone transports Enable TalkingTechItivaPhoneNotification and EnhancedMessagingPreferences Open a patron Note you can see phone as an option, but not check it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81044&action=edit Bug 21639: Add phone transports to new and existing installs To test: 1 - Confirm if you do or do not have 'phone' transports defined in the message_transports table 2 - Apply patch 3 - Run updatedatabase 4 - If you didn't have them you should now 5 - Run updatedatabase again, confirm it doesn't error 6 - sudo koha-mysql kohadev 7 - DELETE from message_transports WHERE message_transport_type = 'phone' 8 - Run updatedatabase again 9 - Confirm the message transports table is restored 10 - Drop your DB (or reset_all in kohadevbox) 11 - Ensure the table is fully populated including phone notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 81044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81044 Bug 21639: Add phone transports to new and existing installs Review of attachment 81044: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21639&attachment=81044) ----------------------------------------------------------------- ::: installer/data/mysql/en/mandatory/sample_notices_message_transports.sql @@ -4,5 @@
(1, 'email', 0, 'circulation', 'DUE'), (1, 'email', 1, 'circulation', 'DUEDGST'), -(2, 'email', 0, 'circulation', 'PREDUE'), -(2, 'email', 1, 'circulation', 'PREDUEDGST'), -(4, 'email', 0, 'reserves', 'HOLD'),
I know sorting is prettier, but a smaller patch with just phone would be easier to eyeball. :P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81044|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 81077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81077&action=edit Bug 21639: Add phone transports to new and existing installs To test: 1 - Confirm if you do or do not have 'phone' transports defined in the message_transports table 2 - Apply patch 3 - Run updatedatabase 4 - If you didn't have them you should now 5 - Run updatedatabase again, confirm it doesn't error 6 - sudo koha-mysql kohadev 7 - DELETE from message_transports WHERE message_transport_type = 'phone' 8 - Run updatedatabase again 9 - Confirm the message transports table is restored 10 - Drop your DB (or reset_all in kohadevbox) 11 - Ensure the table is fully populated including phone notices Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #2)
I know sorting is prettier, but a smaller patch with just phone would be easier to eyeball. :P
Agreed, especially because you are going to provide the same changes for all the other languages now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81085&action=edit Bug 21639: Adjust the other languages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- installer/data/mysql/uk-UA/mandatory/sample_notices_message_transports.sql will fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81077|0 |1 is obsolete| | Attachment #81085|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81169&action=edit Bug 21639: Add phone transports to new and existing installs To test: 1 - Confirm if you do or do not have 'phone' transports defined in the message_transports table 2 - Apply patch 3 - Run updatedatabase 4 - If you didn't have them you should now 5 - Run updatedatabase again, confirm it doesn't error 6 - sudo koha-mysql kohadev 7 - DELETE from message_transports WHERE message_transport_type = 'phone' 8 - Run updatedatabase again 9 - Confirm the message transports table is restored 10 - Drop your DB (or reset_all in kohadevbox) 11 - Ensure the table is fully populated including phone notices Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81170&action=edit Bug 21639: Adjust the other languages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81171&action=edit Bug 21639: (follow-up) Adjust the other languages uk-UA was wrong. We should use the same file for all languages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651 [Bug 21651] Force insert of notices related tables during the install process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21639 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer to avoid DB changes in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org