[Bug 21629] New: List sort on call number does not use cn_sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Bug ID: 21629 Summary: List sort on call number does not use cn_sort Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: mkstephens@lancasterseminary.edu QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When viewing a list in the staff client, one can click on the "Call Number" column to have the list sort to call number order. I am noticing that the order does not sort correctly by cn_sort value. For example, we use LC Classification in our library. When clicking the "Call Number" column to sort in ascending order, Koha put these call numbers in this (incorrect) order: - BV4011.3 .W55 2016 - BV5 .W54 1980 - BV811.2 .W44 1980 - BV825.2 .W54 1981 This problem also appears when a list's settings are set to order by call number. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|18.05 |master --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This sounds more like an enhancement request. The sort is done by the DBMS (MySQL/MariaDB) and it will not be trivial to make it sort the results according to the cn_sort. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Why would it not be trivial? It would be just a different column to use? (it's also a sort with SQL) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80990&action=edit Bug 21629: Use cn_sort instead of itemcallnumber when displaying a list DBMS can sort callnumbers correctly using cn_sort. We should use it showing a list's content. Test plan: - Add items with callnumber to a list - Display the list - List the content by callnumbers => Confirm that the records are correctly sorted by callnumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #2)
Why would it not be trivial? It would be just a different column to use? (it's also a sort with SQL)
Indeed, I was thinking about something else! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80990|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 81000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81000&action=edit Bug 21629: Use cn_sort instead of itemcallnumber when displaying a list DBMS can sort callnumbers correctly using cn_sort. We should use it showing a list's content. Test plan: - Add items with callnumber to a list - Display the list - List the content by callnumbers => Confirm that the records are correctly sorted by callnumber Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 --- Comment #7 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- I can confirm that the patch applied to a sandbox sorted a list by call number correctly. I imported some MARC records from my library's catalog into the sandbox that are not sorting correctly in 18.05. They did sort correctly in the sandbox. Yay! Thank you for writing the patch so quickly!! Myka -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you Myka for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81000|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81292&action=edit Bug 21629: Use cn_sort instead of itemcallnumber when displaying a list DBMS can sort callnumbers correctly using cn_sort. We should use it showing a list's content. Test plan: - Add items with callnumber to a list - Display the list - List the content by callnumbers => Confirm that the records are correctly sorted by callnumber Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Item lists were previously release notes| |being sorted by itemnumber. | |This patch changes that to | |sort by cn_sort to match | |other similar displays. Status|Pushed to Stable |Pushed to Master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Item lists were previously |With this patch lists release notes|being sorted by itemnumber. |sorted on call number will |This patch changes that to |now use the machine |sort by cn_sort to match |sortable form of the |other similar displays. |callnumber from | |items.cn_sort for better | |results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19915 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21629 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I prefer to not push to 17.11.x. In case cn_sort calculation is not well configured. I bet it will be better validated during a major version upgrade. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org