[Bug 32969] New: Remove references to jQueryUI assets and style in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Bug ID: 32969 Summary: Remove references to jQueryUI assets and style in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: david@davidnind.com, dcook@prosentient.com.au, jonathan.druart+koha@gmail.com, testopia@bugs.koha-community.org Depends on: 30570 Blocks: 29222 Now that we've updated the OPAC to use Bootstrap tabs, tooltips, etc, we can remove jQueryUI assets and portions of our CSS which were only relevant to jQueryUI elements. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29222 [Bug 29222] OMNIBUS: Replace the use of jQueryUI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146692&action=edit Bug 32969: Remove references to jQueryUI assets and style in the OPAC This patch removes the jQueryUI assets from Bootstrap OPAC files and removes the links to those assets from the templates. References in CSS to jQueryUI-related elements are also removed. To test, apply the patch and rebuild the OPAC CSS. Test various pages in the OPAC to confirm that there are no visible changes. The browser console should not warn of missing files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32998 [Bug 32998] Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I found some remaining references ui-tabs: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt: ul.ui-tabs-nav li a, ul.ui-tabs-nav li span.a { padding:0.6em 1em; } koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt: <style>ul.ui-tabs-nav li a, ul.ui-tabs-nav li span.a { padding:0.6em 1em; }</style> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <div class="toptabs ui-tabs ui-widget ui-widget-content ui-corner-all"> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <ul class="ui-tabs-nav ui-helper-reset ui-helper-clearfix ui-widget-header ui-corner-all"> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <li id="privateshelves_tab" class="ui-state-default ui-corner-top ui-tabs-active ui-state-active"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=0">Your lists</a></li> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <li id="privateshelves_tab" class="ui-state-default ui-corner-top"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=0">Your lists</a></li> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <li id="publicshelves_tab" class="ui-state-default ui-corner-top ui-tabs-active ui-state-active"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=1">Public lists</a></li> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <li id="publicshelves_tab" class="ui-state-default ui-corner-top"><a class="ui-tabs-anchor" href="/cgi-bin/koha/opac-shelves.pl?op=list&public=1">Public lists</a></li> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <div id="privateshelves" class="ui-tabs-panel ui-widget-content ui-corner-bottom" style="display:block;"> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: <div id="publicshelves" class="ui-tabs-panel ui-widget-content ui-corner-bottom" style="display:block;"> Did we miss a patch maybe? I did run the yarn build, but with the patch applied, the list view (list of lists) is indeed broken. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 [Bug 33031] Update OPAC lists page to use Bootstrap markup for tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147263&action=edit Bug 32969: (follow-up) Remove obsolete inline CSS A couple of templates have some inline CSS intended to style jQueryUI tabs. These instances can be removed: - opac-readingrecord.tt: Tabs have been replaced with Bootstrap. - opac-idref.tt: There doens't appear to be any tab-related markup in the template at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146692|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147266&action=edit Bug 32969: Remove references to jQueryUI assets and style in the OPAC This patch removes the jQueryUI assets from Bootstrap OPAC files and removes the links to those assets from the templates. References in CSS to jQueryUI-related elements are also removed. To test, apply the patch and rebuild the OPAC CSS. Test various pages in the OPAC to confirm that there are no visible changes. The browser console should not warn of missing files. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147263|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147267&action=edit Bug 32969: (follow-up) Remove obsolete inline CSS A couple of templates have some inline CSS intended to style jQueryUI tabs. These instances can be removed: - opac-readingrecord.tt: Tabs have been replaced with Bootstrap. - opac-idref.tt: There doens't appear to be any tab-related markup in the template at all. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147266|0 |1 is obsolete| | Attachment #147267|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148677&action=edit Bug 32969: Remove references to jQueryUI assets and style in the OPAC This patch removes the jQueryUI assets from Bootstrap OPAC files and removes the links to those assets from the templates. References in CSS to jQueryUI-related elements are also removed. To test, apply the patch and rebuild the OPAC CSS. Test various pages in the OPAC to confirm that there are no visible changes. The browser console should not warn of missing files. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148678&action=edit Bug 32969: (follow-up) Remove obsolete inline CSS A couple of templates have some inline CSS intended to style jQueryUI tabs. These instances can be removed: - opac-readingrecord.tt: Tabs have been replaced with Bootstrap. - opac-idref.tt: There doens't appear to be any tab-related markup in the template at all. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Bug 32969 depends on bug 33031, which changed state. Bug 33031 Summary: Update OPAC lists page to use Bootstrap markup for tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org