[Bug 32945] New: Capitalization: id (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Bug ID: 32945 Summary: Capitalization: id (part 2) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32222 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146519&action=edit Bug 32945: Fix capitalization of id in more places id should be spelled ID, ids should be IDs as it's an abbreviation according to: https://www.oxfordlearnersdictionaries.com/definition/english/identification To test: * Some of these are hard to make happen or require specific data, easiest will be to review the patch itself closely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146519|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146577&action=edit Bug 32945: Fix capitalization of id in more places id should be spelled ID, ids should be IDs as it's an abbreviation according to: https://www.oxfordlearnersdictionaries.com/definition/english/identification To test: * Some of these are hard to make happen or require specific data, easiest will be to review the patch itself closely. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Found those ones: koha-tmpl/intranet-tmpl/prog/en/modules/tools/showdiffmarc.tt: <p>The record id <em>[% RECORDID | html %]</em> doesn't match any existing record.</p> koha-tmpl/intranet-tmpl/prog/en/modules/tools/showdiffmarc.tt: <p>The import id number <em>[% IMPORTID | html %]</em> doesn't match any existing record.</p> koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt: <span>The authority id [% message.authid | html %] does not exist in the database.</span> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt: <p>A payment with the transaction id '[% message_value | html %]' has already been posted to an account.</p> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt: <p>The transaction id '[% message_value | html %]' for this payment is invalid.</p> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: ERROR: No record found for record id [% bad_biblionumber | html %]. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt: ERROR: No record id specified. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146577|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147276&action=edit Bug 32945: Fix capitalization of id in more places id should be spelled ID, ids should be IDs as it's an abbreviation according to: https://www.oxfordlearnersdictionaries.com/definition/english/identification To test: * Some of these are hard to make happen or require specific data, easiest will be to review the patch itself closely. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147277&action=edit Bug 32945: (QA follow-up) Fix capitalization of id in even more places This fixes additional strings pointed out by QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147276|0 |1 is obsolete| | Attachment #147277|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148586&action=edit Bug 32945: Fix capitalization of id in more places id should be spelled ID, ids should be IDs as it's an abbreviation according to: https://www.oxfordlearnersdictionaries.com/definition/english/identification To test: * Some of these are hard to make happen or require specific data, easiest will be to review the patch itself closely. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148587&action=edit Bug 32945: (QA follow-up) Fix capitalization of id in even more places This fixes additional strings pointed out by QA. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org