[Bug 28658] New: With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Bug ID: 28658 Summary: With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: michael.hafen@washk12.org QA Contact: testopia@bugs.koha-community.org If the SearchMyLibraryFirst syspref is set, the OPAC uses the logged in users branchcode to limit searches to their library. If it's an anonymous session that doesn't happen. This tries to guess the client library by checking for the client ip address in each libraries branchip setting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 --- Comment #1 from Michael Hafen <michael.hafen@washk12.org> --- Created attachment 122573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122573&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28657 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657 [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |michael.hafen@washk12.org --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Is this ready for testing? If so please set the status to "Needs Signoff." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Hi Micheal, The dependency for this bug, Bug 28657, no longer applies cleanly to master. Therefore I am going to set this one to blocked until 28657 is rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #4 from Michael Hafen <michael.hafen@washk12.org> --- Bug 28657 has been rebased. Test plan: 1. Turn on SearchMyLibraryFirst system preference. 2. Make sure your computers ip address is covered by a branch's branchip. 3. Go to opac. 4. Observe that the branch isn't set. 5. Apply patch. Restart things if necessary 6. Reload opac. 7. Observe that the branch is set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Hi Michael, The dependency bug, Bug 28657, still does not apply cleanly to master. Auto-merging C4/Auth.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 28657: expand branches.branchip to allow for multiple ip ranges. [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28657-expand-branchesbranchip-to-allow-for-mul-gxoeH0.patch Cannot apply cleanly patches from bug 28657. Everything will be left dirty. I'm going to mark this bug as blocked again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #6 from Michael Hafen <michael.hafen@washk12.org> --- Bug 28657 has been rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149432&action=edit Bug 28658 - With SearchMyLibraryFirst guess the opac clients library If the SearchMyLibraryFirst syspref is set, the OPAC uses the logged in users branchcode to limit searches to their library. If it's an anonymous session that doesn't happen. This tries to guess the client library by checking for the client ip address in each libraries branchip setting. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Setting to Blocked. Dependency is in FQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #9 from Michael Hafen <michael.hafen@washk12.org> --- Setting back to Signed Off. Dependency is back to Needs signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|With SearchMyLibraryFirst |With SearchMyLibraryFirst: |if library isn't set for |If library isn't set for |the opac, try to guess it |the OPAC, try to guess it |by checking branchip |by checking branchip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is currently BLOCKED - we need a sign-off on the dependency first. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org