[Bug 5184] New: Upgrade to support jQuery 1.4.2
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Summary: Upgrade to support jQuery 1.4.2 Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: robin@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 We accidentally upgraded the jQuery to 1.4.2, from the 1.3.2 bundled with Koha. This broke the background processing code, in particular with the bulk modification functions. This ticket is to track the handling of workarounds and fixes dealing with this, in particular fixing the bits that are broken with newer jQuery versions. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> 2010-08-30 05:26:15 UTC --- Created attachment 2584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2584 Makes the packages use the bundled version of jquery This forces the packages to use the version of jquery that comes with koha, rather than the system version. It's a stopgap until real changes allow us to track the newer versions. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED AssignedTo|oleonard@myacpl.org |robin@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> 2011-01-09 23:02:10 UTC --- I found another error that occurs with the newer jQuery: the opac patron's details page selects the 'Fines & Charges' tab by default, but appears as though it's selected the 'Checkouts' list. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-01-10 13:42:22 UTC ---
I found another error that occurs with the newer jQuery: the opac patron's details page selects the 'Fines & Charges' tab by default
I'm hoping that we can coordinate the jQuery upgrade with the addition of jQueryUI and at least partial implementation of the YUI replacement. I've made a lot of progress towards that, including a reimplementation of tabs. My work can be found in a branch called "ip-bug-5481-jquery-ui-2010-12-09" at http://gitorious.org/koha-dev/koha-dev -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #4 from Liz Rea <wizzyrea@gmail.com> 2011-04-01 18:17:55 UTC --- it's not only the opac, it's also in the staff client on detail view: selects the 'Fines & Charges' tab by default, but appears as though it's selected the 'Checkouts' list. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-30 08:17:27 UTC --- Whats the latest with this? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> 2011-05-30 22:31:23 UTC --- I snuck the patch here into the 3.4.1 package updates. The jquery updates will eventually need to happen, but the patch here doesn't need to be worried about any more. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |--- -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2584|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|robin@catalyst.net.nz |oleonard@myacpl.org Summary|Upgrade to support jQuery |Upgrade jQuery to the |1.4.2 |latest version -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9229&action=edit Bug 5184 - Upgrade jQuery to the latest version Upgrade jQuery in the OPAC. To test: Try any JavaScript-dependent interaction you can think of in the OPAC and watch for errors. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9229|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9232&action=edit Bug 5184 [REVISED] Upgrade jQuery to the latest version (OPAC) Upgrade jQuery in the OPAC. To test: Try any JavaScript-dependent interaction you can think of in the OPAC and watch for errors. Revision updates the one syntax I've found so far in testing which requires an update. Where we used to do this to uncheck a checkbox: $(foo).attr("checked",""); We should now use: $(foo).removeAttr("checked"); As far as I can tell the old way will not generate an error but neither will it work. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- I'm testing a patch for the staff client and have taken care of the examples of the above syntax changes. Julian, did you say you had tested a jQuery upgrade in the staff client before? Do you remember what bugs you ran into? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9235&action=edit Bug 5184 - Upgrade jQuery to the latest version (staff client) Upgrade jQuery in the staff client. Besides the change to the jQuery file syntax has been changed wherever this syntax was written: $(foo).attr("checked",""); The new correct way to un-check a checkbox: $(foo).removeAttr("checked"); I also removed some JavaScript altogether from branch-transfer-limits.tt which used the old syntax but which wasn't used on the page at all anymore. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- A patch for the staff client is attached in case anyone is eager to get started testing. I've done only limited testing so far but will do more. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9232|0 |1 is obsolete| | Attachment #9235|0 |1 is obsolete| | --- Comment #12 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9285&action=edit [SIGNED-OFF] Bug 5184 [REVISED] Upgrade jQuery to the latest version (OPAC) Upgrade jQuery in the OPAC. To test: Try any JavaScript-dependent interaction you can think of in the OPAC and watch for errors. Revision updates the one syntax I've found so far in testing which requires an update. Where we used to do this to uncheck a checkbox: $(foo).attr("checked",""); We should now use: $(foo).removeAttr("checked"); As far as I can tell the old way will not generate an error but neither will it work. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #13 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 9286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9286&action=edit [SIGNED-OFF] Bug 5184 - Upgrade jQuery to the latest version (staff client) Upgrade jQuery in the staff client. Besides the change to the jQuery file syntax has been changed wherever this syntax was written: $(foo).attr("checked",""); The new correct way to un-check a checkbox: $(foo).removeAttr("checked"); I also removed some JavaScript altogether from branch-transfer-limits.tt which used the old syntax but which wasn't used on the page at all anymore. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|Needs Signoff |Signed Off CC| |cnighswonger@foundations.ed | |u --- Comment #14 from Chris Nighswonger <cnighswonger@foundations.edu> --- I checked through various parts paying more attention to the cataloging module and did not scare up any errors. I'm signing off because this really needs to be pushed on up so that we have the full release cycle to fully debug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #15 from Chris Nighswonger <cnighswonger@foundations.edu> --- The latest version appears to be 1.8.19, so I wonder if we need top update these patches to reflect that? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- That's jQueryUI's version. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9286|0 |1 is obsolete| | --- Comment #17 from Mason James <mtj@kohaaloha.com> --- Created attachment 9356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9356&action=edit Bug 5184 - Upgrade jQuery to the latest version (staff client) Upgrade jQuery in the staff client. Besides the change to the jQuery file syntax has been changed wherever this syntax was written: $(foo).attr("checked",""); The new correct way to un-check a checkbox: $(foo).removeAttr("checked"); I also removed some JavaScript altogether from branch-transfer-limits.tt which used the old syntax but which wasn't used on the page at all anymore. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9285|0 |1 is obsolete| | --- Comment #18 from Mason James <mtj@kohaaloha.com> --- Created attachment 9357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9357&action=edit Bug 5184 [REVISED] Upgrade jQuery to the latest version (OPAC) Upgrade jQuery in the OPAC. To test: Try any JavaScript-dependent interaction you can think of in the OPAC and watch for errors. Revision updates the one syntax I've found so far in testing which requires an update. Where we used to do this to uncheck a checkbox: $(foo).attr("checked",""); We should now use: $(foo).removeAttr("checked"); As far as I can tell the old way will not generate an error but neither will it work. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9357|0 |1 is obsolete| | --- Comment #19 from Mason James <mtj@kohaaloha.com> --- Created attachment 9358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9358&action=edit Bug 5184 - Upgrade jQuery to the latest version (staff client) Upgrade jQuery in the staff client. Besides the change to the jQuery file syntax has been changed wherever this syntax was written: $(foo).attr("checked",""); The new correct way to un-check a checkbox: $(foo).removeAttr("checked"); I also removed some JavaScript altogether from branch-transfer-limits.tt which used the old syntax but which wasn't used on the page at all anymore. Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7747 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comment: Good news :) Changelog from v1.3 is available here: http://webscripts.softpedia.com/scriptViewChangelog/jQuery-Javascript-Librar... A lot of functions are very useful. Marked as Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7977 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Why are there duplicate patches for the staff client and why did the OPAC patch get obsoleted? There should be two patches: one for the staff client and one for the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #22 from Chris Nighswonger <cnighswonger@foundations.edu> --- It looks like Mason may have mistakenly attached the signed-off patch for staff twice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9358|0 |1 is obsolete| | --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 9358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9358 Bug 5184 - Upgrade jQuery to the latest version (staff client) removing (duplicated) patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #24 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed, and mail sent to koha-devel to warn for this major upgrade of jquery -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9357|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 --- Comment #25 from Paul Poulain <paul.poulain@biblibre.com> --- I missed to unobsolete the OPAC patch, and pushed it. Thx kf for pointing my mistake. OPAC patch pushed (tiny patch, passed QA) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8078 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Version|rel_3_10 |master Resolution|FIXED |--- --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Reopened for new version (1.8.0). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9357|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- A separate bug has been created for the upgrade to 1.10.3, Bug 11570. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org