[Bug 7747] New: Replace YUI autocomplete with jQueryUI
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Priority: P5 - low Change sponsored?: --- Bug ID: 7747 Assignee: oleonard@myacpl.org Blocks: 5481 Summary: Replace YUI autocomplete with jQueryUI QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha In order to make the transition to jQueryUI easier to test and get approval for, I will submit my jQueryUI work one "widget" at a time: autocomplete, tabs, datepicker, etc. First will be autocomplete as it touches the fewest files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9368&action=edit Bug 7747 - Replace YUI autocomplete with jQueryUI In order to facilitate a more painless process for converting to jQueryUI I will submit separate patches for various "widgets," starting with Autocomplete. This patch replaces all instances of YUI autocomplete with a jQueryUI version. The patch includes an up-to-date version of jQuery and jQueryUI libraries. The patch also moves some markup in instances where it should have been removed in favor of a different include. To test, find the various autocomplete instances and confirm that they are working: - Circulation search header autocomplete - Overdues patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Authorities search plugin. Edit a MARC record and use an authorities plugin link to do a search for authority records. Incomplete: There is a YUI autocomplete instance in a UNIMARC plugin (unimarc_field_210c_bis.tt) which I couldn't figure out how to test, even on a sandbox set up with UNIMARC. I could use help with a follow-up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5184 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9368|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9741&action=edit Bug 7747 - Replace YUI autocomplete with jQueryUI In order to facilitate a more painless process for converting to jQueryUI I will submit separate patches for various "widgets," starting with Autocomplete. This patch replaces all instances of YUI autocomplete with a jQueryUI version. The patch includes an up-to-date version of jQuery and jQueryUI libraries. The patch also moves some markup in instances where it should have been removed in favor of a different include. To test, find the various autocomplete instances and confirm that they are working: - Circulation search header autocomplete - Overdues patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Authorities search plugin. Edit a MARC record and use an authorities plugin link to do a search for authority records. Incomplete: There is a YUI autocomplete instance in a UNIMARC plugin (unimarc_field_210c_bis.tt) which I couldn't figure out how to test, even on a sandbox set up with UNIMARC. I could use help with a follow-up. http://bugs.koha-community.org/show_bug.cgi?id=7447 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9741|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 9742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9742&action=edit Bug 7747 - Replace YUI autocomplete with jQueryUI In order to facilitate a more painless process for converting to jQueryUI I will submit separate patches for various "widgets," starting with Autocomplete. This patch replaces all instances of YUI autocomplete with a jQueryUI version. The patch includes an up-to-date version of jQuery and jQueryUI libraries. The patch also moves some markup in instances where it should have been removed in favor of a different include. To test, find the various autocomplete instances and confirm that they are working: - Circulation search header autocomplete - Overdues patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Authorities search plugin. Edit a MARC record and use an authorities plugin link to do a search for authority records. Incomplete: There is a YUI autocomplete instance in a UNIMARC plugin (unimarc_field_210c_bis.tt) which I couldn't figure out how to test, even on a sandbox set up with UNIMARC. I could use help with a follow-up. http://bugs.koha-community.org/show_bug.cgi?id=7447 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Passes all tests outlined, is quite pretty. Passes t xt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Bug 7747 depends on bug 5184, which changed state. Bug 5184 Summary: Upgrade jQuery to the latest version http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8143 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> --- Created attachment 9784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9784&action=edit [PASSED QA] Bug 7747 - Replace YUI autocomplete with jQueryUI In order to facilitate a more painless process for converting to jQueryUI I will submit separate patches for various "widgets," starting with Autocomplete. This patch replaces all instances of YUI autocomplete with a jQueryUI version. The patch includes an up-to-date version of jQuery and jQueryUI libraries. The patch also moves some markup in instances where it should have been removed in favor of a different include. To test, find the various autocomplete instances and confirm that they are working: - Circulation search header autocomplete - Overdues patron attribute authorized value filter (must have patron attributes enabled, and a patron attribute defined which uses authorized values. - Authorities search plugin. Edit a MARC record and use an authorities plugin link to do a search for authority records. Incomplete: There is a YUI autocomplete instance in a UNIMARC plugin (unimarc_field_210c_bis.tt) which I couldn't figure out how to test, even on a sandbox set up with UNIMARC. I could use help with a follow-up. http://bugs.koha-community.org/show_bug.cgi?id=7447 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Passes all tests outlined, is quite pretty. Passes t xt Signed-off-by: Ian Walls <koha.sekjal@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9742|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Primarily a template-level patch, but with some underlying implementation changed for the auto-complete scripts. Looks much, much better. Search for patrons is done more efficiently now, but with less flexibility. I think that's a reasonable tradeoff considering this is the auto-complete, and needs to be fast. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: This patch applies smoothly, and seems to work, but I've a question before pushing. It adds many sprite images: create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/images/ui-icons_222222_256x240.png create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/images/ui-icons_2e83ff_256x240.png create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/images/ui-icons_454545_256x240.png create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/images/ui-icons_888888_256x240.png create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/images/ui-icons_cd0a0a_256x240.png What's the use of those images ? Can/should they be used in other places of Koha ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9835&action=edit Bug 7747 [FOLLOW-UP] Replace YUI autocomplete with jQueryUI This follow-up removes the default jQueryUI images and amends the staff client CSS to override calls to those images with a "Koha-native" style. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Marijana Glavica <mglavica@ffzg.hr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mglavica@ffzg.hr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable Version|master |rel_3_10 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #7)
This follow-up removes the default jQueryUI images and amends the staff client CSS to override calls to those images with a "Koha-native" style.
Thanks ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9784|0 |1 is obsolete| | Attachment #9835|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9880&action=edit Bug 7747 [FOLLOW-UP] Replace YUI autocomplete with jQueryUI This patch removes the template calls to the now-obsolete YUI JS dependencies and removes the relevant YUI files themselves. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED Version|rel_3_10 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Michael Davis <m.r.davis@cranfield.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9880|0 |1 is obsolete| | --- Comment #10 from Michael Davis <m.r.davis@cranfield.ac.uk> --- Created attachment 10047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10047&action=edit [SIGNED-OFF] Bug 7747 [FOLLOW-UP] Replace YUI autocomplete with jQueryUI This patch removes the template calls to the now-obsolete YUI JS dependencies and removes the relevant YUI files themselves. First two work perfectly, circulation search header and overdues patron authorized value. Authorities search does not seem to work, old yui file are still referenced in auth_finder.tt. The jquery works, but data set is not found, or I messed up my authority record. Signed-off-by: Koha <koha@koha.(none)> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Michael Davis <m.r.davis@cranfield.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.r.davis@cranfield.ac.uk --- Comment #11 from Michael Davis <m.r.davis@cranfield.ac.uk> --- I would apply this, and open a new bug to resolve the authorities autocomplete search and to remove the redundant js files from auth_finder.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: removing code-only path, nothing to object from QA point of view :D Note the signoff-er name does not appear, i'll fix it when pushing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #11)
I would apply this, and open a new bug to resolve the authorities autocomplete search and to remove the redundant js files from auth_finder.tt
Agreed. Patch pushed, please provide follow-up in another bug (that could usefully be marking as dependant on this one) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8241 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- I've submitted a follow-up in Bug 8241.
Authorities search does not seem to work
It's working fine for me, so please re-test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8278 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Bug 7747 depends on bug 5184, which changed state. Bug 5184 Summary: Upgrade jQuery to the latest version http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Bug 7747 depends on bug 5184, which changed state. Bug 5184 Summary: Upgrade jQuery to the latest version http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5184 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org