[Bug 13894] New: SQLHelper replacement - C4::Members::Search - reserve.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Bug ID: 13894 Summary: SQLHelper replacement - C4::Members::Search - reserve.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart@biblibre.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com reserve/request.pl currently uses C4::Members::Search. To get rid of SQLHelper, we should not use this subroutine anymore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37124&action=edit Bug 13894: Make reserve.pl not using C4::Members::Search Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Place a hold on a record 2/ Search for a patron 3/ Select a patron and submit 4/ The hold workflow should continue as previously No beviavior changes should be observed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12633 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note that this method will be applied to the circulation patron selection if this reach an agreement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 37171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37171&action=edit [Signed-off] Bug 13894: Make reserve.pl not using C4::Members::Search Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Place a hold on a record 2/ Search for a patron 3/ Select a patron and submit 4/ The hold workflow should continue as previously No behavior changes should be observed. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #37124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13822 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13822 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37171|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37330&action=edit [PASSED QA] Bug 13894: Make reserve.pl not using C4::Members::Search Important note: This will modify the UI. The patron list will now be displayed in a table (instead of a select). Test plan: 1/ Place a hold on a record 2/ Search for a patron 3/ Select a patron and submit 4/ The hold workflow should continue as previously No behavior changes should be observed. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37361&action=edit Bug 13894: Fix if the search returns only 1 result In the case where only 1 result is returned by the search, the borrowernumber should be passed correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13926 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #6)
Patch pushed to master.
Thanks Jonathan!
There is something wrong with the last past, the patrons search (using the checkout tab) is broken. Working on it and will submit a patch asap. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 37361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37361 Bug 13894: Fix if the search returns only 1 result Review of attachment 37361: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13894&attachment=37361) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +487,4 @@
[% END %]
+[% IF ( borrowers ) %]
This change was for bug 13926. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13936 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patch on bug 13936, sorry for that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org