[Bug 13892] New: SQLHelper replacement - C4::Members::Search - ysearch.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Bug ID: 13892 Summary: SQLHelper replacement - C4::Members::Search - ysearch.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart@biblibre.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com ysearch.pl currently uses C4::Members::Search. To get rid of SQLHelper, we should not use this subroutine anymore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37118&action=edit Bug 13892: Make ysearch.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan: 0/ Enable the CircAutocompl pref 1/ Go on the circulation home page, or the reserve page 2/ Search for a patron and wait for the autocompletion box 3/ Confirm there is no regression -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12633 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37118|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37125&action=edit Bug 13892: Make ysearch.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan: 0/ Enable the CircAutocompl pref 1/ Go on the circulation home page, or the reserve page 2/ Search for a patron and wait for the autocompletion box 3/ Confirm there is no regression -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 37170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37170&action=edit [Signed-off] Bug 13892: Make ysearch.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan: 0/ Enable the CircAutocompl pref 1/ Go on the circulation home page, or the reserve page 2/ Search for a patron and wait for the autocompletion box 3/ Confirm there is no regression Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #37125|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37170|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37329&action=edit [PASSED QA] Bug 13892: Make ysearch.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan: 0/ Enable the CircAutocompl pref 1/ Go on the circulation home page, or the reserve page 2/ Search for a patron and wait for the autocompletion box 3/ Confirm there is no regression Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13822 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonthan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13957 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13892 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org