http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 33223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33223&action=edit Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm While testing a bug, warnings in the opac error log were building up due to a particular line in C4::Auth. After reviewing the code, it was discovered that removal of the OpacMainUserBlockMobile system preference created this. Since the system preference no longer exists, and is not used, the line was deleted from C4/Auth.pm to prevent this warning from occuring. TEST PLAN ---------- 1) Go to any OPAC page. 2) Check your opac error log. -- there should be something about uninitialized values used in C4/Auth.pm around line 443. 3) Apply the patch 4) Refresh the page. -- that same error should not be triggered. 5) prove -v t/db_dependent/Auth.t -- this runs the get_template_and_user function which had the parameter removed. 6) run the koha qa test tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 33224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33224&action=edit [SIGNED OFF] Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm While testing a bug, warnings in the opac error log were building up due to a particular line in C4::Auth. After reviewing the code, it was discovered that removal of the OpacMainUserBlockMobile system preference created this. Since the system preference no longer exists, and is not used, the line was deleted from C4/Auth.pm to prevent this warning from occuring. TEST PLAN ---------- 1) Go to any OPAC page. 2) Check your opac error log. -- there should be something about uninitialized values used in C4/Auth.pm around line 443. 3) Apply the patch 4) Refresh the page. -- that same error should not be triggered. 5) prove -v t/db_dependent/Auth.t -- this runs the get_template_and_user function which had the parameter removed. 6) run the koha qa test tools Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Super Simple Patch.. works as expected :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33224|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33249&action=edit Bug 13200 - Followup of Bug 12246 - noisy C4/Auth.pm While testing a bug, warnings in the opac error log were building up due to a particular line in C4::Auth. After reviewing the code, it was discovered that removal of the OpacMainUserBlockMobile system preference created this. Since the system preference no longer exists, and is not used, the line was deleted from C4/Auth.pm to prevent this warning from occuring. TEST PLAN ---------- 1) Go to any OPAC page. 2) Check your opac error log. -- there should be something about uninitialized values used in C4/Auth.pm around line 443. 3) Apply the patch 4) Refresh the page. -- that same error should not be triggered. 5) prove -v t/db_dependent/Auth.t -- this runs the get_template_and_user function which had the parameter removed. 6) run the koha qa test tools Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13200 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.