http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32562&action=edit Bug 13123 - Duplicate label ids for language and opaclanguages When enabling or disabling a OPAC language choice clicking the label triggers the checkbox under the language preference instead. This is because both <label>s have the same id. This patch adds a modifier to each label and corresponding id attribute in order to make them unique. To test, go to Administration -> System preferences -> I18N/L10N. Clicking the "English (en)" label under the "language" system preference should toggle the corresponding checkbox. Clicking the "English (en)" label under the "opaclanguages" system preference should toggle the correct checkbox. Further tests: - Install an English 'sub-language' like en-GB and confirm that checkbox labels work correctly. - Install a non-English language and confirm that checkbox labels work correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32562|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32613&action=edit Bug 13123 - Duplicate label ids for language and opaclanguages When enabling or disabling a OPAC language choice clicking the label triggers the checkbox under the language preference instead. This is because both <label>s have the same id. This patch adds a modifier to each label and corresponding id attribute in order to make them unique. To test, go to Administration -> System preferences -> I18N/L10N. Clicking the "English (en)" label under the "language" system preference should toggle the corresponding checkbox. Clicking the "English (en)" label under the "opaclanguages" system preference should toggle the correct checkbox. Further tests: - Install an English 'sub-language' like en-GB and confirm that checkbox labels work correctly. - Install a non-English language and confirm that checkbox labels work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32613|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32655&action=edit [PASSED QA] Bug 13123 - Duplicate label ids for language and opaclanguages When enabling or disabling a OPAC language choice clicking the label triggers the checkbox under the language preference instead. This is because both <label>s have the same id. This patch adds a modifier to each label and corresponding id attribute in order to make them unique. To test, go to Administration -> System preferences -> I18N/L10N. Clicking the "English (en)" label under the "language" system preference should toggle the corresponding checkbox. Clicking the "English (en)" label under the "opaclanguages" system preference should toggle the correct checkbox. Further tests: - Install an English 'sub-language' like en-GB and confirm that checkbox labels work correctly. - Install a non-English language and confirm that checkbox labels work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, template changes only. -- You are receiving this mail because: You are watching all bug changes.