https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD). 1. These changed templates accessed from: Tools > Patrons and circulation > Patron card creator 2. I tested by: - Reviewing the patch - <input type="submit"... becomes <input type="submit" class="btn btn-primary"... - Listing the templates in koha-tmpl/intranet-tmpl/prog/en/modules/patroncards and splitting into two lists - those changed and those not changed - Working out how to access them - Creating screenshots and putting them in a document (I haven't attached this, but am happy to) - Applying the patch (+ flush_memcached, restart_all, and cleared browser cache) - Going through the list of files again: compared to original screenshot taken, then noted whether changed or not - Noting any questions - these don't affect the sign off for this bug 3. Files changed: - edit-layout.tt (No visible change. Manage > Layouts > select the 'Edit' action for a layout) (same template used to add new layouts) - edit-profile.tt (No visible change. Manage > Printer profiles > select the 'Edit' action for a printer) (same template used to add new printer profiles) - edit-template.tt (No visible change. Manage > Card templates > select the 'Edit' action for a template) (same template used to add new card templates) - image-manage.tt (No visible change. Manage > Images) (Bonus - add an image) (same template used to add and delete images) - print.tt (No visible change. New > Card batch > enter borrowernumbers > Add patron > select Export card batch option) 4. Files not changed: - edit-batch.tt (Manage > Card batches > [select the 'Edit' action for a batch] or [select a batch and the 'Export selected batches'] - home.tt (Patron card creator home page - no buttons apart from toolbar) - manage.tt (used to either add or edit batches (or print selected batches from a list of batches), images, layouts, card templates and printer profiles) 5. File count check: - Number of files in folder: 8 - Number of files listed: 8 (5 changed in this patch) Question 1. Should the buttons be in the div or outisde the div? Those in the white background are: - Image manager: the upload button is inside the white div area -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32088 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.