[Bug 32087] New: Consistent classes for primary buttons: Course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 Bug ID: 32087 Summary: Consistent classes for primary buttons: Course reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 32067 As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons: This patch will update buttons in course reserve templates so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes. In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32067 [Bug 32067] [OMNIBUS] Consistent classes for submit and/or primary buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143085&action=edit Bug 32087: Consistent classes for primary buttons: Course reserves This patch makes changes the button markup in course reserves templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view course reserves pages to confirm that everything looks correct. In most cases there are no visible changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143085|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 143301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143301&action=edit Bug 32087: Consistent classes for primary buttons: Course reserves This patch makes changes the button markup in course reserves templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view course reserves pages to confirm that everything looks correct. In most cases there are no visible changes. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD). 1. These changed templates accessed from: Home page > Course reserves. 2. I tested by: - Reviewing the patch - <input type="submit"... becomes <input type="submit" class="btn btn-primary"... - Listing the templates in koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/ and splitting into two lists - those changed and those not changed - Working out how to access them - Creating screenshots and putting them in a document (I haven't attached this, but am happy to) - Applying the patch (+ flush_memcached, restart_all, and cleared browser cache) - Going through the list of files again: compared to original screenshot taken, then noted whether thre is a visible change or not - Noting any questions - these don't affect the sign off for this bug 3. Files changed: - add_items-step1.tt (No visible change. Course reserves > [select or create a course] > Add reserves > [First step - barcode or biblionumber]) - add_items-step2.tt (No visible change. Next step when adding a course reserve - continues from step 1 - [select check boxes, add staff or public notes]) - batch_add_items.tt (No visible change. Course reserves > [select or create a course] > Batch add reserves) - batch_rm_items.tt (No visible change. Course reserves > Batch remove reserves) - course.tt (No visible change. Course reserves > New course) 4. Files not changed: - course-details.tt (Course reserves > [select or create a course]) - course-reserves.tt (Course reserves) (course reserves home page) - invalid-course.tt (Not sure how to trigger - has no buttons anyway) 5. File count check: - Number of files in folder: 8 - Number of files listed: 8 (5 changed in this patch) Questions/notes: none -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143301|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143505&action=edit Bug 32087: Consistent classes for primary buttons: Course reserves This patch makes changes the button markup in course reserves templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view course reserves pages to confirm that everything looks correct. In most cases there are no visible changes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32087 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org