[Bug 10005] New: inventory checks items in without warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Bug ID: 10005 Summary: inventory checks items in without warning Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: nengard@gmail.com I got this via email: ---------- This is my first time doing inventory in KOHA at our high school. I've done it at our middle school before but we always cut off book circulation before doing inventory. At the high school, our collection is so large that we have to do inventory earlier and need to continue circulating through the process. We started the process fine but ran into a problem today when I was uploading our fiction barcodes into KOHA to see the dates last seen. When I uploaded them into the Inventory/Stocktaking area, I got a list of barcodes with the message "item was on loan. It was returned before marked as seen." When I looked up the barcodes, they were all books that were checked out during the day today. When I went back into those patron accts, their checkouts had been erased. ---------- So, I think the problem here is that there is no warning or way to tell Koha to not check the items in, it just checks them in and that's that. We need the inventory tool to either ask before running if it should check things in (an enhancement) or we need a warning saying that it will check things in (a temp fix for the bug). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12327 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40990&action=edit Bug 10005: Inventory - Add an option to not check in items The inventory tools automatically check in items, this patch adds it as an option. Test plan: 1/ Check an item out, fill a file with its barcode, and use this file in the inventory tools. 2/ Check the new checkbox and confirm that the item is not checked in 3/ Repeat again and don't check it, the behavior should be the same as before this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 12327 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 40990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40990 Bug 10005: Inventory - Add an option to not check in items Review of attachment 40990: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10005&attachment=40990) ----------------------------------------------------------------- ::: tools/inventory.pl @@ +218,5 @@
+ if ($doreturn){ + push @errorloop, {'barcode'=>$barcode,'ERR_ONLOAN_RET'=>1} + } else { + push @errorloop, {'barcode'=>$barcode,'ERR_ONLOAN_NOT_RET'=>1} + }
This unless statement merely doesn't check them in. Where's the warning as requested in comment #1? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #3)
Comment on attachment 40990 [details] [review] Bug 10005: Inventory - Add an option to not check in items
Review of attachment 40990 [details] [review]: -----------------------------------------------------------------
::: tools/inventory.pl @@ +218,5 @@
+ if ($doreturn){ + push @errorloop, {'barcode'=>$barcode,'ERR_ONLOAN_RET'=>1} + } else { + push @errorloop, {'barcode'=>$barcode,'ERR_ONLOAN_NOT_RET'=>1} + }
This unless statement merely doesn't check them in. Where's the warning as requested in comment #1?
I don't get it. Did you test the patch?
From the description; "I think the problem here is that there is no warning or way to tell Koha to not check the items in" I have chosen the second way and added a checkbox.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40990|0 |1 is obsolete| | --- Comment #5 from Jason Robb <jrobb@sekls.org> --- Created attachment 41435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41435&action=edit [SIGNED OFF] Bug 10005: Inventory - Add an option to not check in items The inventory tools automatically check in items, this patch adds it as an option. Test plan: 1/ Check an item out, fill a file with its barcode, and use this file in the inventory tools. 2/ Check the new checkbox and confirm that the item is not checked in 3/ Repeat again and don't check it, the behavior should be the same as before this patch. Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've added a missing </li>. The patch would be a little nicer, if there was a nice message for 'already on loan' - but this works, as it no longer checks the item in. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41435|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42443&action=edit [PASSED QA] Bug 10005: Inventory - Add an option to not check in items The inventory tools automatically check in items, this patch adds it as an option. Test plan: 1/ Check an item out, fill a file with its barcode, and use this file in the inventory tools. 2/ Check the new checkbox and confirm that the item is not checked in 3/ Repeat again and don't check it, the behavior should be the same as before this patch. Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Added a missing </li>. Patch works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m --- Comment #10 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Could this one be in 3.18 ? Because it could result in severe loss of data. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Sophie MEYNIEUX from comment #10)
Could this one be in 3.18 ? Because it could result in severe loss of data.
Adding Liz to the CC list :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005 --- Comment #12 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Sorry I didn't check before, but apparently it is in 3.18.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org