[Bug 7599] New: Cart JavaScript contains untranslatable English strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Bug #: 7599 Summary: Cart JavaScript contains untranslatable English strings Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha.sekjal@gmail.com CC: gmcharlt@gmail.com In the OPAC and staff client cart JavaScript: function updateBasket(updated_value,target) { if(target){ target.$('#basketcount').html(" <span>("+updated_value+")</span>"); target.$('#cartDetails').html(_("Your cart contains ")+updated_value+_(" items")); } else { $('#basketcount').html(" <span>("+updated_value+")</span>"); $('#cartDetails').html(_("Your cart contains ")+updated_value+_(" items")); } var basketcount = updated_value; } Not only is this untranslatable, the structure of the sentence is probably too English-centric. Perhaps, "Items in your cart: " + count ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9710&action=edit Bug 7599 - Cart JavaScript contains untranslatable English strings To simplify the sentence structure for better translation flexibility the message now reads: "Item in your cart: " + number Fixed in both OPAC and staff client, although I'm not sure the message is actually triggered in the staff client. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9710|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9871&action=edit Bug 7599 - [SIGNED-OFF] Cart JavaScript contains untranslatable English strings To simplify the sentence structure for better translation flexibility the message now reads: "Item in your cart: " + number Fixed in both OPAC and staff client, although I'm not sure the message is actually triggered in the staff client. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Strings become translatable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <koha.sekjal@gmail.com> --- Moves string out of JS and into a variable so translation can work it's magic. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org